…coreapp2.1' with 'netcoreapp3.0' when adding is not possible.

Fixes #36313

… be missing

…f Bind, to be sure that we don't return type expression info instead of actual expression info.

Following #37610

The NGEN log files are published inside our "Build Diagnostic Logs"
container today. That is regularly around 160MB in size of which the
NGEN logs take up ~700K.

Been working on some automation / processing that is specific to NGEN
log files. Downloading the other 159MB is fairly wasteful and slow for
this automation. Publishing the NGEN files separately so I can make this
automation more effecient.

There are a few parts to this change:

1. Ensure that MSB3270 and MSB3277 warnings are promoted to errors in CI
and hence block merging.
1. Move our DiaSymReader.Native logic into a separate targets file.
This resource cannot be consumed with a simple package reference but
rather requires a package reference and custom logic to pull out the
contained binaries. This logic used to be spread through our build. Now
it's in a single place.
1. Remove the x86 bootstrapping logic. This was testing a pretty obscure
scenario and the cost of maintaining that logic is siginificant at this
point. Can bring back if we ever find a bug in this area.

The root cause of the MSB3270 warnings is a subtle change in the SDK. It
now passes the runtime graph to NuGet for native assets. In the case of
DiaSymReader.Native there are runtime specific assets hence the SDK /
NuGet had to pick one for framework projects. This eventually lead to
`PlatformTarget` being set to x86 where it shoud have been AnyCPU.

Part of the change includes adding `ExcludeAssets=all` to the package
reference which means they no longer figure into this logic and hence
the binaries are marked as AnyCPU.

This regression in behavior is being tracked by
dotnet/sdk#3495

We don't have any groovy scripts anymore.

…etion/ItemManager.cs

Co-Authored-By: Marius Ungureanu <teromario@yahoo.com>

…etion/FilterResult.cs

Co-Authored-By: Marius Ungureanu <teromario@yahoo.com>

There was a previous parsing change (#32999) which modified namespace
parsing to allow modifiers and attributes on namespaces, to improve
error recovery.

This PR contained a bug because it didn't move the incremental parsing
check to before parsing attributes and modifiers, which should now
be included in incremental parsing to prevent changes from being dropped

Fixes #37665, #37664, #37663

…eDisposedDiagnosticAnalyzer

This should fix the performance issues reported in VS feedback tickets [#672009](https://developercommunity.visualstudio.com/content/problem/672009/live-analysis-eats-up-memory-resulting-in-vs-crash.html) and [#672909](https://developercommunity.visualstudio.com/content/problem/672909/live-code-analysis-extremely-slow-and-vs-2019-cras.html)

Otherwise the infrastructure team gets tagged and that's not useful.

…culativeT completion. (#37323)

Fixes #37224
Fixes #37268
Fixes #37361

When generating code from the navigation bar, we should remove
inaccessible attributes, since there's no value in spitting code that
won't build.

Fixes #37621
 although perhaps not
in the ideal way. We may also want to generally drop all nullable
attributes when generating VB code, but that's being tracked by
#30327 as there's some design
questions still out.

…802.16

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19402.16

…803.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19403.1

…804.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19404.1

…807.9

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19407.9

Most of the type inferrer tests test both overloads of the
type inferrence service -- the one that takes a span and one that
takes a position. Both (by default) were tested, but it's impossible
without actually debugging a test to know which one failed. I had a
particular irritating case where I made a behavior change and had to
update a bunch of tests with new baselines, but since the behavior
also split between both APIs it was confusing to figure out what was
going on.

…ctor

This code as was written was a bit shaky. The Workspace constructor
would ask for the workspace option service, and this would cause us
(while creating the service) to call RegisterDocumentOptionsProvider.
If that results in one of the options providers also asking for options,
we recursively request the option service while still trying to
construct it.

The fix is just to move the registration to the workspace constructor
itself which removes the circularity and matches the pattern used
everywhere else.

…port

At this point, the flighting controls we have aren't really useful
anymore: we want this on for everybody unless the opt out, and that
opt-out would be specific to certain users that are running into issues
with the new system to keep them unblocked. I'm keeping this a per-
machine setting (that doesn't roam) because it's really repo or VS
version specific.

When we're generating code, we always will annotate any reference
types that are known to be nullable. But we might be sticking that
resulting syntax into a different file where the context disables
annotations; now we will remove those ? tokens to keep code building.

It's possible we could do fancier things too where we instead realize
the user wants to surround the code with #nullable enable, but for now
we'll take this simple approach.

Fixes #37178

If we have inferred the thing to the left of a ?? is a reference type,
we can annotate it; we didn't update that yet in the type inferrer
though until we had the ability to properly remove the ? if the
user wasn't in the right context. The parent commit of this commit fixes
that so we can fix this now.

When we're inferring around error types, we won't add ?s for now because
they're more likely to be classes than structs, and we don't know yet
exactly where the resulting syntax will get put.

#37852 will track a fancier fix
to this.

…constraints (#37800)

we can lose OOP connection due to many reason such as user explicitly killing OOP process.

we have made that not to kill VS but this one place it looks like it can still crash VS.

this could be due to StreamJsonRpc now throwing ConnectionLostException rather than general RemoteInvocationException it used to throw for everything.

when we lost exception we do the normal pattern. showing info bar asking users to restart VS and send NFW but move on.

The latest version of ilasm produced by coreclr is now a fully
independent executable; it no longer depends on having a full runtime
laid down next to it.

This means we can vastly simplify how it is deployde in our
infrastructure. The package can now be included and have ilasm manually
copied out. This is similar to the approach that we take for our
diasymreader native dependencies.

closes #37582
related #25930, #25144

Sometimes other features need to light up if there's a C# or VB project
present. A good example is some of the test tooling: they don't want to
load their components with Roslyn unless somebody is also using the test
tooling, but you don't want to accidentally load Roslyn if somebody is
using the test tooling only for C++.

Fixes https://devdiv.visualstudio.com/DevDiv/_queries/edit/844761/

It passes now; I'm guessing something was doing bad analysis at one
point and saying something was nullable when it wasn't.

Fixes #30035

Fixes #30027

NuPkg files are unpacked using lower case path names on Linux. This is
why the build wasn't copying the files.

This adds an interesting wrinkle to our algorithm for converting
array symbols back to syntax. For regular nested arrays the compiler
implicitly "reverses" the array rank specifiers so the order you see
them in source is the order you index them. But with nullable
annotations, we do not reorder across question marks.

…d_declaration_statements

…pace_around_declaration_statements

bugfix for
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/957918

Including more projects that have a dependency on ilasm.

Co-Authored-By: Nick Guerrera <nicholg@microsoft.com>

The desktop ilasm contains features not present in coreclr; specifically
the ability to generate PDB files for net modules. Need to continue
using desktop ilasm as long as our tests depend on this.

for now, it only reports method calls and member references from metadata reference.

it reports data as hash value to protect privacy

…erProvider.cs

Co-Authored-By: Joey Robichaud <joseph.robichaud@microsoft.com>

…erProvider.cs

Co-Authored-By: Joey Robichaud <joseph.robichaud@microsoft.com>

…ocess" rather than "live analysis" to reduce confusion on what "live analysis" means since term "live analysis" has strong association with "errors" in VS.

also, it now shows ## of pending work and whether BG process is paused or not.

This DLL should be marked for splitting in our test runner. When we did
the great assembly rename though this was missed. Fixing.

…rementalAnalyzerProcessor.cs

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>

…ressReporter.cs

Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>