Merge master into features/VarianceSafetyForStaticMembers #46512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch 'use auto prop' to use NRT and make us more null safe.
Enable CSharpInteractiveCommands.VerifyPreviousAndNextHistory
Enable BasicLineCommit.CommitOnSave
E.g. `[installDir]\Common7\IDE\CommonExtensions\Microsoft\ManagedLanguages\VBCSharp\LanguageServices\InteractiveHost\Desktop\InteractiveHost64.exe`
…s-deps Merge master to master-vs-deps
Remove wait for out of process start from OnLoadedAsync as it has not…
* Move to the .NET 5 SDK This is necessary for us to test features like covariant returns because we need to be able to target `net5.0` in our unit test projects. Issues encountered in this update: - WinRT is no longer supported in .NET 5. As a result we no longer multi-target .NET Core in our WinRT test assembly as well as having to disabling a few WinRT tests in others. dotnet/runtime#37672 - Change our Debugger Proxy tests to react to a runtime change dotnet/runtime@c362923 - Work around .NET5 P6 bug dotnet/sdk#11862
Rename types to not collide with the much more relevant Workspace equivalents
* Use explicit namespace for proprietary resources The Roslyn code base originated with all of our resource reference / impl DLLs being checked into a single utility project. At the point we moved to Git and went OSS these single utility project was factored into two projects for a number of reasons. 1. Keeping DLLs we didn't have license for private 1. Letting us put large binaries into a NuPkg file vs. polluting Git history When this split occured the namespaces for the utility projects were not updated. That means many types in our public and private resource projects have the same name. This makes it **really** difficult to determine where types and resources are coming from. This change adds an explicit namespace to the proprietary resource assembly. This will help make it clear which resources come from it. * Fix version * Remove version ambigutiy * Fix test failure
Replacing ILanguageServerProtocol with AbstractRequestHandlerProvider. Refactoring common Extensions method code into generic helpers.
…features/covariant-returns
…eview1-to-release/dev16.8-preview1-vs-deps Merge release/dev16.8-preview1 to release/dev16.8-preview1-vs-deps
…eview1-to-master Merge release/dev16.8-preview1 to master
…/covariant-returns Merge master to features/covariant-returns
…eview1-vs-deps-to-master-vs-deps Merge release/dev16.8-preview1-vs-deps to master-vs-deps
…/covariant-returns Merge master to features/covariant-returns
…/covariant-returns Merge master to features/covariant-returns
…er-to-master-vs-deps
…#45993) * Support nullable annotations on unconstrained type parameters Support `?` annotations on unconstrained type parameter references: - `?` annotation is allowed for type parameters that are not constrained to reference types or value types - `?` annotation is an error when used on unconstrained type parameter with `/langversion:8` Support `where T : default` constraint: - `default` constraint is allowed for method type parameters in overridden or explicitly implemented methods to disambiguate between overloads defined in the base or interface - `default` constraint is an error with `/langversion:8` - `default` constraint is an error when used outside of method overrides or explicit implementations - `default` constraint is an error when the type parameter is constrained Fixes dotnet#29146
…s-deps Merge master to master-vs-deps
Report teh project name that we were unable to recover a symbol from.
Added search option for inline parameter name hints
…features/covariant-returns
Also fix unintentional priority change for StartOnIdle.
check if EditorAdaptersFactoryService gives us a null buffer
Rework compiler server abstraction
* Updated Error Message for CS1673 * TODOify * Revert "Updated Error Message for CS1673" This reverts commit 68fc0c8. * PR Changes * PR changes * Update SolutionState.TrackedGeneratorDriver.cs
…/covariant-returns Merge master to features/covariant-returns
Update IThreadingContext to support safe asynchronous shutdown
Merge features/covariant-returns to master
* Add ServiceLayer.Test that overrides any other layer or workspace kind. Mark all services used for testing with ServiceLayer.Test. Remove WorkspaceKind.Test and set the kind of TestWorkspace to `host`. * Move MockWorkspaceEventListenerProvider to Fatures test composition * Enable solution crawler in diagnostic tests
Remove unnecessary conditional compilation
|
Hello @AlekseyTs! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.