build(client): use flub generate api #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-ha
force-pushed
the
use-flub-generate-api
branch
2 times, most recently
from
26eea46
to
04af270
Compare
## Description Remove mutability from a few places in the public API it does not appear to be needed. The change to IValueChanged seems like a bug fix since the same object is provided to all registrants for the event, so they modify the object it would impact other event receivers which seems like bad coupling. I Suspect the other changes are similar in nature: I don't think mutation of any of these was intended to be supported or meaningful, but I could be wrong about this. ## Breaking Changes This is a breaking change, since some users of these interfaces could be modifying them, and this could break.
## Description Continues the pattern started with ArrayNode, and centralize the ObjectNode logic in one file.
## Description This refactors ModularChangeset to store node changesets in a table keyed by a newly introduced node ID. Field specific changesets are no longer stored recursively, but instead refer to nested changes by node ID. This is a first step toward refactoring ModularChangeFamily to enable improving efficiency of its operations. Sequence changesets no longer need to be templated over the child change type, but this will be addressed in a subsequent PR. --------- Co-authored-by: yann-achard-MS <97201204+yann-achard-MS@users.noreply.github.com> Co-authored-by: Yann Achard <achardy@microsoft.com>
## Description Inline ArrayToUnion since its simple and only used once. This avoids having yet another type computation helper in the public API surface. ## Breaking Changes Any external users of ArrayToUnion should replace `ArrayToUnion<TheArray>` with `TheArray[number]`.
## Description Make factory tag object for DataObjectClass readonly.
## Description Centralize mapNode logic in one file.
…d README updates. (microsoft#20479)
This change - Collects better telemetry about tree / blob structure of snapshots. In particular, we want to know. - number of blobs vs. number of blob leaf nodes in the tree. This difference will be influenced by attachment blobs (missing from the snapshot) and any blob deduping service does. That said, this PR stops short of deduping these cases. - Provide better stats on number of trees, include leaf trees. We have "leafTrees" but it was counting all trees, not just leaf nodes. - Added "fast" parsing case for empty trees - Added asserts in unit tests that validate our telemetry about slow parsing paths is correct. - Deleted second version of evalBlobsAndTrees function that was not exported from package and was not used.
creates API entrypoints per tagged level using simple re-exports from the given main entrypoint file. Some special case exports like `export * as foo` (a NamespaceExport) are not handled, but that is also true for api-extractor which is used in concert. exports without recognizable level are ignored which gives correct conservative result but may hinder shaping API as we would really prefer.
microsoft#20506) ## Description - makes AppInsightsTelemetryConsumer available under default export paths instead of subpathing, - updates API report - removes extraneous api-report from old package name "external-telemetry"
…osoft#20487) From `^2.0.201` to `^2.0.233`
- Look for namespace exports and source local exports that may have JSDocs that are determined using ExportedDeclarations. - Change unknown case to be a map and additional data as collected. - Fix incrementality task typo
- replace api-extractor use in api-extractor tasks with flub generate entrypoints - add build-cli devDep where now needed - remove then unused api-extractor-cjs.json files - remove dtsRollup enable from api-extractor configs; now just used for reports
jason-ha
force-pushed
the
use-flub-generate-api
branch
from
2850cda
to
da9a795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.