Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue3026 single pane #3038

Closed
wants to merge 210 commits into from
Closed

Issue3026 single pane #3038

wants to merge 210 commits into from

Conversation

JayHuLBL
Copy link
Contributor

This closes #3026.

@mwetter I am not sure how to add the release note. Should it be in the version 8.1.2?

mwetter and others added 30 commits June 9, 2021 04:03
* Updated release info for next version development

* Changed link from latest to v8.0.0

* Updated url for modelica.org

* Corrected html

* Regenerated users guide
* Remove experiment annotation

* Change start value (for #2510)

* Update results
* Merged IBPSA, branch issue1389_mediaSteam

This merges Media.Steam

* Reimplemented g2

This is needed for Optimica as the original implementation is not declared to be differentiable
* corrected component declaration in BESTEST class #2555 [ci skip]

* corrected component declaration in FLEXLAB class #2555 [ci skip]

* added undeclared parameters, #2556 [ci skip]

* dummy commit to kick off CI test #2556
* Change coil model, update documentation

* Release and revision notes

* Update FCU models in DHC

* Add start value to hAirOut

Co-authored-by: jayhulbl <JianjunHu@lbl.gov>
…2571)

* Added test to avoid event at t=8.666180323908523E-06

For #2570

* Removed non-used block for #2570

* Updated reference results for #2570

* Merged master, updated reference results

* Excluded model for JModelica tests

* Changed mat file name

* Change mat name, LIMIT CI to faulty models

* Restore full CI

* Fix incorrect variable name in script

Co-authored-by: Antoine Gautier <agautier@lbl.gov>
* Remove hysteresis

* Update release notes

* Update results

* Minor

* Update results

* Added test to avoid event at t=8.666180323908523E-06

For #2570

* Removed non-used block for #2570

* Updated reference results for #2570

* Merged master, updated reference results

* Merged issue2570_ashrae2006_event, updated reference results, added info section

* Excluded model for JModelica tests

* Rename mat file in script

* Fix incorrect variable name in script

Co-authored-by: Michael Wetter <mwetter@lbl.gov>
…one model (#2575)

* Slightly moved the connectors for weather data and HVAC

This places the connector locations consistently for the VAV model with the Spawn and the native Modelica envelope model

* Renamed mat file name
* Correct description strings

* Implement WSE

* Fix connect clauses

* Include pressure boundary condition

* Refactor for WSE

* Fix parameter binding, fix dBor assignment

* Remove mSerWat_flow_nominal, restore m1WSE_flow_nominal

* Refactor for nin / nu

* Revert incorrect change
* Reimplemented filter for ibpsa/modelica-ibpsa#1498

* Updated reference results for new filter

* Removed y_start from Movers that declare m_flow_start and dp_start

* Set solver to Radau for DualFanDualDuct in OPTIMICA
* Set start value for frame to avoid warning

This also reformats the file

* Reformatted file

* Updated reference results due to setting window frame dT start=0
* Removed duplicate declaration of VABp_flow

* Merged IBPSA, issue1513_pressureIndependent

* Set start value for frame to avoid warning

This also reformats the file

* Reformatted file

* Removed empty line

* Updated reference results due to setting window frame dT start=0

* Merged IBPSA

* Reimplemented computation of HVAC energy in ScalableBenchmarks
* Made BaseProperties replaceable in Media.Air

For IBPSA, PR 1516

* Merged IBPSA, patch_air_replaceable_baseproperties

* Refactored energy output calculation and air infiltration

This commit replaces the heating or cooling power output of the room with outputs for heating or cooling energy. This is done because the values quickly change, and in the CI testing, this output variable caused often a failure at the very last time stamp of the simulation.

This version also improves the infiltration. Now, exactly the same amount of air in infiltrated and
exfiltrated. This was not the case previously because the infiltration was a prescribed air flow rate,
and the exfiltration was based on pressure difference. This caused an inbalance in the HVAC supply and
return air flow rate.

* Excluded simulation with JModelica, see https://app.travis-ci.com/github/lbl-srg/modelica-buildings/jobs/531423041
…2591)

This implementation also changes from state to time events. For #2590
* adding ground temperature model

* Add two pipes in conduit example

* Add ground coupling validation with AIT data

Co-authored-by: AntoineGautier <agautier@lbl.gov>
Co-authored-by: Michael Wetter <mwetter@lbl.gov>
* Made the hysteresis blocks public as they may be of interest to look at

* Declared mskID as parameter

This also avoids the OPTIMICA warning 'Variable array index in equation can result in slow simulation time'

* Changed default component name, updated revision section

Co-authored-by: jayhulbl <JianjunHu@lbl.gov>
Co-authored-by: Michael Wetter <mwetter@lbl.gov>
* Refactored VAV models for #2594

* Corrected pump curve

* Updated heating design temperature, corrected freeze protection for economizer

* Updated figure with valve
* Add cooling plant models from the GMT staging branch

* put the number of pumps as protected parameter & add headered

* Replaced PI controller with version from CDL

* Removed non-needed use of input filter

The filter is already part of the actuator and hence the top-level model need not extend the filter dynamics

* set nFue to 0 final

Co-authored-by: = <jing.wang@colorado.edu>
Co-authored-by: ChengnanShi-Work <82961137+ChengnanShi-Work@users.noreply.github.com>
Co-authored-by: JingWang-CUB <31628742+JingWang-CUB@users.noreply.github.com>
Co-authored-by: Katy Hinkelman <kathryn.hinkelman@colorado.edu>
Co-authored-by: Baptiste Ravache <48033702+bravache@users.noreply.github.com>
Co-authored-by: ChengnanShi-Work <chsh8048@colorado.edu>
Co-authored-by: Katy Hinkelman <44682485+khinkelman@users.noreply.github.com>
Co-authored-by: Michael Wetter <mwetter@lbl.gov>
* Updated documentation for #2600
* Refactored radiant heating controller for #2596

* Removed setuptools from pip3

This should correct the error in https://github.com/lbl-srg/modelica-buildings/runs/3537594704?check_suite_focus=true
mwetter and others added 27 commits April 19, 2022 04:03
… example time (#2970)

* Changed function signature, removed call to impure functions, reduced example time

For #2969

* Ensured nominal value does not violate max constraint

This avoids a warning in OpenModelica

* Reduced experiment time

* Updated log message
* Changed to newer binary

For #2863. This version uses a unique name for binaries/epfmi_4dcf1ba44053dda2c12d1c678f3a1627.so

* Updated Spawn version in install script

* Handled git removal if binaries were not yet committed

* Updated git handling in install script

* Updated to Spawn 59ed8c72e4

* Added VCRUNTIME140.dll back, needed by ModelicaBuildingsEnergyPlus_9_6_0.dll
* Corrected hyperlinks

For #2960

* Corrected hyperlinks in IBPSA library

For #2960
This merges the upstream changes of the IBPSA library
…2986)

* corrected inequality check in continuous package

* updated references

* updated release note
This corrects wrong use of convertClass
* Corrected conversion script entries

This corrects wrong use of convertClass

* Removed non-needed start values

This is for #2990

* Changed parameter y_start to pre_u_start. Reverted other changes.

For #2990

* Updated release notes
For #2963

* Updated BuildingsPY version

* Updated OCT version to 2022-05-09-master-4b0cd2bf71

* Added obsolete Python3.6 to OCT exclude list

They now fail with '/usr/bin/ld: cannot find -lpython3.6m' as Python 3.6 is not installed in the docker image

* Updated BuildingsPy to version that does not use output logger for compilation
This updates the docker image that has uses the updated license file
* Enabled simulation for OPTIMICA

* Cleaned up configuration file.

Added EnergyPlus_9_6_0.Examples.SmallOffice.Unconditioned back to exclude list for OPTIMICA
)

* Removed parameter p in Fluid.Storage.ExpansionVessel
This change lists all inputs before all outputs
* Removed protected declaration in record

For #3009
This ensures that if a record is dragged in a GUI, it will be declared as a parameter
This updates BuildingsPy to the latest release
* corrected var description Buildings.Applications.DataCenters.ChillerCooled.Equipment.BaseClasses.PartialPumpParallel

* removed empty subplots Buildings.Applications.BaseClasses.Equipment.Validation.ElectricChillerParallel

* corrected var name and description Buildings.Fluid.Storage.Examples.StratifiedUnloadAtMinimumTemperature

* corrected typo in documentation Buildings.Fluid.Interfaces.PartialTwoPortTransport

* corrected descriptions and documentations Buildings.Controls.OBC.CDL.Conversions

* corrected typo in Buildings.Fluid.Examples.ResistanceVolumeFlowReversal

* updated revision and release notes for changes under OBC

* reverted graphic change made by Dymola in a file not intended to be changed

* Added line breaks

Co-authored-by: Michael Wetter <mwetter@lbl.gov>
* Removed Resources/bin/spawn-0.3.0-59ed8c72e4

For #3018

* Corrected hash in file name

* Updated install script to support multiple versions

* Changed spawn install folder to Spawn-light-version-commit

* Added EnergyPlus binary installation

* Updated install section

* Updated doc, added Windows binaries, added install.py
* Updated Spawn for #2852

* Fixed typo in comment

* Corrected call to fmi2_import_terminate

The function fmi2_import_terminate must only be called in event mode or continuous time mode
* Adding deletion of files that are extracted from the FMU.

Corrected bug as the function fmi2_import_terminate must only be called in event mode or continuous time mode
@JayHuLBL JayHuLBL requested a review from mwetter May 24, 2022 17:59
@JayHuLBL
Copy link
Contributor Author

Close this PR as the new change should base on the maint.8.1.x. Will make another PR soon.

@JayHuLBL JayHuLBL closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants