Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.1.0 release proposal #47820

Merged
merged 147 commits into from
May 3, 2023
Merged

v20.1.0 release proposal #47820

merged 147 commits into from
May 3, 2023

Commits on May 2, 2023

  1. deps: update undici to 5.21.1

    PR-URL: #47488
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ba9ec91 View commit details
    Browse the repository at this point in the history
  2. src: slim down stream_base-inl.h

    PR-URL: #46972
    Refs: #43712
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    lilsweetcaligula authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    adc1601 View commit details
    Browse the repository at this point in the history
  3. src: use correct variable in node_builtins.cc

    PR-URL: #47343
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    cda36bf View commit details
    Browse the repository at this point in the history
  4. doc: create maintaining-brotli.md

    PR-URL: #47380
    Refs: nodejs/security-wg#828
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    marco-ippolito authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    537c17e View commit details
    Browse the repository at this point in the history
  5. tools: move update-undici.sh to dep_updaters and create maintain md

    PR-URL: #47380
    Refs: nodejs/security-wg#828
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    marco-ippolito authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2e83381 View commit details
    Browse the repository at this point in the history
  6. doc: add KhafraDev to collaborators

    Fixes: #47388
    PR-URL: #47510
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    KhafraDev authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9d30f46 View commit details
    Browse the repository at this point in the history
  7. bootstrap: support namespaced builtins in snapshot scripts

    PR-URL: #47467
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    202042e View commit details
    Browse the repository at this point in the history
  8. meta: add mailmap entry for KhafraDev

    This will make `git log` entries for KhafraDev show up using the name
    in the README, which is required so that find-inactive-collaborators.mjs
    doesn't incorrectly flag him for removal.
    
    PR-URL: #47512
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Trott authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8d43689 View commit details
    Browse the repository at this point in the history
  9. stream: preserve object mode in compose

    Fixes: #46829
    
    PR-URL: #47413
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    rluvaton authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2b411f4 View commit details
    Browse the repository at this point in the history
  10. deps: V8: cherry-pick 8e10685ff918

    Original commit message:
    
        [build]: fix wrong name
    
        Change-Id: I504e836da1e36d7b9e504dbdbff8803363f08ccd
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4392064
        Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
        Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#86919}
    
    Refs: v8/v8@8e10685
    PR-URL: #47440
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    gengjiawen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2664536 View commit details
    Browse the repository at this point in the history
  11. wasi: make returnOnExit true by default

    Refs: #46923
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #47390
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    75c1d1b View commit details
    Browse the repository at this point in the history
  12. tools: automate ngtcp2 and nghttp3 update

    PR-URL: #47402
    Refs: nodejs/security-wg#828
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    marco-ippolito authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e4d9585 View commit details
    Browse the repository at this point in the history
  13. doc: fix typo in util.types.isNativeError()

    This is a small fix for my recent PR that fixes a typo in the
    realm example.
    
    PR-URL: #47532
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    brodo authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4046280 View commit details
    Browse the repository at this point in the history
  14. deps: update simdutf to 3.2.8

    PR-URL: #47507
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    64b5a5f View commit details
    Browse the repository at this point in the history
  15. deps: update undici to 5.21.2

    PR-URL: #47508
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ede69d2 View commit details
    Browse the repository at this point in the history
  16. url: validate argument length in canParse

    PR-URL: #47513
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    KhafraDev authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4839fc4 View commit details
    Browse the repository at this point in the history
  17. url: validate URL constructor arg length

    PR-URL: #47513
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    KhafraDev authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    180d365 View commit details
    Browse the repository at this point in the history
  18. tools: add missing pinned dependencies

    PR-URL: #47346
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    mateonunez authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    233b628 View commit details
    Browse the repository at this point in the history
  19. tools: automate uvwasi dependency update

    Refs: nodejs/security-wg#828
    PR-URL: #47509
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Ranieri93 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9e3e0b0 View commit details
    Browse the repository at this point in the history
  20. benchmark: add a benchmark for defaultResolve

    PR-URL: #47543
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    aduh95 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    936d7cb View commit details
    Browse the repository at this point in the history
  21. doc: fix split infinitive in Hooks caveat

    PR-URL: #47550
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    JakobJingleheimer authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0dc5080 View commit details
    Browse the repository at this point in the history
  22. benchmark: differentiate whatwg and legacy url

    PR-URL: #47377
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    40324a1 View commit details
    Browse the repository at this point in the history
  23. test: mark test-cluster-primary-error flaky on asan

    PR-URL: #47422
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    826f404 View commit details
    Browse the repository at this point in the history
  24. readline: fix issue with newline-less last line

    The logic for reading lines was slightly flawed, in that it assumed
    there would be a final new line. It handled the case where there are no
    new lines, but this then broke if there were some new lines.
    
    The fix in logic is basically removing the special case where there are
    no new lines by changing it to always read the final line with no new
    lines. This works because if a file contains no new lines, the final
    line is the first line, and all is well.
    
    There is some subtlety in this functioning, however. If the last line
    contains no new lines, then `lastIndex` will be the start of the last
    line, and `kInsertString` will be called from that point. If it does
    contain a new line, `lastIndex` will be equal to `s.length`, so the
    slice will be the empty string.
    
    Fixes: #47305
    PR-URL: #47317
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    harrisi authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    af227b1 View commit details
    Browse the repository at this point in the history
  25. lib: use webidl DOMString converter in EventTarget

    PR-URL: #47514
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    KhafraDev authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e8bc03b View commit details
    Browse the repository at this point in the history
  26. url: handle URL.canParse without base parameter

    PR-URL: #47547
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9aae767 View commit details
    Browse the repository at this point in the history
  27. doc: update darwin-x64 toolchain used for Node.js 20 releases

    Refs: #47067
    PR-URL: #47546
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f9abd59 View commit details
    Browse the repository at this point in the history
  28. doc: add missing setEncoding call in ESM example

    Adding `setEncoding()` ensures that the example handles characters
    split across chunk boundaries well.
    
    PR-URL: #47558
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    addaleax authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    7ca416a View commit details
    Browse the repository at this point in the history
  29. build: replace Python linter flake8 with ruff

    PR-URL: #47519
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cclauss authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    78c0824 View commit details
    Browse the repository at this point in the history
  30. doc: add link for news from uvwasi team

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    PR-URL: #47531
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b0b16ee View commit details
    Browse the repository at this point in the history
  31. esm: avoid try/catch when validating urls

    PR-URL: #47541
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    889add6 View commit details
    Browse the repository at this point in the history
  32. esm: avoid accessing lazy getters for urls

    PR-URL: #47542
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    269482f View commit details
    Browse the repository at this point in the history
  33. tools: add performance label to benchmark changes

    PR-URL: #47545
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ff73c05 View commit details
    Browse the repository at this point in the history
  34. tools: add url and whatwg-url labels automatically

    PR-URL: #47545
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6af7f1e View commit details
    Browse the repository at this point in the history
  35. build: bump ossf/scorecard-action from 2.1.2 to 2.1.3

    Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.1.3.
    - [Release notes](https://github.com/ossf/scorecard-action/releases)
    - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
    - [Commits](ossf/scorecard-action@e38b190...80e868c)
    
    PR-URL: #47367
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    35e8b3b View commit details
    Browse the repository at this point in the history
  36. src: fix CSPRNG when length exceeds INT_MAX

    CSPRNG implicitly casts the size_t length argument to a signed int when
    calling RAND_bytes(), which leaves it up to the caller to ensure that
    the length argument actually fits into such a signed int. However, not
    all call sites explicitly ensure that, which could lead to subtle bugs.
    
    In OpenSSL 3, use RAND_bytes_ex() instead, which does not require
    casting the length to a signed int.
    
    In OpenSSL 1.1.1, RAND_bytes_ex() is not supported, thus we have to
    process blocks of size INT_MAX one by one.
    
    PR-URL: #47515
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    57e7ed7 View commit details
    Browse the repository at this point in the history
  37. src: replace static const string_view by static constexpr

    PR-URL: #47524
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lemire authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    daf0c78 View commit details
    Browse the repository at this point in the history
  38. test_runner: fix spec skip detection

    PR-URL: #47537
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4203057 View commit details
    Browse the repository at this point in the history
  39. src: fix typo in process.env accessor error message

    PR-URL: #47014
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    moritzraho authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ba255ed View commit details
    Browse the repository at this point in the history
  40. src: use v8::Boolean(b) over b ? True() : False()

    Simplify existing code by using v8::Boolean::New() instead of equivalent
    expressions that contain ternary operators.
    
    PR-URL: #47554
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    cf48db0 View commit details
    Browse the repository at this point in the history
  41. typings: fix syntax error in tsconfig

    Trailing commas are invalid in JSON files.
    
    PR-URL: #47584
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    VoltrexKeyva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8712eaf View commit details
    Browse the repository at this point in the history
  42. deps: patch V8 to 11.3.244.8

    Refs: v8/v8@11.3.244.4...11.3.244.8
    PR-URL: #47536
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    13105c1 View commit details
    Browse the repository at this point in the history
  43. deps: update ICU to 73.1 release

    - Details: https://icu.unicode.org/download/73
    
    PR-URL: #47456
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    srl295 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    7f7735c View commit details
    Browse the repository at this point in the history
  44. crypto: remove INT_MAX restriction in randomBytes

    This restriction was due to an implementation detail in CSPRNG(). Now
    that CSPRNG() properly handles lengths exceeding INT_MAX, remove this
    artificial restriction.
    
    Refs: #47515
    PR-URL: #47559
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    420feb4 View commit details
    Browse the repository at this point in the history
  45. doc: fix typo in webcrypto metadata

    PR-URL: #47595
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2a0bbe7 View commit details
    Browse the repository at this point in the history
  46. doc: fix release-post script location

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: #47517
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    RafaelGSS authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d3fadd8 View commit details
    Browse the repository at this point in the history
  47. quic: add more QUIC implementation

    * add TLSContext
    * quic: add stat collection utilities
    * add Packet
    * add NgTcp2CallbackScope/NgHttp3CallbackScope
    
    PR-URL: #47494
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    jasnell authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e8ea834 View commit details
    Browse the repository at this point in the history
  48. node-api: remove unused mark_arraybuffer_as_untransferable

    napi_create_external_arraybuffer creates the arraybuffer with
    node::Buffer, which already marks the buffer as untransferable.
    The napi_env__::mark_arraybuffer_as_untransferable is not used
    anymore.
    
    PR-URL: #47557
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    12f0fa3 View commit details
    Browse the repository at this point in the history
  49. test_runner: avoid reporting parents of failing tests in summary

    PR-URL: #47579
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MoLow authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ec24aba View commit details
    Browse the repository at this point in the history
  50. doc: fix history ordering of WASI constructor

    PR-URL: #47611
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c36634e View commit details
    Browse the repository at this point in the history
  51. doc: remove markdown link from heading

    This is the only instance of such a link and it is rendered
    incorrectly in the TOC.
    
    PR-URL: #47585
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b58920c View commit details
    Browse the repository at this point in the history
  52. test_runner: execute before hook on test

    Execute the before hook for Test as well, and execute it on root before
    executing any tests.
    
    Fixes: #47518
    PR-URL: #47586
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    atlowChemi authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    bdd02a4 View commit details
    Browse the repository at this point in the history
  53. esm: propagate process.exit from the loader thread to the main thread

    PR-URL: #47548
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    aduh95 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    55f70f6 View commit details
    Browse the repository at this point in the history
  54. tools: automate zlib update

    PR-URL: #47417
    Refs: nodejs/security-wg#828
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    marco-ippolito authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1509312 View commit details
    Browse the repository at this point in the history
  55. tools: add option to run workflow with specific tool id

    PR-URL: #47591
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    7c552e6 View commit details
    Browse the repository at this point in the history
  56. tools: add update script for googletest

    GoogleTest follows the Abseil Live at Head philosophy, and rarely
    creates tags or GitHub releases, so instead, follow Google's
    recommendation and update to the upstream HEAD every once in a while.
    
    The tricky bit is properly updating googletest.gyp, and this script
    might fail doing so in the future.
    
    Refs: nodejs/security-wg#828
    PR-URL: #47482
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e3f4ff4 View commit details
    Browse the repository at this point in the history
  57. doc: improve fs permissions description

    Fix a small grammatical mistake and improve the surrounding wording.
    
    PR-URL: #47596
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d11ff4b View commit details
    Browse the repository at this point in the history
  58. deps: update ada to 2.1.0

    PR-URL: #47598
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3154543 View commit details
    Browse the repository at this point in the history
  59. esm: initialize import.meta on eval

    PR-URL: #47551
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    aduh95 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c150976 View commit details
    Browse the repository at this point in the history
  60. tools: add execution permission to uvwasi script

    PR-URL: #47600
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mertcanaltin authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    fbe7d73 View commit details
    Browse the repository at this point in the history
  61. esm: remove support for deprecated hooks

    Those have been deprecated for a while, it's time.
    
    PR-URL: #47580
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    fbb6b72 View commit details
    Browse the repository at this point in the history
  62. node-api: test passing NULL to number APIs

    PR-URL: #47549
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    gabrielschulhof authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    568256d View commit details
    Browse the repository at this point in the history
  63. src: make AliasedBuffers in the binding data weak

    The binding data holds references to the AliasedBuffers directly
    from their wrappers which already ensures that the AliasedBuffers
    won't be accessed when the wrappers are GC'ed. So we can just
    make the global references to the AliasedBuffers weak. This way
    we can simply deserialize the typed arrays when deserialize the
    binding data and avoid the extra Object::Set() calls. It also
    eliminates the caveat in the JS land where aliased buffers must
    be dynamically read from the binding.
    
    PR-URL: #47354
    Refs: #47353
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    cfafe43 View commit details
    Browse the repository at this point in the history
  64. fs: add support for mode flag to specify the copy behavior

    `fs.copyFile()` supports copy-on-write operation
    if the underlying platform supports it by passing a mode flag.
    This behavior was added in
    a16d88d.
    
    This patch adds `mode` flag to `fs.cp()`, `fs.cpSync()`,
    and `fsPromises.cp()` to allow to change their behaviors
    to copy files.
    
    This test case is based on the test case that was introduced
    when we add `fs.constants.COPYFILE_FICLONE`.
    a16d88d.
    
    This test strategy is:
    
    - If the platform supports copy-on-write operation,
      check whether the destination is expected
    - Otherwise, the operation will fail
      and check whether the failure error information is expected.
    
    Fixes: #47080
    PR-URL: #47084
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    tetsuharuohzeki authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a54e898 View commit details
    Browse the repository at this point in the history
  65. Revert "tools: ensure failed daily wpt run still generates a report"

    This reverts commit b17227b.
    
    PR-URL: #47627
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    panva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c17f268 View commit details
    Browse the repository at this point in the history
  66. Revert "test: run WPT files in parallel again"

    This reverts commit c05689e.
    
    PR-URL: #47627
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    panva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9d3768e View commit details
    Browse the repository at this point in the history
  67. doc: change offset of example in Buffer.copyBytesFrom

    Actual output is different from expected output if offset is 0.
    Plus, removed unused importing `Buffer`.
    
    PR-URL: #47606
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    deokjinkim authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    183f0c3 View commit details
    Browse the repository at this point in the history
  68. tools: update PR label config

    - Update paths to the new ones.
    - Remove paths that no longer exist.
    - Capitalize comments and quote labels mentioned within.
    - Fix syntax error in regex.
    - Add missing JavaScript subsystems.
    
    PR-URL: #47593
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    VoltrexKeyva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    87cae0c View commit details
    Browse the repository at this point in the history
  69. inspector: add tips for Session

    PR-URL: #47195
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    theanarkh authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    94a5abb View commit details
    Browse the repository at this point in the history
  70. src: add v8 fast api for url canParse

    PR-URL: #47552
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    KhafraDev authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    872e670 View commit details
    Browse the repository at this point in the history
  71. fs: add recursive option to readdir and opendir

    Adds a naive, linear recursive algorithm for the following methods:
    readdir, readdirSync, opendir, opendirSync, and the promise based
    equivalents.
    
    Fixes: #34992
    PR-URL: #41439
    Refs: nodejs/tooling#130
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Ethan Arrowood authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    439ea47 View commit details
    Browse the repository at this point in the history
  72. deps: add minimatch as a dependency

    PR-URL: #47499
    Refs: #47490
    Refs: #47486
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    MoLow authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1391d3b View commit details
    Browse the repository at this point in the history
  73. tools: fix updating root certificates

    When searching for the latest certdata.txt, check that the file
    exists on the remote server.
    
    PR-URL: #47607
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b8927dd View commit details
    Browse the repository at this point in the history
  74. doc: update error code of buffer

    According to use of `validateNumber`, error code is changed
    from ERR_INVALID_ARG_VALUE to ERR_OUT_OF_RANGE.
    
    Refs: #45796
    PR-URL: #47617
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    deokjinkim authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9101630 View commit details
    Browse the repository at this point in the history
  75. loader: use default loader as cascaded loader in the in loader worker

    Use the default loader as the cascaded loader in the loader worker.
    Otherwise we spawn loader workers in the loader workers indefinitely.
    
    PR-URL: #47620
    Fixes: #47566
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    joyeecheung authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    91e4a7c View commit details
    Browse the repository at this point in the history
  76. tools: keep PR titles/description up-to-date

    Set the `update-pull-request-title-and-body` option when potentially
    updating an existing PR with a dynamic title and/or description.
    
    PR-URL: #47621
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0887fa0 View commit details
    Browse the repository at this point in the history
  77. lib: disallow file-backed blob cloning

    Disallow cloning of file-backed Blobs. If necessary, we can enable
    this later but for now we disable it. The reason is because the
    underlying FdEntry ends up bound to the Environment/Realm under
    which is was created and transfering across worker threads ends up
    failing.
    
    Fixes: #47334
    PR-URL: #47574
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b8bdaf8 View commit details
    Browse the repository at this point in the history
  78. build: add devcontainer configuration

    PR-URL: #40825
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bnb authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5b851c8 View commit details
    Browse the repository at this point in the history
  79. doc,fs: update description of fs.stat() method

    PR-URL: #47654
    Fixes: #47633
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    mertcanaltin authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    09ff9ea View commit details
    Browse the repository at this point in the history
  80. doc: fix typos in SECURITY.md

    PR-URL: #47677
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    VoltrexKeyva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    78a3503 View commit details
    Browse the repository at this point in the history
  81. tools: update lint-md-dependencies to @rollup/plugin-commonjs@24.1.0

    PR-URL: #47577
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ccf9c37 View commit details
    Browse the repository at this point in the history
  82. test_runner: move coverage collection to root.postRun()

    This commit moves code coverage collection from the test
    harness exit handler to the postRun() function of the root
    test.
    
    This is necessary preparatory work for supporting
    code coverage with --test. The reason is that --test is
    implemented on top of run(), and that function calls the root
    test's postRun() function, which outputs the test summary. This
    happens before the harness exit handler.
    
    PR-URL: #47651
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    cjihrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1f120a3 View commit details
    Browse the repository at this point in the history
  83. test_runner: support coverage of unnamed functions

    This commit updates the code coverage logic to skip the first
    function in a file (which does not correspond to an actual
    function) instead of skipping all functions without a name.
    
    PR-URL: #47652
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    cjihrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b6fb791 View commit details
    Browse the repository at this point in the history
  84. doc: fix capitalization of ASan

    PR-URL: #47676
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    VoltrexKeyva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f30ef24 View commit details
    Browse the repository at this point in the history
  85. crypto: update root certificates to NSS 3.89

    This is the certdata.txt[0] from NSS 3.89, released on 2023-03-09.
    
    This is the version of NSS that shipped in Firefox 112 on
    2023-04-11.
    
    Certificates removed:
    - Network Solutions Certificate Authority
    - EC-ACC
    - Staat der Nederlanden EV Root CA
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_89_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #47659
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2d97c89 View commit details
    Browse the repository at this point in the history
  86. test_runner: add testNamePatterns to run api

    Accept a `testNamePatterns` value in the `run` fn, and drill those
    patterns to the spawned processes.
    
    PR-URL: #47648
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    atlowChemi authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5327483 View commit details
    Browse the repository at this point in the history
  87. doc: fix typos

    PR-URL: #47685
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    VoltrexKeyva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4cef988 View commit details
    Browse the repository at this point in the history
  88. test_runner: fix nested hooks

    PR-URL: #47648
    Fixes: #47643
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5a9b71a View commit details
    Browse the repository at this point in the history
  89. lib: improve esm resolve performance

    PR-URL: #46652
    Refs: nodejs/performance#39
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    anonrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    21ff331 View commit details
    Browse the repository at this point in the history
  90. http: add highWaterMark opt in http.createServer

    Add highWaterMark option when creating a new HTTP server.
    This option will override the default (readable|writable)
    highWaterMark values on sockets created.
    
    Fixes: #46606
    PR-URL: #47405
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    HinataKah0 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4fa7739 View commit details
    Browse the repository at this point in the history
  91. doc: fix a typo in fs.openAsBlob

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #47693
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    daeyeon authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c0c23fb View commit details
    Browse the repository at this point in the history
  92. esm: rename URLCanParse to be consistent

    PR-URL: #47668
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a793cf4 View commit details
    Browse the repository at this point in the history
  93. doc: clarify concurrency model of test runner

    Refs: #47365
    PR-URL: #47642
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a1403a8 View commit details
    Browse the repository at this point in the history
  94. tools: fix skip message in update-cjs-module-lexer

    Refs: #47446
    PR-URL: #47701
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d2994e5 View commit details
    Browse the repository at this point in the history
  95. test_runner: fix test counting

    PR-URL: #47675
    Fixes: #47365
    Fixes: #47696
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2d7cac0 View commit details
    Browse the repository at this point in the history
  96. test_runner: fix test runner concurrency

    PR-URL: #47675
    Fixes: #47365
    Fixes: #47696
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    40b3879 View commit details
    Browse the repository at this point in the history
  97. deps: update ada to 2.2.0

    PR-URL: #47678
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f3ee312 View commit details
    Browse the repository at this point in the history
  98. deps: update undici to 5.22.0

    PR-URL: #47679
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9962459 View commit details
    Browse the repository at this point in the history
  99. src: prevent changing FunctionTemplateInfo after publish

    Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147
    
    Fixes an issue where Node.js tries to call SetClassName on a
    FunctionTemplate twice in some cases. The above CL made it so that
    V8 CHECKs when this occurs. It is fixed by ensuring SetClassName
    is only called once.
    
    PR-URL: #46979
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    codebytere authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    bf9a52c View commit details
    Browse the repository at this point in the history
  100. test: refactor WPTRunner and enable parallel WPT execution

    PR-URL: #47635
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    panva authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    84fa9fd View commit details
    Browse the repository at this point in the history
  101. test_runner: remove no-op validation

    The code already checks if testNamePatterns is an
    array, and converts it to an array if it is not.
    
    PR-URL: #47687
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    cjihrig authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f8581e7 View commit details
    Browse the repository at this point in the history
  102. src: split BlobSerializer/BlobDeserializer

    This patch splits BlobSerializer and BlobDeserializer out of
    SnapshotSerializer and SnapshotDeserializer. The child classes
    can implement serialization methods for custom types on top
    of BlobSerializer/BlobDeserializer for conversions between
    native types and binary blobs. This allows us to reuse the
    classes for other cases (e.g. SEA blobs).
    
    PR-URL: #47458
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4431df7 View commit details
    Browse the repository at this point in the history
  103. doc: async_hooks asynchronous content example add mjs code

    PR-URL: #47401
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    btea authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c5c40a8 View commit details
    Browse the repository at this point in the history
  104. node-api: test passing NULL to napi_define_class

    PR-URL: #47567
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    gabrielschulhof authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4d02901 View commit details
    Browse the repository at this point in the history
  105. tls: accept SecureContext object in server.addContext()

    Do not call tls.createSecureContext() if the context provided
    is already an instance of tls.SecureContext.
    
    Fixes: #47408
    PR-URL: #47570
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    HinataKah0 authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    57c6998 View commit details
    Browse the repository at this point in the history
  106. tools: automate v8 patch update

    PR-URL: #47594
    Refs: nodejs/security-wg#828
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    marco-ippolito authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    63e8c95 View commit details
    Browse the repository at this point in the history
  107. dns: expose getDefaultResultOrder

    PR-URL: #46973
    Fixes: #46919
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    btea authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ce8820e View commit details
    Browse the repository at this point in the history
  108. tools: fix update-v8-patch cache

    PR-URL: #47725
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    marco-ippolito authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9d0bef6 View commit details
    Browse the repository at this point in the history
  109. tools: move update-npm to dep updaters

    PR-URL: #47619
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    marco-ippolito authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    226e5b8 View commit details
    Browse the repository at this point in the history
  110. doc: fix a typo in permissions.md

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #47730
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    daeyeon authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5709133 View commit details
    Browse the repository at this point in the history
  111. deps: update ada to 2.3.0

    PR-URL: #47737
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and targos committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d08dd80 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. stream: prevent pipeline hang with generator functions

    Fixes: #47708
    PR-URL: #47712
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    debadree25 authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    f88132f View commit details
    Browse the repository at this point in the history
  2. src: mark fatal error functions as noreturn

    OnFatalError and OOMErrorHandler will not return control flow to the
    calling function.
    
    node::FatalError is an alias of node::OnFatalError. Replace all the
    callsites with node::OnFatalError instead.
    
    PR-URL: #47695
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    legendecas authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2acb57b View commit details
    Browse the repository at this point in the history
  3. test: remove spaces from test runner test names

    PR-URL: #47733
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    tniessen authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5bb7b26 View commit details
    Browse the repository at this point in the history
  4. doc: add link to news for Node.js core

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    PR-URL: #47704
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    20b0de2 View commit details
    Browse the repository at this point in the history
  5. src: fix typo in comment in quic/sessionticket.cc

    PR-URL: #47754
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    tniessen authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1f9e7ce View commit details
    Browse the repository at this point in the history
  6. doc: move addaleax to TSC emeriti

    PR-URL: #47752
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    26bccbc View commit details
    Browse the repository at this point in the history
  7. doc: mark signing the binary is macOS and Windows only in SEA

    PR-URL: #47722
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    meixg authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b954ea9 View commit details
    Browse the repository at this point in the history
  8. test_runner: support combining coverage reports

    This commit adds support for combining code coverage reports
    in the test runner. This allows coverage to be collected for
    child processes, and by extension, the test runner CLI.
    
    PR-URL: #47686
    Fixes: #47669
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    cjihrig authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6ee5e42 View commit details
    Browse the repository at this point in the history
  9. doc,test: fix concurrency option of test()

    The documentation appears to still be wrong w.r.t. the meaning of the
    concurrency option of the test() function. The implementation appears to
    default to Infinity when the option is set to true. Is that intended or
    a good idea? I don't know. It certainly makes more sense than what the
    documentation says (which is basing the number of concurrent tasks
    within a single thread on the number of CPU cores).
    
    This changes the documentation to hopefully match the implementation and
    adds a test that rules out the (rather arbitrary) behavior described in
    the documentation.
    
    Refs: #47365
    Refs: #47642
    PR-URL: #47734
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    185d609 View commit details
    Browse the repository at this point in the history
  10. src: replace idna functions with ada::idna

    Co-authored-by: Daniel Lemire <daniel@lemire.me>
    PR-URL: #47735
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    2 people authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    dc43ce7 View commit details
    Browse the repository at this point in the history
  11. deps: V8: cherry-pick c5ab3e4f0c5a

    Original commit message:
    
        libstdc++: fix incomplete type in v8::internal::is_subtype<T, U>
    
        Using std::convertible with incomplete types is UB. However, till
        GCC 12 it was accepted and std::convertible returned false.
        This fails now for e.g. v8::internal::WasmArray. Use
        std::disjunction and std::conjunction instead which are short-
        circuiting, because std::is_base_of<T, T> is already true.
    
        Bug: chromium:957519
        Change-Id: Ia26643dbdf0fb00d5586c71ae6b18e8d0f3cf96e
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394663
        Commit-Queue: Stephan Hartmann <stha09@googlemail.com>
        Reviewed-by: Clemens Backes <clemensb@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#86904}
    
    Refs: v8/v8@c5ab3e4
    PR-URL: #47736
    Fixes: #47623
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    richardlau authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    00d461e View commit details
    Browse the repository at this point in the history
  12. doc: move BethGriggs to regular member

    PR-URL: #47776
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Trott authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ceba37a View commit details
    Browse the repository at this point in the history
  13. doc: fix typo in webstreams.md

    PR-URL: #47766
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    christiantakle authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d750364 View commit details
    Browse the repository at this point in the history
  14. assert: deprecate callTracker

    PR-URL: #47740
    Fixes: #47492
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MoLow authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    33d1bd3 View commit details
    Browse the repository at this point in the history
  15. src: avoid copying string in fs_permission

    PR-URL: #47746
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    anonrig authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e948bec View commit details
    Browse the repository at this point in the history
  16. v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor

    PR-URL: #47721
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    legendecas authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    606523d View commit details
    Browse the repository at this point in the history
  17. test_runner: fix --require with --experimental-loader

    PR-URL: #47751
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e5251e3 View commit details
    Browse the repository at this point in the history
  18. tools: update lint-md-dependencies to rollup@3.21.1

    PR-URL: #47787
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    nodejs-github-bot authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8d1588a View commit details
    Browse the repository at this point in the history
  19. url: reduce revokeObjectURL cpp calls

    PR-URL: #47728
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    anonrig authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e4b6b79 View commit details
    Browse the repository at this point in the history
  20. meta: ping nodejs/startup for startup test changes

    PR-URL: #47771
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    joyeecheung authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9279440 View commit details
    Browse the repository at this point in the history
  21. doc: remove MoLow from Triagers

    PR-URL: #47792
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    MoLow authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    98450d9 View commit details
    Browse the repository at this point in the history
  22. benchmark: add eventtarget creation bench

    PR-URL: #47774
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    RafaelGSS authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6d87355 View commit details
    Browse the repository at this point in the history
  23. build: refactor configure.py

    - Explicitly specify the encoding when opening files.
    - Use f-strings to format strings.
    - Use `isinstance()` for type checks instead of `type()`.
    - Use the `with` keyword for resource-allocating operations.
    - Avoid using multiple statements in a single line.
    - Remove unnecessary `else` clauses after `return`.
    - Iterate with the `items()` method of dictionaries when both the key
    and value are used.
    - Remove unnecessary parentheses.
    - Rename unused unpacked variables to `_`, `_1`, etc etc.
    - Rename the `list` variable to avoid conflict with the global
    `list()` function.
    
    PR-URL: #47667
    Reviewed-By: Christian Clauss <cclauss@me.com>
    VoltrexKeyva authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    089c9c5 View commit details
    Browse the repository at this point in the history
  24. deps: disable V8 concurrent sparkplug compilation

    It introduces process hangs on some platforms because Node.js doesn't
    tear down V8 correctly.
    Disable it while we work on a solution.
    
    Refs: #47297
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
    PR-URL: #47450
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6046779 View commit details
    Browse the repository at this point in the history
  25. tools: add the missing LoongArch64 definition in the v8.gyp file

    PR-URL: #47641
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    sunhaiyong1978 authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    326c3f1 View commit details
    Browse the repository at this point in the history
  26. doc: add copy node executable guide on windows

    PR-URL: #47781
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    yjl9903 authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3befe5d View commit details
    Browse the repository at this point in the history
  27. test: add and use tmpdir.hasEnoughSpace()

    In general, we assume that the tmpdir will provide sufficient space for
    most tests. Some tests, however, require hundreds of megabytes or even
    gigabytes of space, which often causes them to fail, especially on our
    macOS infrastructure. The most recent reliability report contains more
    than 20 related CI failures.
    
    This change adds a new function hasEnoughSpace() to the tmpdir module
    that uses statfsSync() to guess whether allocating a certain amount of
    space within the temporary directory will succeed.
    
    This change also updates the most frequently failing tests to use the
    new function such that the relevant parts of the tests are skipped if
    tmpdir has insufficient space.
    
    Refs: nodejs/reliability#549
    PR-URL: #47767
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    tniessen authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    97a3d39 View commit details
    Browse the repository at this point in the history
  28. doc: clarify fs permissions only affect fs module

    As far as I can tell, the permission model implementation currently
    does not restrict all file system operations but only those through
    the fs module. WASI, for example, bypasses the permission model
    entirely.
    
    PR-URL: #47782
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    tniessen authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    98603b6 View commit details
    Browse the repository at this point in the history
  29. doc: fix --allow-* CLI flag references

    PR-URL: #47804
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    tniessen authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    aa0ef3e View commit details
    Browse the repository at this point in the history
  30. tools: update doc to highlight.js@11.8.0

    PR-URL: #47786
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c620eb8 View commit details
    Browse the repository at this point in the history
  31. meta: fix dependabot commit message

    PR-URL: #47810
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Mesteery authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d5089fe View commit details
    Browse the repository at this point in the history
  32. doc: create maintaining folder for deps

    PR-URL: #47589
    Refs: nodejs/security-wg#828
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    marco-ippolito authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4c26e28 View commit details
    Browse the repository at this point in the history
  33. build: use pathlib for paths

    Use Python's `pathlib` library for paths and related operations
    instead of `os.path`.
    
    Refs: #47323 (comment) #47323 (comment)
    PR-URL: #47581
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    VoltrexKeyva authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    30af5ce View commit details
    Browse the repository at this point in the history
  34. http: remove internal error in assignSocket

    Change ServerResponse.assignSocket to not throw an internal error,
    but an error with its own code.
    
    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    PR-URL: #47723
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mcollina authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    96f93cc View commit details
    Browse the repository at this point in the history
  35. test: refactor to use getEventListeners in timers

    Use `getEventListeners` instead of `listenerCount` because #35991
    was landed.
    
    Refs: #35991
    Refs: #36006
    PR-URL: #47759
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    deokjinkim authored and targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    159cf02 View commit details
    Browse the repository at this point in the history
  36. 2023-05-03, Version 20.1.0 (Current)

    Notable changes:
    
    assert:
      * deprecate `CallTracker` (Moshe Atlow) #47740
    crypto:
      * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659
    dns:
      * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973
    doc:
      * add KhafraDev to collaborators (Matthew Aitken) #47510
    fs:
      * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439
      * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084
    http:
      * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405
    stream:
      * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413
    test_runner:
      * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628
      * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586
      * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686
    wasi:
      * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390
    
    PR-URL: #47820
    targos committed May 3, 2023
    Configuration menu
    Copy the full SHA
    68ef4a6 View commit details
    Browse the repository at this point in the history