-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v20.1.0 release proposal #47820
v20.1.0 release proposal #47820
Commits on May 2, 2023
-
PR-URL: #47488 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ba9ec91 - Browse repository at this point
Copy the full SHA ba9ec91View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc1601 - Browse repository at this point
Copy the full SHA adc1601View commit details -
src: use correct variable in node_builtins.cc
PR-URL: #47343 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cda36bf - Browse repository at this point
Copy the full SHA cda36bfView commit details -
doc: create maintaining-brotli.md
PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 537c17e - Browse repository at this point
Copy the full SHA 537c17eView commit details -
tools: move update-undici.sh to dep_updaters and create maintain md
PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2e83381 - Browse repository at this point
Copy the full SHA 2e83381View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d30f46 - Browse repository at this point
Copy the full SHA 9d30f46View commit details -
bootstrap: support namespaced builtins in snapshot scripts
PR-URL: #47467 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 202042e - Browse repository at this point
Copy the full SHA 202042eView commit details -
meta: add mailmap entry for KhafraDev
This will make `git log` entries for KhafraDev show up using the name in the README, which is required so that find-inactive-collaborators.mjs doesn't incorrectly flag him for removal. PR-URL: #47512 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 8d43689 - Browse repository at this point
Copy the full SHA 8d43689View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b411f4 - Browse repository at this point
Copy the full SHA 2b411f4View commit details -
deps: V8: cherry-pick 8e10685ff918
Original commit message: [build]: fix wrong name Change-Id: I504e836da1e36d7b9e504dbdbff8803363f08ccd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4392064 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#86919} Refs: v8/v8@8e10685 PR-URL: #47440 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2664536 - Browse repository at this point
Copy the full SHA 2664536View commit details -
wasi: make returnOnExit true by default
Refs: #46923 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47390 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 75c1d1b - Browse repository at this point
Copy the full SHA 75c1d1bView commit details -
tools: automate ngtcp2 and nghttp3 update
PR-URL: #47402 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e4d9585 - Browse repository at this point
Copy the full SHA e4d9585View commit details -
doc: fix typo in util.types.isNativeError()
This is a small fix for my recent PR that fixes a typo in the realm example. PR-URL: #47532 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4046280 - Browse repository at this point
Copy the full SHA 4046280View commit details -
PR-URL: #47507 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 64b5a5f - Browse repository at this point
Copy the full SHA 64b5a5fView commit details -
PR-URL: #47508 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ede69d2 - Browse repository at this point
Copy the full SHA ede69d2View commit details -
url: validate argument length in canParse
PR-URL: #47513 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4839fc4 - Browse repository at this point
Copy the full SHA 4839fc4View commit details -
url: validate URL constructor arg length
PR-URL: #47513 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 180d365 - Browse repository at this point
Copy the full SHA 180d365View commit details -
tools: add missing pinned dependencies
PR-URL: #47346 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 233b628 - Browse repository at this point
Copy the full SHA 233b628View commit details -
tools: automate uvwasi dependency update
Refs: nodejs/security-wg#828 PR-URL: #47509 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9e3e0b0 - Browse repository at this point
Copy the full SHA 9e3e0b0View commit details -
benchmark: add a benchmark for
defaultResolve
PR-URL: #47543 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 936d7cb - Browse repository at this point
Copy the full SHA 936d7cbView commit details -
doc: fix split infinitive in Hooks caveat
PR-URL: #47550 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for 0dc5080 - Browse repository at this point
Copy the full SHA 0dc5080View commit details -
benchmark: differentiate whatwg and legacy url
PR-URL: #47377 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 40324a1 - Browse repository at this point
Copy the full SHA 40324a1View commit details -
test: mark test-cluster-primary-error flaky on asan
PR-URL: #47422 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 826f404 - Browse repository at this point
Copy the full SHA 826f404View commit details -
readline: fix issue with newline-less last line
The logic for reading lines was slightly flawed, in that it assumed there would be a final new line. It handled the case where there are no new lines, but this then broke if there were some new lines. The fix in logic is basically removing the special case where there are no new lines by changing it to always read the final line with no new lines. This works because if a file contains no new lines, the final line is the first line, and all is well. There is some subtlety in this functioning, however. If the last line contains no new lines, then `lastIndex` will be the start of the last line, and `kInsertString` will be called from that point. If it does contain a new line, `lastIndex` will be equal to `s.length`, so the slice will be the empty string. Fixes: #47305 PR-URL: #47317 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for af227b1 - Browse repository at this point
Copy the full SHA af227b1View commit details -
lib: use webidl DOMString converter in EventTarget
PR-URL: #47514 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e8bc03b - Browse repository at this point
Copy the full SHA e8bc03bView commit details -
url: handle URL.canParse without base parameter
PR-URL: #47547 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9aae767 - Browse repository at this point
Copy the full SHA 9aae767View commit details -
doc: update darwin-x64 toolchain used for Node.js 20 releases
Configuration menu - View commit details
-
Copy full SHA for f9abd59 - Browse repository at this point
Copy the full SHA f9abd59View commit details -
doc: add missing setEncoding call in ESM example
Adding `setEncoding()` ensures that the example handles characters split across chunk boundaries well. PR-URL: #47558 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ca416a - Browse repository at this point
Copy the full SHA 7ca416aView commit details -
build: replace Python linter flake8 with ruff
PR-URL: #47519 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 78c0824 - Browse repository at this point
Copy the full SHA 78c0824View commit details -
doc: add link for news from uvwasi team
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47531 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b0b16ee - Browse repository at this point
Copy the full SHA b0b16eeView commit details -
esm: avoid try/catch when validating urls
PR-URL: #47541 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for 889add6 - Browse repository at this point
Copy the full SHA 889add6View commit details -
esm: avoid accessing lazy getters for urls
PR-URL: #47542 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 269482f - Browse repository at this point
Copy the full SHA 269482fView commit details -
tools: add performance label to benchmark changes
PR-URL: #47545 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ff73c05 - Browse repository at this point
Copy the full SHA ff73c05View commit details -
tools: add url and whatwg-url labels automatically
PR-URL: #47545 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6af7f1e - Browse repository at this point
Copy the full SHA 6af7f1eView commit details -
build: bump ossf/scorecard-action from 2.1.2 to 2.1.3
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@e38b190...80e868c) PR-URL: #47367 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 35e8b3b - Browse repository at this point
Copy the full SHA 35e8b3bView commit details -
src: fix CSPRNG when length exceeds INT_MAX
CSPRNG implicitly casts the size_t length argument to a signed int when calling RAND_bytes(), which leaves it up to the caller to ensure that the length argument actually fits into such a signed int. However, not all call sites explicitly ensure that, which could lead to subtle bugs. In OpenSSL 3, use RAND_bytes_ex() instead, which does not require casting the length to a signed int. In OpenSSL 1.1.1, RAND_bytes_ex() is not supported, thus we have to process blocks of size INT_MAX one by one. PR-URL: #47515 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 57e7ed7 - Browse repository at this point
Copy the full SHA 57e7ed7View commit details -
src: replace static const string_view by static constexpr
PR-URL: #47524 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for daf0c78 - Browse repository at this point
Copy the full SHA daf0c78View commit details -
test_runner: fix spec skip detection
PR-URL: #47537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4203057 - Browse repository at this point
Copy the full SHA 4203057View commit details -
src: fix typo in process.env accessor error message
PR-URL: #47014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ba255ed - Browse repository at this point
Copy the full SHA ba255edView commit details -
src: use v8::Boolean(b) over b ? True() : False()
Simplify existing code by using v8::Boolean::New() instead of equivalent expressions that contain ternary operators. PR-URL: #47554 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf48db0 - Browse repository at this point
Copy the full SHA cf48db0View commit details -
typings: fix syntax error in tsconfig
Trailing commas are invalid in JSON files. PR-URL: #47584 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 8712eaf - Browse repository at this point
Copy the full SHA 8712eafView commit details -
Refs: v8/v8@11.3.244.4...11.3.244.8 PR-URL: #47536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 13105c1 - Browse repository at this point
Copy the full SHA 13105c1View commit details -
deps: update ICU to 73.1 release
- Details: https://icu.unicode.org/download/73 PR-URL: #47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7f7735c - Browse repository at this point
Copy the full SHA 7f7735cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 420feb4 - Browse repository at this point
Copy the full SHA 420feb4View commit details -
doc: fix typo in webcrypto metadata
PR-URL: #47595 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a0bbe7 - Browse repository at this point
Copy the full SHA 2a0bbe7View commit details -
doc: fix release-post script location
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47517 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for d3fadd8 - Browse repository at this point
Copy the full SHA d3fadd8View commit details -
quic: add more QUIC implementation
* add TLSContext * quic: add stat collection utilities * add Packet * add NgTcp2CallbackScope/NgHttp3CallbackScope PR-URL: #47494 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for e8ea834 - Browse repository at this point
Copy the full SHA e8ea834View commit details -
node-api: remove unused mark_arraybuffer_as_untransferable
napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore. PR-URL: #47557 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 12f0fa3 - Browse repository at this point
Copy the full SHA 12f0fa3View commit details -
test_runner: avoid reporting parents of failing tests in summary
PR-URL: #47579 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ec24aba - Browse repository at this point
Copy the full SHA ec24abaView commit details -
doc: fix history ordering of
WASI
constructorPR-URL: #47611 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c36634e - Browse repository at this point
Copy the full SHA c36634eView commit details -
doc: remove markdown link from heading
This is the only instance of such a link and it is rendered incorrectly in the TOC. PR-URL: #47585 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b58920c - Browse repository at this point
Copy the full SHA b58920cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdd02a4 - Browse repository at this point
Copy the full SHA bdd02a4View commit details -
esm: propagate
process.exit
from the loader thread to the main threadPR-URL: #47548 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 55f70f6 - Browse repository at this point
Copy the full SHA 55f70f6View commit details -
PR-URL: #47417 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 1509312 - Browse repository at this point
Copy the full SHA 1509312View commit details -
tools: add option to run workflow with specific tool id
PR-URL: #47591 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7c552e6 - Browse repository at this point
Copy the full SHA 7c552e6View commit details -
tools: add update script for googletest
GoogleTest follows the Abseil Live at Head philosophy, and rarely creates tags or GitHub releases, so instead, follow Google's recommendation and update to the upstream HEAD every once in a while. The tricky bit is properly updating googletest.gyp, and this script might fail doing so in the future. Refs: nodejs/security-wg#828 PR-URL: #47482 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for e3f4ff4 - Browse repository at this point
Copy the full SHA e3f4ff4View commit details -
doc: improve fs permissions description
Fix a small grammatical mistake and improve the surrounding wording. PR-URL: #47596 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d11ff4b - Browse repository at this point
Copy the full SHA d11ff4bView commit details -
PR-URL: #47598 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3154543 - Browse repository at this point
Copy the full SHA 3154543View commit details -
esm: initialize
import.meta
on evalPR-URL: #47551 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for c150976 - Browse repository at this point
Copy the full SHA c150976View commit details -
tools: add execution permission to uvwasi script
PR-URL: #47600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for fbe7d73 - Browse repository at this point
Copy the full SHA fbe7d73View commit details -
esm: remove support for deprecated hooks
Those have been deprecated for a while, it's time. PR-URL: #47580 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fbb6b72 - Browse repository at this point
Copy the full SHA fbb6b72View commit details -
node-api: test passing NULL to number APIs
PR-URL: #47549 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 568256d - Browse repository at this point
Copy the full SHA 568256dView commit details -
src: make AliasedBuffers in the binding data weak
The binding data holds references to the AliasedBuffers directly from their wrappers which already ensures that the AliasedBuffers won't be accessed when the wrappers are GC'ed. So we can just make the global references to the AliasedBuffers weak. This way we can simply deserialize the typed arrays when deserialize the binding data and avoid the extra Object::Set() calls. It also eliminates the caveat in the JS land where aliased buffers must be dynamically read from the binding. PR-URL: #47354 Refs: #47353 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cfafe43 - Browse repository at this point
Copy the full SHA cfafe43View commit details -
fs: add support for mode flag to specify the copy behavior
`fs.copyFile()` supports copy-on-write operation if the underlying platform supports it by passing a mode flag. This behavior was added in a16d88d. This patch adds `mode` flag to `fs.cp()`, `fs.cpSync()`, and `fsPromises.cp()` to allow to change their behaviors to copy files. This test case is based on the test case that was introduced when we add `fs.constants.COPYFILE_FICLONE`. a16d88d. This test strategy is: - If the platform supports copy-on-write operation, check whether the destination is expected - Otherwise, the operation will fail and check whether the failure error information is expected. Fixes: #47080 PR-URL: #47084 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a54e898 - Browse repository at this point
Copy the full SHA a54e898View commit details -
Revert "tools: ensure failed daily wpt run still generates a report"
Configuration menu - View commit details
-
Copy full SHA for c17f268 - Browse repository at this point
Copy the full SHA c17f268View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d3768e - Browse repository at this point
Copy the full SHA 9d3768eView commit details -
doc: change offset of example in
Buffer.copyBytesFrom
Actual output is different from expected output if offset is 0. Plus, removed unused importing `Buffer`. PR-URL: #47606 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 183f0c3 - Browse repository at this point
Copy the full SHA 183f0c3View commit details -
- Update paths to the new ones. - Remove paths that no longer exist. - Capitalize comments and quote labels mentioned within. - Fix syntax error in regex. - Add missing JavaScript subsystems. PR-URL: #47593 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 87cae0c - Browse repository at this point
Copy the full SHA 87cae0cView commit details -
inspector: add tips for Session
PR-URL: #47195 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94a5abb - Browse repository at this point
Copy the full SHA 94a5abbView commit details -
src: add v8 fast api for url canParse
PR-URL: #47552 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 872e670 - Browse repository at this point
Copy the full SHA 872e670View commit details -
fs: add recursive option to readdir and opendir
Adds a naive, linear recursive algorithm for the following methods: readdir, readdirSync, opendir, opendirSync, and the promise based equivalents. Fixes: #34992 PR-URL: #41439 Refs: nodejs/tooling#130 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 439ea47 - Browse repository at this point
Copy the full SHA 439ea47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1391d3b - Browse repository at this point
Copy the full SHA 1391d3bView commit details -
tools: fix updating root certificates
When searching for the latest certdata.txt, check that the file exists on the remote server. PR-URL: #47607 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b8927dd - Browse repository at this point
Copy the full SHA b8927ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9101630 - Browse repository at this point
Copy the full SHA 9101630View commit details -
loader: use default loader as cascaded loader in the in loader worker
Use the default loader as the cascaded loader in the loader worker. Otherwise we spawn loader workers in the loader workers indefinitely. PR-URL: #47620 Fixes: #47566 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 91e4a7c - Browse repository at this point
Copy the full SHA 91e4a7cView commit details -
tools: keep PR titles/description up-to-date
Set the `update-pull-request-title-and-body` option when potentially updating an existing PR with a dynamic title and/or description. PR-URL: #47621 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0887fa0 - Browse repository at this point
Copy the full SHA 0887fa0View commit details -
lib: disallow file-backed blob cloning
Disallow cloning of file-backed Blobs. If necessary, we can enable this later but for now we disable it. The reason is because the underlying FdEntry ends up bound to the Environment/Realm under which is was created and transfering across worker threads ends up failing. Fixes: #47334 PR-URL: #47574 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b8bdaf8 - Browse repository at this point
Copy the full SHA b8bdaf8View commit details -
build: add devcontainer configuration
PR-URL: #40825 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5b851c8 - Browse repository at this point
Copy the full SHA 5b851c8View commit details -
doc,fs: update description of fs.stat() method
PR-URL: #47654 Fixes: #47633 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
Configuration menu - View commit details
-
Copy full SHA for 09ff9ea - Browse repository at this point
Copy the full SHA 09ff9eaView commit details -
PR-URL: #47677 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 78a3503 - Browse repository at this point
Copy the full SHA 78a3503View commit details -
tools: update lint-md-dependencies to @rollup/plugin-commonjs@24.1.0
PR-URL: #47577 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ccf9c37 - Browse repository at this point
Copy the full SHA ccf9c37View commit details -
test_runner: move coverage collection to root.postRun()
This commit moves code coverage collection from the test harness exit handler to the postRun() function of the root test. This is necessary preparatory work for supporting code coverage with --test. The reason is that --test is implemented on top of run(), and that function calls the root test's postRun() function, which outputs the test summary. This happens before the harness exit handler. PR-URL: #47651 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1f120a3 - Browse repository at this point
Copy the full SHA 1f120a3View commit details -
test_runner: support coverage of unnamed functions
This commit updates the code coverage logic to skip the first function in a file (which does not correspond to an actual function) instead of skipping all functions without a name. PR-URL: #47652 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b6fb791 - Browse repository at this point
Copy the full SHA b6fb791View commit details -
doc: fix capitalization of ASan
PR-URL: #47676 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f30ef24 - Browse repository at this point
Copy the full SHA f30ef24View commit details -
crypto: update root certificates to NSS 3.89
This is the certdata.txt[0] from NSS 3.89, released on 2023-03-09. This is the version of NSS that shipped in Firefox 112 on 2023-04-11. Certificates removed: - Network Solutions Certificate Authority - EC-ACC - Staat der Nederlanden EV Root CA [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_89_RTM/lib/ckfw/builtins/certdata.txt PR-URL: #47659 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2d97c89 - Browse repository at this point
Copy the full SHA 2d97c89View commit details -
test_runner: add testNamePatterns to run api
Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. PR-URL: #47648 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5327483 - Browse repository at this point
Copy the full SHA 5327483View commit details -
PR-URL: #47685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4cef988 - Browse repository at this point
Copy the full SHA 4cef988View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a9b71a - Browse repository at this point
Copy the full SHA 5a9b71aView commit details -
lib: improve esm resolve performance
PR-URL: #46652 Refs: nodejs/performance#39 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 21ff331 - Browse repository at this point
Copy the full SHA 21ff331View commit details -
http: add highWaterMark opt in http.createServer
Add highWaterMark option when creating a new HTTP server. This option will override the default (readable|writable) highWaterMark values on sockets created. Fixes: #46606 PR-URL: #47405 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4fa7739 - Browse repository at this point
Copy the full SHA 4fa7739View commit details -
doc: fix a typo in
fs.openAsBlob
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #47693 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c0c23fb - Browse repository at this point
Copy the full SHA c0c23fbView commit details -
esm: rename
URLCanParse
to be consistentPR-URL: #47668 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a793cf4 - Browse repository at this point
Copy the full SHA a793cf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1403a8 - Browse repository at this point
Copy the full SHA a1403a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2994e5 - Browse repository at this point
Copy the full SHA d2994e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d7cac0 - Browse repository at this point
Copy the full SHA 2d7cac0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40b3879 - Browse repository at this point
Copy the full SHA 40b3879View commit details -
PR-URL: #47678 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f3ee312 - Browse repository at this point
Copy the full SHA f3ee312View commit details -
PR-URL: #47679 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9962459 - Browse repository at this point
Copy the full SHA 9962459View commit details -
src: prevent changing FunctionTemplateInfo after publish
Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147 Fixes an issue where Node.js tries to call SetClassName on a FunctionTemplate twice in some cases. The above CL made it so that V8 CHECKs when this occurs. It is fixed by ensuring SetClassName is only called once. PR-URL: #46979 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bf9a52c - Browse repository at this point
Copy the full SHA bf9a52cView commit details -
test: refactor WPTRunner and enable parallel WPT execution
PR-URL: #47635 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 84fa9fd - Browse repository at this point
Copy the full SHA 84fa9fdView commit details -
test_runner: remove no-op validation
The code already checks if testNamePatterns is an array, and converts it to an array if it is not. PR-URL: #47687 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f8581e7 - Browse repository at this point
Copy the full SHA f8581e7View commit details -
src: split BlobSerializer/BlobDeserializer
This patch splits BlobSerializer and BlobDeserializer out of SnapshotSerializer and SnapshotDeserializer. The child classes can implement serialization methods for custom types on top of BlobSerializer/BlobDeserializer for conversions between native types and binary blobs. This allows us to reuse the classes for other cases (e.g. SEA blobs). PR-URL: #47458 Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4431df7 - Browse repository at this point
Copy the full SHA 4431df7View commit details -
doc: async_hooks asynchronous content example add mjs code
PR-URL: #47401 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c5c40a8 - Browse repository at this point
Copy the full SHA c5c40a8View commit details -
node-api: test passing NULL to napi_define_class
PR-URL: #47567 Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 4d02901 - Browse repository at this point
Copy the full SHA 4d02901View commit details -
tls: accept SecureContext object in server.addContext()
Do not call tls.createSecureContext() if the context provided is already an instance of tls.SecureContext. Fixes: #47408 PR-URL: #47570 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 57c6998 - Browse repository at this point
Copy the full SHA 57c6998View commit details -
tools: automate v8 patch update
PR-URL: #47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 63e8c95 - Browse repository at this point
Copy the full SHA 63e8c95View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce8820e - Browse repository at this point
Copy the full SHA ce8820eView commit details -
tools: fix update-v8-patch cache
PR-URL: #47725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d0bef6 - Browse repository at this point
Copy the full SHA 9d0bef6View commit details -
tools: move update-npm to dep updaters
PR-URL: #47619 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 226e5b8 - Browse repository at this point
Copy the full SHA 226e5b8View commit details -
doc: fix a typo in
permissions.md
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #47730 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5709133 - Browse repository at this point
Copy the full SHA 5709133View commit details -
PR-URL: #47737 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d08dd80 - Browse repository at this point
Copy the full SHA d08dd80View commit details
Commits on May 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f88132f - Browse repository at this point
Copy the full SHA f88132fView commit details -
src: mark fatal error functions as noreturn
OnFatalError and OOMErrorHandler will not return control flow to the calling function. node::FatalError is an alias of node::OnFatalError. Replace all the callsites with node::OnFatalError instead. PR-URL: #47695 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2acb57b - Browse repository at this point
Copy the full SHA 2acb57bView commit details -
test: remove spaces from test runner test names
PR-URL: #47733 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5bb7b26 - Browse repository at this point
Copy the full SHA 5bb7b26View commit details -
doc: add link to news for Node.js core
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47704 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 20b0de2 - Browse repository at this point
Copy the full SHA 20b0de2View commit details -
src: fix typo in comment in quic/sessionticket.cc
PR-URL: #47754 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1f9e7ce - Browse repository at this point
Copy the full SHA 1f9e7ceView commit details -
doc: move addaleax to TSC emeriti
PR-URL: #47752 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 26bccbc - Browse repository at this point
Copy the full SHA 26bccbcView commit details -
doc: mark signing the binary is macOS and Windows only in SEA
PR-URL: #47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Configuration menu - View commit details
-
Copy full SHA for b954ea9 - Browse repository at this point
Copy the full SHA b954ea9View commit details -
test_runner: support combining coverage reports
This commit adds support for combining code coverage reports in the test runner. This allows coverage to be collected for child processes, and by extension, the test runner CLI. PR-URL: #47686 Fixes: #47669 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6ee5e42 - Browse repository at this point
Copy the full SHA 6ee5e42View commit details -
doc,test: fix concurrency option of test()
The documentation appears to still be wrong w.r.t. the meaning of the concurrency option of the test() function. The implementation appears to default to Infinity when the option is set to true. Is that intended or a good idea? I don't know. It certainly makes more sense than what the documentation says (which is basing the number of concurrent tasks within a single thread on the number of CPU cores). This changes the documentation to hopefully match the implementation and adds a test that rules out the (rather arbitrary) behavior described in the documentation. Refs: #47365 Refs: #47642 PR-URL: #47734 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 185d609 - Browse repository at this point
Copy the full SHA 185d609View commit details -
src: replace idna functions with ada::idna
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: #47735 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dc43ce7 - Browse repository at this point
Copy the full SHA dc43ce7View commit details -
deps: V8: cherry-pick c5ab3e4f0c5a
Original commit message: libstdc++: fix incomplete type in v8::internal::is_subtype<T, U> Using std::convertible with incomplete types is UB. However, till GCC 12 it was accepted and std::convertible returned false. This fails now for e.g. v8::internal::WasmArray. Use std::disjunction and std::conjunction instead which are short- circuiting, because std::is_base_of<T, T> is already true. Bug: chromium:957519 Change-Id: Ia26643dbdf0fb00d5586c71ae6b18e8d0f3cf96e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394663 Commit-Queue: Stephan Hartmann <stha09@googlemail.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#86904} Refs: v8/v8@c5ab3e4 PR-URL: #47736 Fixes: #47623 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 00d461e - Browse repository at this point
Copy the full SHA 00d461eView commit details -
doc: move BethGriggs to regular member
PR-URL: #47776 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ceba37a - Browse repository at this point
Copy the full SHA ceba37aView commit details -
doc: fix typo in webstreams.md
PR-URL: #47766 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d750364 - Browse repository at this point
Copy the full SHA d750364View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33d1bd3 - Browse repository at this point
Copy the full SHA 33d1bd3View commit details -
src: avoid copying string in fs_permission
PR-URL: #47746 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e948bec - Browse repository at this point
Copy the full SHA e948becView commit details -
v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor
PR-URL: #47721 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 606523d - Browse repository at this point
Copy the full SHA 606523dView commit details -
test_runner: fix --require with --experimental-loader
PR-URL: #47751 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e5251e3 - Browse repository at this point
Copy the full SHA e5251e3View commit details -
tools: update lint-md-dependencies to rollup@3.21.1
PR-URL: #47787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 8d1588a - Browse repository at this point
Copy the full SHA 8d1588aView commit details -
url: reduce revokeObjectURL cpp calls
PR-URL: #47728 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e4b6b79 - Browse repository at this point
Copy the full SHA e4b6b79View commit details -
meta: ping nodejs/startup for startup test changes
PR-URL: #47771 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9279440 - Browse repository at this point
Copy the full SHA 9279440View commit details -
doc: remove MoLow from Triagers
PR-URL: #47792 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 98450d9 - Browse repository at this point
Copy the full SHA 98450d9View commit details -
benchmark: add eventtarget creation bench
PR-URL: #47774 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 6d87355 - Browse repository at this point
Copy the full SHA 6d87355View commit details -
- Explicitly specify the encoding when opening files. - Use f-strings to format strings. - Use `isinstance()` for type checks instead of `type()`. - Use the `with` keyword for resource-allocating operations. - Avoid using multiple statements in a single line. - Remove unnecessary `else` clauses after `return`. - Iterate with the `items()` method of dictionaries when both the key and value are used. - Remove unnecessary parentheses. - Rename unused unpacked variables to `_`, `_1`, etc etc. - Rename the `list` variable to avoid conflict with the global `list()` function. PR-URL: #47667 Reviewed-By: Christian Clauss <cclauss@me.com>
Configuration menu - View commit details
-
Copy full SHA for 089c9c5 - Browse repository at this point
Copy the full SHA 089c9c5View commit details -
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: #47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: #47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6046779 - Browse repository at this point
Copy the full SHA 6046779View commit details -
tools: add the missing LoongArch64 definition in the v8.gyp file
PR-URL: #47641 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 326c3f1 - Browse repository at this point
Copy the full SHA 326c3f1View commit details -
doc: add copy node executable guide on windows
PR-URL: #47781 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3befe5d - Browse repository at this point
Copy the full SHA 3befe5dView commit details -
test: add and use tmpdir.hasEnoughSpace()
In general, we assume that the tmpdir will provide sufficient space for most tests. Some tests, however, require hundreds of megabytes or even gigabytes of space, which often causes them to fail, especially on our macOS infrastructure. The most recent reliability report contains more than 20 related CI failures. This change adds a new function hasEnoughSpace() to the tmpdir module that uses statfsSync() to guess whether allocating a certain amount of space within the temporary directory will succeed. This change also updates the most frequently failing tests to use the new function such that the relevant parts of the tests are skipped if tmpdir has insufficient space. Refs: nodejs/reliability#549 PR-URL: #47767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 97a3d39 - Browse repository at this point
Copy the full SHA 97a3d39View commit details -
doc: clarify fs permissions only affect fs module
As far as I can tell, the permission model implementation currently does not restrict all file system operations but only those through the fs module. WASI, for example, bypasses the permission model entirely. PR-URL: #47782 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 98603b6 - Browse repository at this point
Copy the full SHA 98603b6View commit details -
doc: fix --allow-* CLI flag references
PR-URL: #47804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for aa0ef3e - Browse repository at this point
Copy the full SHA aa0ef3eView commit details -
tools: update doc to highlight.js@11.8.0
PR-URL: #47786 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for c620eb8 - Browse repository at this point
Copy the full SHA c620eb8View commit details -
meta: fix dependabot commit message
PR-URL: #47810 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d5089fe - Browse repository at this point
Copy the full SHA d5089feView commit details -
doc: create maintaining folder for deps
PR-URL: #47589 Refs: nodejs/security-wg#828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 4c26e28 - Browse repository at this point
Copy the full SHA 4c26e28View commit details -
Use Python's `pathlib` library for paths and related operations instead of `os.path`. Refs: #47323 (comment) #47323 (comment) PR-URL: #47581 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Configuration menu - View commit details
-
Copy full SHA for 30af5ce - Browse repository at this point
Copy the full SHA 30af5ceView commit details -
http: remove internal error in assignSocket
Change ServerResponse.assignSocket to not throw an internal error, but an error with its own code. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #47723 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 96f93cc - Browse repository at this point
Copy the full SHA 96f93ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 159cf02 - Browse repository at this point
Copy the full SHA 159cf02View commit details -
2023-05-03, Version 20.1.0 (Current)
Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820
Configuration menu - View commit details
-
Copy full SHA for 68ef4a6 - Browse repository at this point
Copy the full SHA 68ef4a6View commit details