refactor: migrate table chart to new API #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ktmud
force-pushed
the
table-chart-new-api
branch
from
46cb0cb
to
9b05065
Compare
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
- Coverage 66.92% 63.39% -3.54%
==========================================
Files 1022 488 -534
Lines 50051 30175 -19876
Branches 5048 0 -5048
==========================================
- Hits 33498 19129 -14369
+ Misses 16428 11046 -5382
+ Partials 125 0 -125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
table-chart-new-api
branch
from
588ceee
to
026c639
Compare
* Converted oversized .png back to .jpg to pass the filesize check. * added downsized media for really real this time.
* fix: session error fixed related to thumbnails. * compute_and_cache moved to session scope * lint fix done
…ache#12789) * fix(explore): pass partitionColumn when creating new adhoc filter * add default value to state * remove duplicated code * update translations
…ache#12664) * fix: keep old names from screenshot images to pypi releases * change db logos to github raw content * add gallery link
…ache#12103) * Async queries: remove force cache param on data retrieval * Assert equal query_object cache keys * Decouple etag_cache from permission checks * Fix query_context test * Use marshmallow EnumField for validation
… indicator (apache#12742) * fix: Prevent dashboard using filter_values to add incompatible indicator * fix review comments * fix review comments * add extra fix per comments
* feat: request ids on API related endpoints * rename ids to include_ids
…he#12747) * Make metric title respond to changes immediately * Bug fix * Change type to Metric * Bug fix
* fix: Preserve Column Order in Bar chart * Update tests/viz_tests.py to use f-strings style Co-authored-by: Duy Nguyen <duy.nguyenhoang@global-fashion-group.com>
* fix(reports): handle exceptions properly in scope * list and test commit removal * revert removing commits from tests * lint
* add rc4 changelog entries (cherry picked from commit 5719fef) * only show grace period for alerts + fix dropdown styling * fix lint Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
apache#12793) * fix(explore): time picker can not be switched between now and specifc * fix linting * fix type * fix UT
Fix time column formatting test
ktmud
force-pushed
the
table-chart-new-api
branch
from
ef12444
to
5cfab09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR for branch protection