Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cose dev #1

Closed
wants to merge 42 commits into from
Closed

Cose dev #1

wants to merge 42 commits into from

Commits on Aug 8, 2022

  1. feat: add cose support by refining signer module (notaryproject#25) 

    Signed-off-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    2994a36 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. refactor: refine the envelope and signer to enhance extensiblity (not… 

    …aryproject#27)

Signed-off-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a45a51e View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. refactor: rename custom errors (notaryproject#29) 

    Signed-off-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    2e99fe0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cose

    @shizhMSFT
    shizhMSFT committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    0553376 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. refactor: use internal envelope to verify (notaryproject#31) 

    Refactor Verify so that it just returns the payload and signerInfo from the internal envelope.

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b64ffd6 View commit details
    Browse the repository at this point in the history

  2. implement jws (notaryproject#30) 

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao and JeyJeyGao committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bb1fc31 View commit details
    Browse the repository at this point in the history

  3. feat: add missing VerifyAuthenticity (notaryproject#33) 

    Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    2786c0b View commit details
    Browse the repository at this point in the history

  4. feat: implemented COSE Envelope (notaryproject#28) 

    * feat: implemented COSE envelope sign

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* implemented cose envelope

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* resolve conflicts

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added extendedAttributes related logic

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to most current cose branch

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updates

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updates

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ab66bb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. refactor: add common logic to base envelope (notaryproject#35) 

    * refactor: add common logic to base envelope

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* feat: add payload and signerInfo verification in Verify

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    c515e7a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. updated COSE envelope implementation per code review (notaryproject#36) 

    * updated COSE envelope implementation per code reivew

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* renamed to envelope under cose package

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* more clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors according to errors.go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c23a945 View commit details
    Browse the repository at this point in the history

  2. feat: validate key and cert while creating local signer (notaryprojec… 

    …t#40)

* feat: add error

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* feat: validate key and cert while creating local signer

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* refactor: refactor isKeyPair

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    046e0ee View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. feat: add jwt sign (notaryproject#34) 

    1. JWT sign replace custom sign
2. add SigningScheme, crit

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao and JeyJeyGao committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    be20e83 View commit details
    Browse the repository at this point in the history

  2. COSE update unprotected header (notaryproject#41) 

    * updated COSE envelope implementation per code reivew

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* renamed to envelope under cose package

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* more clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors according to errors.go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update cose unprotected header

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    dee4d27 View commit details
    Browse the repository at this point in the history

  3. updated COSE expiry header check (notaryproject#42) 

    * updated COSE envelope implementation per code reivew

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* renamed to envelope under cose package

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* more clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors according to errors.go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update cose unprotected header

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE expiry header check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE expiry header check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    52493c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. fix: update envelope.Payload() logic (notaryproject#44) 

    Payload() returns the raw payload context instead of base64 encoded data

Signed-off-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>

Signed-off-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
    @JeyJeyGao
    JeyJeyGao committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    e5da201 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. doc: add signature documents (notaryproject#39) 

    * doc: add signature documents

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* doc: refactor comments

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    8aef2e4 View commit details
    Browse the repository at this point in the history

  2. test: add signature unit tests (notaryproject#43) 

    * test: add signature unit tests

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* test: add tests for base envelope

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* test: add more valid cases

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    a69de85 View commit details
    Browse the repository at this point in the history

  3. Updated COSE envelope unit tests (notaryproject#45) 

    * updated COSE envelope implementation per code reivew

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* renamed to envelope under cose package

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* more clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors according to errors.go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* clean up

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update cose unprotected header

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE expiry header check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE expiry header check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    8b03c75 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. added extended attribute getter for notation-go (notaryproject#46) 

    * added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9757c1e View commit details
    Browse the repository at this point in the history

  2. updated COSE envelope unit tests (notaryproject#47) 

    * added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    70a31c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. refactor: refactor signer and envelope to make Sign() return certs as… 

    … well (notaryproject#48)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    563993b View commit details
    Browse the repository at this point in the history

  2. test: fix broken unit tests (notaryproject#49) 

    Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    c3aae6e View commit details
    Browse the repository at this point in the history

  3. fix: fix the certs validation in envelope.Sign() (notaryproject#51) 

    Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li and binbin-li committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    a2fb618 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. updated COSE envelope for the certification chain changes (notaryproj… 

    …ect#50)

* added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    9d165b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. updated to latest go-cose (notaryproject#54) 

    * added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    b97da9b View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. refector & test: update to support new signature.Signer interface (no… 

    …taryproject#52)

* add jws test

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* update PR

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao and JeyJeyGao committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    1421844 View commit details
    Browse the repository at this point in the history

  2. Added COSE conformance tests (notaryproject#55) 

    * added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated comments

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    157fd17 View commit details
    Browse the repository at this point in the history

  3. add getSigningMethod (notaryproject#56) 

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao and JeyJeyGao committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    89bf762 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. add conformance test (notaryproject#57) 

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao and JeyJeyGao committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    80a50e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. updated errors related code (notaryproject#60) 

    * added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated comments

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added verification plugin critical headers check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors related code

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    d442f4e View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. quick fix (notaryproject#61) 

    * added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated comments

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added verification plugin critical headers check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors related code

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* quick fix

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8681e4f View commit details
    Browse the repository at this point in the history

  2. fix: update jwt.Claims (notaryproject#62) 

    * fix: update jwt.Claims

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* update PR

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao and JeyJeyGao committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    1a9373f View commit details
    Browse the repository at this point in the history

  3. renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundEr… 

    …ror (notaryproject#63)

* added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated comments

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added verification plugin critical headers check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors related code

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* quick fix

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundError

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    60059d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. quick update regarding verification plugin (notaryproject#65) 

    * added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated comments

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added verification plugin critical headers check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors related code

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* quick fix

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundError

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* quick update regarding verification plugin

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
    @patrickzheng200
    patrickzheng200 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    7bf2b3e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Updated cose branch (notaryproject#69) 

    * Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (notaryproject#14)

Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.4.1...v4.4.2)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* added extended attribute getter for notation-go

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updating certificate chain

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for the certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated COSE envelope for certificate chain changes

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated to latest go-cose

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added COSE conformance tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated comments

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added verification plugin critical headers check

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated errors related code

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* quick fix

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* renamed TestSignatureNotFoundError to TestSignatureEnvelopeNotFoundError

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* quick update regarding verification plugin

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* refactor: refactor envelope and signer to support cose (notaryproject#53)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* resolve conflicts

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* fixed broken unit tests

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* added maps for Notation CLI cert

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin050215@gmail.com>
    @patrickzheng200 @dependabot @binbin-li
    3 people committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    25e1806 View commit details
    Browse the repository at this point in the history

  2. fix: fix unit test error code (notaryproject#70) 

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao and JeyJeyGao committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8cdaf86 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. refactor: sync changes from stage/cose branch (notaryproject#74) 

    Signed-off-by: Binbin Li <libinbin@microsoft.com>
    @binbin-li
    binbin-li committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    afc4874 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. update cose branch (notaryproject#80) 

    * Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (notaryproject#14)

Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.4.1...v4.4.2)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* refactor: refactor envelope and signer to support cose (notaryproject#53)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* Revert "refactor: refactor envelope and signer to support cose (notaryproject#53)" (notaryproject#67)

This reverts commit cbea2cf.

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>

* update to go 1.18 (notaryproject#66)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* refactor: rename signer to signature submodule (notaryproject#71)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* refactor: refactor envelope and signer to support cose (notaryproject#73)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* feat: added COSE envelope implementation

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* resolve conflicts

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated conformance test

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* refactor: JWS for signature package (notaryproject#76)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* refactor: rename signer to signature submodule (notaryproject#71)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* refactor: refactor envelope and signer to support cose (notaryproject#73)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* refactor: JWS for signature package (notaryproject#76)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* Allows signing with self-signed certificate (notaryproject#77)

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>

* updated conformance_test

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* refactor: refactor comments (notaryproject#78)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* removed CLI related maps, they should be in notation CLI

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* resolved conflicts

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin050215@gmail.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
    @Two-Hearts @dependabot
    @binbin-li @shizhMSFT @JeyJeyGao @priteshbandi
    8 people committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    70115d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. updated cose branch after code review (notaryproject#81) 

    Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin050215@gmail.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
    @Two-Hearts @dependabot
    @binbin-li @shizhMSFT @JeyJeyGao @priteshbandi
    8 people committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    bd1d5a5 View commit details
    Browse the repository at this point in the history

  2. minor typo fix (notaryproject#82) 

    Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin050215@gmail.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
    @Two-Hearts @dependabot
    @binbin-li @shizhMSFT @JeyJeyGao @priteshbandi
    8 people committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    e7aa032 View commit details
    Browse the repository at this point in the history

  3. Added GetRSASelfSignedCertTupleWithPK (notaryproject#83) 

    Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin050215@gmail.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
    @Two-Hearts @dependabot
    @binbin-li @shizhMSFT @JeyJeyGao @priteshbandi
    8 people committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    c65f5c6 View commit details
    Browse the repository at this point in the history

  4. fix: update comments 

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
    @JeyJeyGao
    JeyJeyGao committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    94cce6a View commit details
    Browse the repository at this point in the history