Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit for copying files from azure-sdk-for-node #1

Merged
5 commits merged into from
Aug 27, 2018
Merged

Initial commit for copying files from azure-sdk-for-node #1

5 commits merged into from
Aug 27, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2018

I know that some of the documentation files still reference older azure-sdk-for-node things. I just copied them over for now and figured we'd update them as we go along.

@ghost ghost self-assigned this Aug 27, 2018
@ghost ghost requested review from amarzavery, RikkiGibson and kpajdzik August 27, 2018 20:59
@ghost ghost added this to the Sprint-123 milestone Aug 27, 2018
amarzavery
amarzavery reviewed Aug 27, 2018
View reviewed changes
.gitignore Outdated

# dotenv environment variables file
.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may wanna keep .env. I have been using them with dotenv package while writing samples and tests in the event hubs repo and the experience is wonderful. One need not worry about leaving environment variable values in source code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Done.

amarzavery
amarzavery reviewed Aug 27, 2018
View reviewed changes
.travis.yml Outdated
sudo: false
node_js:
- "8"
- "6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have

  • 8
  • 10

Copy link
Member

@RikkiGibson RikkiGibson Aug 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 is "maintenance LTS" until april 2019. What is the difference between Active LTS and Maintenance LTS?

see https://github.com/nodejs/Release

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 10.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active LTS is the currently stable version. Maintenance LTS is the n-1 stable release.

amarzavery
amarzavery reviewed Aug 27, 2018
View reviewed changes
documentation/Debugging.md Outdated
@@ -0,0 +1,74 @@
Different ways to debug azure-sdk-for-js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not relevant anymore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

amarzavery
amarzavery suggested changes Aug 27, 2018
View reviewed changes
package.json Outdated
"name": "azure-sdk-for-js",
"author": "Microsoft Corporation",
"version": "0.1.0-preview",
"description": "Microsoft Azure Client Libraries for Javascript",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft Azure Client Libraries for JavaScript with TypeScript type definitions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do people really read that?

Copy link
Member

@RikkiGibson RikkiGibson Aug 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect people to largely follow these steps:

  1. Install @azure/resources or a similar package
  2. Think "well, how will I install the corresponding @types package?"
  3. Give up and just try to start using the package
  4. Profit

Unlikely people will ever read the description in package.json.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going a little further--I'm not sure why there should be a root package.json if we don't ship a rollup package. Do you think there's a reason to have one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason I kept it was to use it for its scripts: {…} section.

documentation/SetupRepo.md Outdated
@@ -0,0 +1,24 @@
Setting up the Node SDK repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file

documentation/ServicePrincipal/package.json
@@ -0,0 +1,34 @@
{
"name": "azure-sp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good sample to have. It shows how to create a service principal using the sdk. Some customers wanted this since they didn't want to use CLI/Powershell/Portal to do so.

We should make sure this sample is working with the new SDK.

documentation/RunTests.md Outdated
@@ -0,0 +1,13 @@
## Running Node SDK Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete file.

documentation/ReleaseProcess.md Outdated
@@ -0,0 +1,37 @@
## What We're Doing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete file.

documentation/RegeneratingCode.md Outdated
@@ -0,0 +1,19 @@
# Regenerating Code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete file.

documentation/README.md Outdated
@@ -0,0 +1,12 @@
# Azure-SDK-For-Node Documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete file.

documentation/EnvironmentVariables.md Outdated


### For clients targeting the ARM (V2) Azure API that are generated using [AutoRest](https://github.com/Azure/autorest) should setup following environment variables:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

export AZURE_SUBSCRIPTION_ID=<A Guid>
export CLIENT_ID=<A Guid> # Application Id provided by Azure Active Directory (SPN for service principal auth)
export DOMAIN=<A Guid or the domain name of your org> contosoCorp.com
export AZURE_USERNAME=<Your org-id user name> user@contosoCorp.com # Only set this if you are using user authentication
export AZURE_PASSWORD=<Your Password> # Only set this if you are using user authentication
export APPLICATION_SECRET=<Your service principal password or secret> # Only set this if you are using service principal auth

Just keep the above info. Delete everything else.

documentation/Authentication.md Outdated
@@ -0,0 +1,216 @@
# Authentication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is important. It shows different ways to authenticate. We should probably rename the file and it's content as node.js auth (since the repo will contain isomorphic js code).

@ghost
Copy link
Author

ghost commented Aug 27, 2018

@amarzavery Anything else?

RikkiGibson
RikkiGibson reviewed Aug 27, 2018
View reviewed changes
package.json
@@ -0,0 +1,31 @@
{
"name": "azure-sdk-for-js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is not intended for publish then add "private": true

@ghost ghost merged commit 2d22033 into master Aug 27, 2018
@ghost ghost deleted the daschult/copyInitialFiles branch August 27, 2018 22:36
kpajdzik pushed a commit that referenced this pull request Oct 17, 2018
@AutorestCI @kpajdzik
[AutoPR servicefabric/data-plane] Add servicefabric/data-plane/readme…
019cc27 
….typescript.md (#160)

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-frontdoor package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/arm-containerservice package

* Generated from 29125d1ebf8cdb4508704216b9900a474fb50f38

Fix naming of dataplane package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* [AutoPR postgresql/resource-manager] Add postgresql/resource-manager/readme.typescript.md (#135)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from edb8b35678740de45b29826cbbdabf5868028ee5

Add postgresql/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* Regenerated "@azure/arm-postgresql" SDK.

* [AutoPR eventgrid/data-plane] Add eventgrid/data-plane/readme.typescript.md (#136)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from 9e9ce745d9057eb47e08f18d6be112937472c8a3

Add eventgrid/data-plane/readme.typescript.md

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* [AutoPR postgresql/resource-manager] Add postgresql/resource-manager/readme.typescript.md (#135)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from edb8b35678740de45b29826cbbdabf5868028ee5

Add postgresql/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* Regenerated "@azure/arm-postgresql" SDK.

* Regenerated "@azure/eventgrid" SDK.

* [AutoPR powerbidedicated/resource-manager] Add powerbidedicated/resource-manager/readme.typescript.md (#134)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from 7b23920dc024dcf298707964839d99eb9d5fd394

Add powerbidedicated/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* [AutoPR postgresql/resource-manager] Add postgresql/resource-manager/readme.typescript.md (#135)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from edb8b35678740de45b29826cbbdabf5868028ee5

Add postgresql/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* Regenerated "@azure/arm-postgresql" SDK.

* [AutoPR eventgrid/data-plane] Add eventgrid/data-plane/readme.typescript.md (#136)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from 9e9ce745d9057eb47e08f18d6be112937472c8a3

Add eventgrid/data-plane/readme.typescript.md

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* [AutoPR postgresql/resource-manager] Add postgresql/resource-manager/readme.typescript.md (#135)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from edb8b35678740de45b29826cbbdabf5868028ee5

Add postgresql/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* Regenerated "@azure/arm-postgresql" SDK.

* Regenerated "@azure/eventgrid" SDK.

* Regenerated "@azure/arm-powerbidedicated" SDK.

* Restapi auto generated/search 2018 10 12 892 (#216)

Regenerate @azure/arm-search package

* [AutoPR iothub/resource-manager] Add iothub/resource-manager/readme.typescript.md (#137)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from 41e0150af0aa90caa036d64dcc58bc956936c6a8

Add iothub/resource-manager/readme.typescript.md

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* [AutoPR postgresql/resource-manager] Add postgresql/resource-manager/readme.typescript.md (#135)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from edb8b35678740de45b29826cbbdabf5868028ee5

Add postgresql/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* Regenerated "@azure/arm-postgresql" SDK.

* [AutoPR eventgrid/data-plane] Add eventgrid/data-plane/readme.typescript.md (#136)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from 9e9ce745d9057eb47e08f18d6be112937472c8a3

Add eventgrid/data-plane/readme.typescript.md

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* [AutoPR postgresql/resource-manager] Add postgresql/resource-manager/readme.typescript.md (#135)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from edb8b35678740de45b29826cbbdabf5868028ee5

Add postgresql/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* Regenerated "@azure/arm-postgresql" SDK.

* Regenerated "@azure/eventgrid" SDK.

* [AutoPR powerbidedicated/resource-manager] Add powerbidedicated/resource-manager/readme.typescript.md (#134)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from 7b23920dc024dcf298707964839d99eb9d5fd394

Add powerbidedicated/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#118)

* Generate @azure/arm-monitor package (#117)

* Generate @azure/arm-migrate package (#116)

* Generate @azure/arm-mediaservices package (#115)

* Generate @azure/arm-marketplaceordering package (#114)

* Generate @azure/arm-mariadb package (#113)

* Generate @azure/arm-maps package (#112)

* Generate @azure/arm-managementpartner package (#111)

* Generate @azure/arm-managementgroups package (#110)

* Generate @azure/arm-machinelearningexperimentation package (#108)

* Generate @azure/arm-iotspaces package (#106)

* Generate @azure/arm-iotcentral package (#104)

* Generate @azure/arm-servicefabricmesh package (#81)

* Generate @azure/arm-containerservice package

* Update SwaggerToSDK generator version to 2.0.559

* Add generating readme files and SDKs (#39)

* Refactor Gulp structure

* Install nodegit

* Fix missing imports

* Refactor structure #2

* Refactor codegen

* Fix common.ts merge conflicts

* Add basic git operations

* Add updating main readme.md

* Fix branching

* Add GitHub integration

* Add draft of SDK generation

* Add automated PR creation for SDK creation

* Refactor file to use logger

* Add passing token as a command line argument

* Add capturing printed text

* Refactor logging

* Fix incorrect path bug

* Add committing and creating PRs in transactions

* Fix hard coded token

* Remove debug token printing

* Add step skipping

* Add @azure prefix to package names

* Add additional logging

* Change generated name of data-plane SDKs

* Remove unnecessary b option

* Generated from f3b3520c32cfe447a5f85b6491d65d59855b440a (#176)

remove the identity properties

* Generated from 4e40c606f9da0b2bc4d5fc95cb7d6fe072cf2170 (#138)

Adding OpenShiftManagedClusterBaseIdentityProvider and rename properties

* Update generator version for Swagger to SDK

* Remove unnecessary generated files

* Regenerate arm-containerregistry

* [AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API (#178)

* Generated from eff7dad034d8ea33e7680577ec3cd1de166e473e

Updated readme.md per review comment

* Generated from c2821abb9e291b0035e8befe7a6f5603c4bef5a3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

# Conflicts:
#	specification/consumption/resource-manager/readme.md

* Generated from 63c2d0f4fa8af538b59fa39aea1905b142a9fb5f

Updated version and replace subscriptionGuids with subscription Guids in Consumption.json Per comment

* Generated from 702e8f7ab327cd8fe694ed64684a300ed6bed1d9 (#185)

fixed json examples

* Regenerate arm-consumption

* Regenerate arm-sql

* Regenerate arm-consumption

* Upgrade Gulp to version 4.0.0 (#175)

* Automate SDK regeneration (#212)

* Add Version class

* Bootstrap packages regeneration

* Fix missing closing brace

* Improve branch handling

* Working version

* Fix branch creation

* Change commit story

* Add version skipping

* Regenerate package

* Regenerated "@azure/arm-powerbiembedded" SDK.

* [AutoPR postgresql/resource-manager] Add postgresql/resource-manager/readme.typescript.md (#135)

* Generate @azure/arm-containerregistry package

* Generate @azure/arm-servicefabric package

* Generate @azure/arm-containerservice package

* add code of conduct to the readme and contributing doc

* Generate @azure/arm-customerinsights package

* Generate @azure/arm-datafactory package

* Generate @azure/arm-datamigration package

* Generate @azure/arm-deploymentmanager package

* Generate @azure/arm-deviceprovisioningservices package

* Generate @azure/arm-devspaces package

* Generate @azure/arm-devtestlabs package

* Generate @azure/arm-domainservices package

* Generate @azure/arm-eventgrid package

* Generate @azure/arm-eventhub package

* Generate @azure/arm-frontdoor package

* Generate @azure/arm-hanaonazure package

* Generate @azure/arm-hdinsight package

* Generate @azure/arm-machinelearningcompute package

* Generate @azure/arm-machinelearningservices package

* Generate servicefabric package with the correct name

* Remove package with incorrect name

* Generated from a90288c3762cb1ac6f3998e2cd1c23d33f37dcb4

Add powerbiembedded/resource-manager/readme.typescript.md

* Generated from edb8b35678740de45b29826cbbdabf5868028ee5

Add postgresql/resource-manager/readme.typescript.md

* Generate @azure/eventgrid package (#124)

* Generate @azure/arm-iothub package (#105)

* Generated from f40292b667f4b6ce5b580131a308c336c9a9c9fc

Add deviceprovisioningservices/resource-manager/readme.typescript.md

* Generate @azure/graph package (#123)

* Generate @azure/loganalytics package (#122)

* Generate @azure/arm-operations package (#121)

* Generate @azure/arm-operationalinsights package (#120)

* Generate @azure/arm-notificationhubs package (#119)

* Generate @azure/arm-mysql package (#1…
AutorestCI added a commit that referenced this pull request Nov 25, 2018
@AutorestCI
Generated from 82cee8e19ad81e9d82d712cfabad1649b91b619a
5b32928 
Merge pull request #1 from omarelhariry/a-moghan/PublishingResponses

Adding Publishing To Regions Status
AutorestCI added a commit that referenced this pull request Dec 13, 2018
@AutorestCI
[AutoPR cognitiveservices/data-plane/LUIS/Authoring] Adding azure acc…
f0c42cc 
…ounts APIs (#574)

* Generated from 431fadac7b30b7c33b9fa6468874fce839869345

fixing build errors

* Generated from 82cee8e19ad81e9d82d712cfabad1649b91b619a

Merge pull request #1 from omarelhariry/a-moghan/PublishingResponses

Adding Publishing To Regions Status

* Generated from 23a7c077da0b751b8ad2b246d8da041d0906f90d

Fixing formats

* Generated from 4289fc27afed08636bf27abb57ace4a1ff69b7ee

Fixing OAV errors

* Generated from 3b62ef631bbcf684da8597627f22d1869bb37c7d

Merge pull request #2 from omarelhariry/kayousef/Dispatch_APIs

Adding dispatch APIs

* Generated from 4289fc27afed08636bf27abb57ace4a1ff69b7ee

Fixing OAV errors

* Generated from c7d11c54fe4f164073a570f2dba2510ddbf91c76

Add application-json as a 2nd prdocues format for packaging APIs, to describe the error responses

* Generated from b8ee038af90c620395c27635c989a3a6364335a4

Updating operation ids

* Generated from 32e19a3f178eab8d32f3fd79316bbaf7569ca7c8

fix oav and remove error responses
AutorestCI added a commit that referenced this pull request Mar 12, 2019
@AutorestCI
Generated from 42363c2f9c61172f0ebac88d32cb992d26dc73be
72aa352 
Merge pull request #1 from feiyushi/feshi-imagebuilder-preview2019

operation_id: plural forms
AutorestCI added a commit that referenced this pull request Mar 15, 2019
@AutorestCI
Generated from 8f28f7f041ff15ad42c21f1a342cdee8f35ecb4c
8e74e27 
FI from master to network-february-release (#5391)

* Add mixedreality 2019-02-28 API version to Go SDK (#5271)

* Remove ARM gateway Node.js configuration (#5283)

* Updates to Scheduled Query Rule swagger (#5175)

- making aznsaction paramter optional
  - removing hidden-link value from tags
pu

* Fix JavaScript configuration for ARM Private DNS SDK (#5284)

* Fix JavaScript configuration for ARM Private DNS SDK

* Add quotes

* Add private preview API for Azure Image Builder (#5055)

* Add private preview API for Azure Image Builder

* Review comments

 - Added list-by-resource-group and list-by-subscription
 - Added default error response
 - Removed explicit operation url (implied by async contract)
 - Adjusted 'delete' response codes to match expectations
 - Allow patch for tags
 - Added provider operations API

* Review comment: use "nextLink" for paging

* Adding readme files for SDK generation

* PR: rename 'tags' -> 'artifactTags' for distributor

* Add examples, fix minor issues in swagger

* Updating Blueprint spec to include resource group tags (#5263)

* Add Showback model (#5217)

* Add Showback model

* fix ShowbackRule.json example

* remove "," from line 1709

* Add Put Rule

* Fix Scope

* Update json with pull request changes

* change recurring to enum

* chore: Graphservice -> GraphService (#5098)

* Enable SSL on custom domains using users certificate or CDN managed certificate (#5276)

* Translator Text API V3 (#5230)

* Translator Text API V3

* Fix path and override

* Fix a typo and few other improvements in descriptions.

* Remove after_scripts

* Update readme.md

* Update readme.md

* Update MariaDB api version (#5280)

* Adding Swagger and examples for VirtualClusters operation group (#5248)

* Adding Swagger file for VirtualClusters operation group, together with examples.

* Fixing api version, typos and location in examples.

* Adding virtualclusters.json to readme.md

* Security - Updating API versions of alerts and pricing types (#5269)

* Security - Updating api versions of alerts and pricing types

* fix codegen paths for Go SDK

* typo: asscociation -> association (#5252)

* Fix lintdiff issue (#5299)

* fix Go SDK package path for mariadb stable release (#5298)

* changes to improve documentation of endpoint health statuses for routing (#5290)

* add netapp to Go SDK (#5308)

* Update MariaDB default API version to 2018-06-01 (#5302)

* new application insignts api version for unified schema in action (#5292)

* Added Azure App Configuration event data schema. (#5309)

* Added Azure App Configuration event data schema.

* Added a few missing pieces.

* Prefixed event names with our service prefix 'AppConfiguration'.
* Added Microsoft.AppConfiguration to the event grid data-plane readme.

* Updated api-version path to '2018-01-01' from '2018-02-01'.

* Apim Cache resource + DELETE long running + refactor to align with tooling. (#5260)

* api import and service delete long running operation

* Bring your own Cache

align with spec generated from tooling

user and notification align

Refactor products and apis

* align with spec generated from tooling

user and notification align

Refactor products and apis

validating examples

validating examples

move all parameters to apimanagement.json

Fix reference issue with tagcontract and example DeleteCache.

* switch to plural example file names for LIST

* bring back updatehostname and updatecertificate

* Dev adhybridhealthservice microsoft.ad hybrid health service 2014 01 01 binilkk (#5042)

* Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.

* Updated the Specification as example for Risky IP Download report.

* Added the Result details

* Fixed review comments, changed the URI scheme as well as changed get/post methods

* Addressing Review Feedback, changing POST call of blobUri -> generateBlobUri

* Update UserAssignedIdentities spec in Web (#5288)

* Update UserAssignedIdentities spec in Web

Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. 

Spec + history outlined here:
http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default 

Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. 

Our MSI implementation reflects Microsoft.Compute's spec for user assigned.

https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

* fix linterdiff tool

* Add private dns module name for java codegen (#5312)

* Update Swagger Files For ManagedInstanceAdministrator (#5095)

* Update Swagger Files For ManagedInstanceAdministrator

* Fix for double wording

* Comments resolved

* Bringing consistency between to "ResourceGroup" definition (#5256)

* Bringing consistency between this "ResourceGroup" definition and the one in Common.

* Fixing broken references

* reverted security python readme to pre multi api (#5301)

* [Azure Search] Add Search API to data plane Swagger spec (#5315)

* [Azure Search] Updating some Swagger descriptions to be more doc-friendly

Sometimes we over-describe things, especially "comma-separated lists" in
query string parameters. These are modeled as arrays in Swagger, which are
already understood to be comma-separated lists. They are modeled as
collections in generated code, so they are decidedly not comma-separated
lists in that context. So removing this phrase is a win-win.

* [Azure Search] Adding some missing readOnly attributes

* Adding Search API to the Azure Search data plane spec

* [Azure Search] Use regexes to generate code for server-side paging

This change introduces some very hacky regexes to customize the generated
code for server-side paging of the GET and POST Search APIs. They work by
splitting the generated SearchGet and SearchPost operations in two, so that
the portion that operates on a URL and request body can be reused.

This workaround is necessary because AutoRest lacks flexibility around
paging. The current x-ms-pageable implementation doesn't work for us because
it doesn't model additional top-level response properties or continuation
POST requests (only nextLink/GET).

The only other alternative to this approach besides custom code would have
been to try to parse the nextLink URL query string to reconstitute parameters
to pass to the generated SearchGet and SearchPost operations. This is
unacceptable for Azure Search, since it would exclude custom parameters that
can't be modeled in Swagger, like personalization IDs for custom ranking.
Neither AutoRest nor apparently Open API support modeling arbitrary query
string parameters.

Ideally we'll find a pattern common to other data plane APIs so we don't have
to hack this with regexes for every target language, but it's good enough for
now.

* [Azure Search] Rename some client properties for consistency

* [Azure Search] Make AutocompleteMode non-nullable

* [Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 (#5137)

* Add Hosting Environment network dependencies

* Address PR description feedback

* Add Network Dependencies examples

* Fix casing

* Remove incorrect pagination from examples.

* Add missing MarketplaceOrdering operations to swagger (#5279)

* Add missing MarketplaceOrdering operations to swagger

* Add examples

* Add example files

* Apply suggestions from code review

Clarify operation descriptions

Co-Authored-By: zachraMSFT <zachra@microsoft.com>

* Fix Hosting Environment Network Dependencies pagination (#5320)

* Add regex validation for ManagedClusterAgentPoolProfile.name (#5324)

* Adding instance pools swagger (#5225)

* Initializing instance pools swagger and examples - no usages / managed instances get by instance pool

* updates to use common resource and sku definitions

* Update instance pool swagger with typo fixes

* Updates to instance pool swagger and reverting readme.md to exclude instance pools reference

* Fix whitespace diff

* Making a whitespace change to re-try linter validation

* Updates to add list instances pools by subscription and update license type param to use enum which is limited to LicenseIncluded and BasePrice

* Enhanced A2ARecoveryPointDetails with "disks" (#5307)

* [DiskRP] Adding swagger spec for 09-30-2018 (#5232)

* commit for the older swagger version to make the PR easier to look at

* Adding the DiskRP 09-30-2018 swagger spec. This includes support for hyperVGeneration, encryptionSettingCollections, diskState, Upload Disks, and Write access

* adding the updated readme

* updating the examples to use 09-30-2018

* removing extraneous examples

* adding a description for the EncryptionSettingsElementand fixing linter issues

* [Computer Vision] Add read to CV OCR API. (#5314)

* Add read to OCR API.

* Add description to OCR related JSON properties.

* Mark asyncBatchAnalyze as long running operation.

* Update page property.

* Revert "Mark asyncBatchAnalyze as long running operation."

This reverts commit 51742b3e212c2e900ed5c24f7c351fa7f896d25e.

* added links to limits for application gateway (#5265)

* typo: Winodws -> Windows (#5321)

* MultiApi EventHub (#5331)

* try 2 bootstrapping swagger to .net sdk tools (#5334)

* bootstrapping swagger to .net sdk tools

* deleting nuget.exe binary. Updating configs to locally restore pacakges. Adding the directory that will be used in restoring packages locally to .gitignore

* changing directory

* updating feed location to a readonly directory

* Azure Search: Resource Manager: Support 'None' Identity type (#5319)

* Azure Search: Resource Manager: Support 'None' Identity type

* Azure Search: Resource Manager: Adding serice identity creation\removal examples

* [ADLA] - Catalog - Add stream path to USqlTableFragment (#5329)

* [Hub Generated] Review request for Microsoft.Consumption to add version 2019-01-01 (#5311)

* Add GTM scopes for budgets API

* Removed the extra period at the end of the statement

* fixing stos.proj parameter (#5338)

* change flag name from useUnifiedSchema into useCommonAlertSchema per UX requirement (#5323)

* Enhanced A2A protection input and response details (#5330)

Enhanced A2AEnableProtectionInput & A2AReplicationDetails objects with recoveryAvailabilityZone, recoveryAzureNetworkId, and recoverySubnetName.

* [Hub Generated] Review request for Microsoft.ContainerService to add version 2019-02-01 (#5350)

* Adds base for updating Microsoft.ContainerService from version preview/2018-08-01-preview to version 2019-02-01

* Updates readme

* Updates API version in new specs and examples

* [AKS] add availabilityZones to agent pool profile (#5120)

* including orchestratorVersion and provisioning state for agent pool (#5156)

* including orchestratorVersion and provisioning state for agent pool

* fixing the readme.go.md

* including enablePodSecurityPoliy properties for managedcluster and updating examples

* fixing the example for enablePodSecurityPolicy

* including apiServerAuthorizedIPRanges (#5286)

* including apiServerAuthorizedIPRanges

* support azure network policy

* mark the new features as PREVIEW in description  (#5310)

* mark the new features as PREVIEW

* mark vmss as required for az

* Azure Event Grid: Add 2019-02-01-preview tags for Ruby and Go readme files (#5349)

* Add 2019-02-01-preview tags for Ruby and Go readme files

* fix wrong preview subdirectory

* Update some descriptions. (#5305)

* update description. (#5335)

* Added VNet API (#5351)

* EventHub : corrected typo  (#5360)

* corrected typo in uri

* removed unused parameters

* Add annotations property to trigger (#5332)

* EventHub: Revert the NetworkRuleSet  (#5363)

* Revert "EventHub : corrected typo  (#5360)"

This reverts commit 1495122039e95d8795e3769d06c60e290cb53d2b.

* Revert "Added VNet API (#5351)"

This reverts commit f2ab4a8208bd3de1813b26b078429357dbd05506.

* Remove the AzureDataLakeStoreCosmosStructuredStreamDataset since it's internal only (#5277)

* Removing SDK generation from Travis-CI (#5367)

* Microsoft.DataBoxEdge RP: Corrected comments of trigger and extendedinfo APIs, corrected examples (#5322)

* Corrected comments of trigger and extendedinfo APIs, corrected examples

* Microsoft.DataBoxEdge RP: Have better examples

* Corrected parameter description in order API

* oad => @azure/oad (#5362)

* oad => @azure/oad

* oad => @azure/oad

* SRP Swagger changes for 2018-11-01 (#5300)

* SRP Swagger changes for 2018-11-01

* Address CR comments

* Restrict ManagementPolicyRule -> type property to have only values from defined enum

* Make ManagementPolicySchema/version an enum string

* Remove 'version' property from ManagementPolicy schema

* Added List Policies API to SecurityAlerts (#5070)

* Added SecurityAlert List API

Added List api to:
Manged Server + Managed Database
Logical Server + Logical Database

* FIxed a description

this property is for databases+servers

* Added missing Database exmaples

Added missing examples for database security alert

* Added missing description change

For Server Security Alerts

* Revert "FIxed a description"

This reverts commit e01a332d6e97ebedf04677ea5eb356ae4570d97b.

* Revert "Added missing description change"

This reverts commit 17aeab7011d6085d08e562248eb89c2b2fe40277.

* Update DatabaseSecurityAlertListByDatabase.json

* fixed examples

* Update DatabaseSecurityAlertCreateMin.json

Deleted wild comma

* Update readme.md

* Minor fixes

Changed tabs to spaces.
Added location for servers exmaples.

* Removed location

removed the location property from examples

* graph: improve API coverage on application & service principal  (#5181)

* [graphrbac]: fix bugs in permission grant apis

* fix paging

* add missing property

* remove pageable

* author pagable in the right way

* breaking changes over a wrong spec

* remove additionalProperties which causes wrong code-gen

* add suppressions

* use code to surpress

* address review feedabck

* moev ahead with the established pattern anyway

* address review feedbacks

* clean up all

* update operation id

* add one more property per CLI user's ask

* Add insights 2019-03-01 package to Go SDK (#5373)

* Add insights 2019-03-01 package to Go SDK

* move global settings before packages

* fix package tag for new API version (#5378)

* Remove GZRS and RAGZRS sku from SRP 2018-11-01 because feature slipped. (#5377)

* typo: upto -> up to (#5376)

* typo: graphrbac/data-plane/Microsoft.GraphRbac/stable/1.6 (#5375)

- requied -> required
- authorizaed -> authorized
- Organizatio -> Organization
- Allorganizations -> AllOrganizations
- Microsof -> Microsoft
- perperties -> prorperties
- servie -> service
- altenative -> alternative
- thubmbprint -> thumbprint

* Azure DevOps Pipeline workaround for private repository (#5374)

* Fix PolicyInsights code generation issue (#5389)

* Add replica creation parameters to Postgres ResourceProvider for SDK (#5379)

*  Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK
@kpajdzik kpajdzik mentioned this pull request Apr 4, 2019
Closed
AutorestCI added a commit that referenced this pull request Apr 8, 2019
@AutorestCI
Generated from ddf13110770128d56214a5e35b534eb92c1ea201
68d44dc 
Merge pull request #1 from reshantchandra/routing-2019-03-22-preview

Added properties for Message Enrichments to Iot Hub Routing Propertie…
HarshaNalluru referenced this pull request in HarshaNalluru/azure-sdk-for-js Apr 12, 2019
Merge pull request #1 from Azure/daschult/copyInitialFiles
67edb1d 
Initial commit for copying files from azure-sdk-for-node
@richardpark-msft richardpark-msft mentioned this pull request Jul 1, 2020
Closed
@praveenkuttappan praveenkuttappan mentioned this pull request Aug 21, 2020
Closed
@richardpark-msft richardpark-msft mentioned this pull request Oct 28, 2020
Merged
@joheredi joheredi mentioned this pull request Nov 18, 2020
Closed
@ljian3377 ljian3377 mentioned this pull request Feb 19, 2021
Closed
6 tasks
richardpark-msft added a commit that referenced this pull request Feb 19, 2021
@richardpark-msft
[monitor] Fix some of the more obvious breakages (CI is still broken …
8a86351 
…afterwards, however) (#13881)

(NOTE: CI is still broken as we have to investigate the rest of the breakages in the test)

* Problem #1 - the underlying value has changed (it used to be a CanonicalCode.OK (0) but now is StatusCode.OK (1)).
* Fixing issue where the test failing wasn't actually passed on to the test framework.
@richardpark-msft richardpark-msft mentioned this pull request Feb 22, 2021
Merged
@richardpark-msft richardpark-msft mentioned this pull request Apr 3, 2021
Closed
@deyaaeldeen deyaaeldeen mentioned this pull request Jun 24, 2021
Merged
@scbedd scbedd mentioned this pull request Jul 7, 2021
Closed
97 tasks
cochi2 added a commit to cochi2/azure-sdk-for-js that referenced this pull request Oct 15, 2021
@cochi2
Browser test Azure#1
8f5e29a
zihzhan-msft pushed a commit that referenced this pull request Oct 15, 2021
@cochi2 @ravithanneeru
Adding Recording and Download APIs (#18147)
5744997 
* Initial API changes for Node JS SDK for calling server

* First test case

* Adding live testing?

* ServerCall Recording test

* Adding recording to the live testing

* Recording live testing completed

* Refactored Live Testing

* Download part 1

* First download test working!

* First download test working!

* First test complete complete

* Adding new test for download

* Fixing tests

* Call recording APIs initial check in

* Fixes based on E2E validation from samples and API document update

* Misc

* Added startRecording attributes

* CHanging test to be a group call

* Live test fixed

* Finalized testing

* Adding redirection test case

* Fixing communication-common lint errors

* Fixing ContentDownloader lint issues

* Lint autofix

* Remove getCall method

* Fixing CallingServerClient lint issues

* Fixing models lint issues

* Fix RetriableReadableStream lint issues

* Fixing specs lint issues

* Fixing testUtils lint issues

* Ran rushx format

* Run rushx format in communication-common

* Adding Changelog file

* Running api-extractor

* Formatting

* Adding review folder

* Api extractor after merge

* Rebuilding

* Attempting to make readable to work

* Fixing Readable issue

* Fixed one browser test

* Removing things from karma

* Browser test #1

* Fixed testing

* Fixing format

* Removing comments

* Running API_EXTRACTOR

* Changing api file

Co-authored-by: Ravi Thanneeru <v-ratann@microsoft.com>
@binarybamboo binarybamboo mentioned this pull request Nov 23, 2021
Closed
@witemple-msft witemple-msft mentioned this pull request Feb 15, 2022
Merged
@scbedd scbedd mentioned this pull request May 2, 2022
Closed
@deyaaeldeen deyaaeldeen mentioned this pull request May 18, 2022
Merged
yogeshmo added a commit that referenced this pull request Jun 27, 2022
@yogeshmo
Merge pull request #1 from yogeshmo/local/non-pr/main
8f9e6db 
Adding communication-email sdk to fork
dubiety pushed a commit to dubiety/azure-sdk-for-js that referenced this pull request Jul 13, 2022
@alankashiwa
Route model fixes Azure#1
2d27bab
dubiety pushed a commit to dubiety/azure-sdk-for-js that referenced this pull request Jul 21, 2022
@alankashiwa
Route model fixes Azure#1
644e862
@Jcodevisible Jcodevisible mentioned this pull request Aug 17, 2022
Closed
andykao1213 pushed a commit to andykao1213/azure-sdk-for-js that referenced this pull request Aug 24, 2022
@alankashiwa @andykao1213
Route model fixes Azure#1
ab5b5d5
andykao1213 pushed a commit to andykao1213/azure-sdk-for-js that referenced this pull request Sep 5, 2022
@alankashiwa @andykao1213
Route model fixes Azure#1
7ac8932
andykao1213 pushed a commit to andykao1213/azure-sdk-for-js that referenced this pull request Sep 6, 2022
@alankashiwa @andykao1213
Route model fixes Azure#1
08120d8
andykao1213 pushed a commit to andykao1213/azure-sdk-for-js that referenced this pull request Sep 14, 2022
@alankashiwa @andykao1213
Route model fixes Azure#1
e1039a9
EmmaZhu pushed a commit to EmmaZhu/azure-sdk-for-js that referenced this pull request Sep 21, 2022
@mwiedemeyer
Merge pull request Azure#1 from EmmaZhu/storage-bug-22568
ab5fff5 
Rerecord test cases.
andykao1213 added a commit that referenced this pull request Oct 26, 2022
@andykao1213 @dubiety @alankashiwa
[Maps] Onboarding @azure-rest/maps-route (#23588)
ad48f52 
* Update maps dependency in pnpm-lock.yaml

* Fix sample metadata errors

* Fix linting errors

* Fix linting errors

* Fix run time error

* Update package.json in samples folder

* Fix linting errors

* Fix linting errors

* Add changelog for maps-common

* Update recording files for maps-search

* Add test.yml for maps-search

* Add tests.yml for render and route

* Update tests.yml

* Update test-resources.json for maps

* Fix tests.yml format error

* Update env vars and remove unused export var

* Remove unused code

* Fix lock file

* Remove route & render

* Replace `beginGet*Batch` with `resume*Batch`

We provide a `beginGet*Batch` method to resume the previous
request previously. This is not ideal because it need to get a
`batchId` which is store in the internal state of the LRO. Once
the LRO brings changes, our code will be broken.

We can achieve the same thing by using serialized state.
This change aims to leverage this approach and create convenience
methods `resume*Batch` for users

* Update recording

* Make the endpoint of `MapsSearchClient` configurable

* Change LatLon from an interface to a tuple

Also remove the `toLatLon` function since creating a tuple
is quite easy.

* Make the props `coordinates` and `countryCodeFilter` optional

Specifying `coordinates` and `countryCodeFilter` can narrow the results
of the fuzzy search. But considring the case like searching "Australia",
theese fields may have no use. We decided to make them optional so user
can decides if they want to narrow down the results or not.

* fixup! Remove route & render

* Adjust CHANGELOGs of maps-search & common

Following the keyvault-common, removing CHANGELOGs
from maps-common since it's not published.

* Update samples

* Add batchRequest sample

* Add a new sample searchAddressResult

* Update search.ts and its examples

* enhance code example in README.md

* comment unused import

* Update recording for maps-search

* remove redundant recording files

* Add maps-search

* Rename LatLong to LatLon

* Fix constructor Readme doc

* Update readme to new signature

* Add tests partially

* Change LatLon/BoundingBox to interfaces

* Reduce the number of constructor overloading

* Rename SearchClient as MapsSearchClient

* Add options mapper tests

* Add result type mapper tests (in progress)

* rename clientId to mapsAccountClientId

* listPolygons -> getPolygons

* getPointOfInterestCategoryTree -> getPointOfInterestCategories

* Expose missing model

* Add alternative input file for quick experiment

* Regenerate code and make changes accordingly

* Reduce number of overloads of fuzzy searches

* Add geojson types

* Adopting new geojson definitions

* Change test specs to align with new method names

* clean up models and tsconfig

* Expose Known* models

* Remove batch sync methods

* Add public tests (non-batch)

* move model

* Add docstrings

* Start polling in begin* method

* Refactor BatchPoller for retrieving batchId

* Finalize batch pollers

* Readd batch methods

* Update generated code

* Finalize batch signature

* Rebuild samples & clean up

* Add AAD tests

* Clean up Swagger readme

* Fix spelling

* Add initial files for @azure/maps-route module

* maps-search: change comments and perform formatting

* Methods options and testing skeleton for maps-route

* maps-search: refactor options

* Improve convenience layer for non-LRO methods

* Change variable names

* Complete batch methods

* update maps-search Readme

* Update maps-route Readme

* Add generated samples for maps-route

* Update samples for maps-search

* Delete backup file

* Add maps-common module

* Update maps-route/maps-search to use maps-common

* maps-render: first draft

* Use LatLon/BoundingBox from maps-common

* Complete maps-render with tests

* Expose required types from maps-route

* Expose required types from maps-search

* Complete unit tests for maps-render

* Update maps-render README

* Update samples

* Fix comment/strings

* Fix comment/strings

* Update Route comment/interface

* Regenerate code

* Update files

* Define required fields and fix code

* Remove non-poller batch methods

* Fix playback test failure

* Rename parts of model names

* Rename remaining parts of models according to review feedback

* Remove TODO comments

* Update Reamdme transform to reflect latest swagger

* Change key policy name

* Simplify batch item error model

* Add brower tests

* Turn maps-common into internal module

* Rearrange Readme

* Rewrite Readme for common

* Remove batch-sync methods

* Route required fields: part 1

* Route required fields: part 2

* Add AAD back

* Route model fixes #1

* Route model fixes #2 + geojson named tuples

* Refine geojson types

* Aliased a few method options

* maps-render required fields part 1

* Do not validate budget parameters

* Revert "Do not validate budget parameters"

This reverts commit 4ec3f5f.

* Rename MapTileset to TileJson

* Render: model rename & type improvement

* Explicitly transform image range

* Fix route record tests

* Update map account creation commands in Readme

* Update Readme/docstrings/samples for Search/Route/Render

* Remove rollup and use dev-tool instead

* Remove some empty tests

* Add AAD test case and make file name shorter

* Update test cases

* Update cspell rules

* Update recording files

* Simplify test cases

* Sync cspell.json from upstream

* Use test-recorder 2.0 and update unit test cases

* Push wrong browsers recording files

* Update settings to support recording

* Fix dependency errors

* Upgrade api-recorder and fix errors

* Code refinement

* Update maps search recording files

* Update karma.conf.js format

* Update recording files and settings

* Fix broken links

* Update maps dependency in pnpm-lock.yaml

* Fix sample metadata errors

* Fix linting errors

* Fix linting errors

* Fix run time error

* Update package.json in samples folder

* Fix linting errors

* Fix linting errors

* Add changelog for maps-common

* Update recording files for maps-search

* Add test.yml for maps-search

* Add tests.yml for render and route

* Update tests.yml

* Update test-resources.json for maps

* Fix tests.yml format error

* Update env vars and remove unused export var

* Remove unused code

* Fix lock file

* Remove maps-render

* fixup! Change LatLon from an interface to a tuple

* Comment the future doc link

* Update doc & fix type issue

* fix lint issues

* Regenerate API View

* Comment the whole [apiref] since the original syntax cannot pass the Analyze/Link verification

* Fix issue related to the change of maps-common

- Replace beginGet*Result with resume* methods
- Turn LatLon to a tuple
- Add mapper to transform the string to Date because resume* method will
return a serialized Date

* Update test recording

* Remove maps-common from the Artifacts

* remove unused dependencies

* Add impression in README so we can track the page views

* Remove `AZURE_LOG_LEVEL` in test.yml

* Update samples

- Move the option parameter to the right place
- Add comments & "break" for handling the type of the search result to make it clear for the user

* Patch {} to properties for GeoJsonPolygon

* rename maxDetourTime to maxDetourTimeInSeconds

* Update recordings

* Remove any

* Rename to detourTimeInSeconds to align the convention

* Change the test.yml EnvVar

See more explanation here:
- #23039 (comment)
- #23039 (comment)

* Rename numResults to numberResults

* Add document comment

* Add endpoint options to MapsRouteClient

* Remove unused dependencies in maps-route

* fixup! Change the test.yml EnvVar

* Update interfaces & documents

* Update changelog

* Merge getRouteDirection with the additional parameter one

* Update samples

* Make the `maps-common to a published package

* Update the import of `maps-common` in `maps-search`

* Fix CI Issue

* Add documents for geojson

* Update the samples & readme

* Leverage maps-common package in mpas-route

* chore update

- Remove the unnecessary rule setting of eslint
- Update the legacy type path

* Remove unnecessary eslint config

* WIP: Remove LRO generation

* WIP: refactor mapsRouteClient

* WIP: first generation

* Format the generated code

* Support AAD

* Transform the model name

* Add helper functions

* Add a sample - route.ts

* Add samples for lro

* Add test

* Generate samples

* Add api view

* Update the generation

* WIP: ReadMe

* Rename "computeBestOrder" to "computeBestWaypointOrder"

* Refine README

* Rename model

* Add test createRouteDirectionsBatchRequest

* Fix lint issue

* Add missing metadata

* Remove maps-route/

* Update CI issue

* Fix merged issue

* Update version rule for maps-common

* Update CI name

* Remove extra lint config

* Use `require` in the README for consistency

* Regenerate the samples

* Remove redundant recording files

* Remove unused parameters in test-resources.json

* Refine readme snippet

* Log something specific for the result

* Update samples

* Split the route.ts into 3

* Remove model rename

* Use default export for RLC factory function

Co-authored-by: Charlie Chen <charlie.chen@microsoft.com>
Co-authored-by: Charlie Chen <yuchungchen@microsoft.com>
Co-authored-by: --global <alankashiwa@gmail.com>
mpodwysocki pushed a commit that referenced this pull request Nov 2, 2022
@andykao1213 @dubiety
@alankashiwa @mpodwysocki
[Maps] Onboarding @azure-rest/maps-route (#23588)
ee138c7 
* Update maps dependency in pnpm-lock.yaml

* Fix sample metadata errors

* Fix linting errors

* Fix linting errors

* Fix run time error

* Update package.json in samples folder

* Fix linting errors

* Fix linting errors

* Add changelog for maps-common

* Update recording files for maps-search

* Add test.yml for maps-search

* Add tests.yml for render and route

* Update tests.yml

* Update test-resources.json for maps

* Fix tests.yml format error

* Update env vars and remove unused export var

* Remove unused code

* Fix lock file

* Remove route & render

* Replace `beginGet*Batch` with `resume*Batch`

We provide a `beginGet*Batch` method to resume the previous
request previously. This is not ideal because it need to get a
`batchId` which is store in the internal state of the LRO. Once
the LRO brings changes, our code will be broken.

We can achieve the same thing by using serialized state.
This change aims to leverage this approach and create convenience
methods `resume*Batch` for users

* Update recording

* Make the endpoint of `MapsSearchClient` configurable

* Change LatLon from an interface to a tuple

Also remove the `toLatLon` function since creating a tuple
is quite easy.

* Make the props `coordinates` and `countryCodeFilter` optional

Specifying `coordinates` and `countryCodeFilter` can narrow the results
of the fuzzy search. But considring the case like searching "Australia",
theese fields may have no use. We decided to make them optional so user
can decides if they want to narrow down the results or not.

* fixup! Remove route & render

* Adjust CHANGELOGs of maps-search & common

Following the keyvault-common, removing CHANGELOGs
from maps-common since it's not published.

* Update samples

* Add batchRequest sample

* Add a new sample searchAddressResult

* Update search.ts and its examples

* enhance code example in README.md

* comment unused import

* Update recording for maps-search

* remove redundant recording files

* Add maps-search

* Rename LatLong to LatLon

* Fix constructor Readme doc

* Update readme to new signature

* Add tests partially

* Change LatLon/BoundingBox to interfaces

* Reduce the number of constructor overloading

* Rename SearchClient as MapsSearchClient

* Add options mapper tests

* Add result type mapper tests (in progress)

* rename clientId to mapsAccountClientId

* listPolygons -> getPolygons

* getPointOfInterestCategoryTree -> getPointOfInterestCategories

* Expose missing model

* Add alternative input file for quick experiment

* Regenerate code and make changes accordingly

* Reduce number of overloads of fuzzy searches

* Add geojson types

* Adopting new geojson definitions

* Change test specs to align with new method names

* clean up models and tsconfig

* Expose Known* models

* Remove batch sync methods

* Add public tests (non-batch)

* move model

* Add docstrings

* Start polling in begin* method

* Refactor BatchPoller for retrieving batchId

* Finalize batch pollers

* Readd batch methods

* Update generated code

* Finalize batch signature

* Rebuild samples & clean up

* Add AAD tests

* Clean up Swagger readme

* Fix spelling

* Add initial files for @azure/maps-route module

* maps-search: change comments and perform formatting

* Methods options and testing skeleton for maps-route

* maps-search: refactor options

* Improve convenience layer for non-LRO methods

* Change variable names

* Complete batch methods

* update maps-search Readme

* Update maps-route Readme

* Add generated samples for maps-route

* Update samples for maps-search

* Delete backup file

* Add maps-common module

* Update maps-route/maps-search to use maps-common

* maps-render: first draft

* Use LatLon/BoundingBox from maps-common

* Complete maps-render with tests

* Expose required types from maps-route

* Expose required types from maps-search

* Complete unit tests for maps-render

* Update maps-render README

* Update samples

* Fix comment/strings

* Fix comment/strings

* Update Route comment/interface

* Regenerate code

* Update files

* Define required fields and fix code

* Remove non-poller batch methods

* Fix playback test failure

* Rename parts of model names

* Rename remaining parts of models according to review feedback

* Remove TODO comments

* Update Reamdme transform to reflect latest swagger

* Change key policy name

* Simplify batch item error model

* Add brower tests

* Turn maps-common into internal module

* Rearrange Readme

* Rewrite Readme for common

* Remove batch-sync methods

* Route required fields: part 1

* Route required fields: part 2

* Add AAD back

* Route model fixes #1

* Route model fixes #2 + geojson named tuples

* Refine geojson types

* Aliased a few method options

* maps-render required fields part 1

* Do not validate budget parameters

* Revert "Do not validate budget parameters"

This reverts commit 4ec3f5f.

* Rename MapTileset to TileJson

* Render: model rename & type improvement

* Explicitly transform image range

* Fix route record tests

* Update map account creation commands in Readme

* Update Readme/docstrings/samples for Search/Route/Render

* Remove rollup and use dev-tool instead

* Remove some empty tests

* Add AAD test case and make file name shorter

* Update test cases

* Update cspell rules

* Update recording files

* Simplify test cases

* Sync cspell.json from upstream

* Use test-recorder 2.0 and update unit test cases

* Push wrong browsers recording files

* Update settings to support recording

* Fix dependency errors

* Upgrade api-recorder and fix errors

* Code refinement

* Update maps search recording files

* Update karma.conf.js format

* Update recording files and settings

* Fix broken links

* Update maps dependency in pnpm-lock.yaml

* Fix sample metadata errors

* Fix linting errors

* Fix linting errors

* Fix run time error

* Update package.json in samples folder

* Fix linting errors

* Fix linting errors

* Add changelog for maps-common

* Update recording files for maps-search

* Add test.yml for maps-search

* Add tests.yml for render and route

* Update tests.yml

* Update test-resources.json for maps

* Fix tests.yml format error

* Update env vars and remove unused export var

* Remove unused code

* Fix lock file

* Remove maps-render

* fixup! Change LatLon from an interface to a tuple

* Comment the future doc link

* Update doc & fix type issue

* fix lint issues

* Regenerate API View

* Comment the whole [apiref] since the original syntax cannot pass the Analyze/Link verification

* Fix issue related to the change of maps-common

- Replace beginGet*Result with resume* methods
- Turn LatLon to a tuple
- Add mapper to transform the string to Date because resume* method will
return a serialized Date

* Update test recording

* Remove maps-common from the Artifacts

* remove unused dependencies

* Add impression in README so we can track the page views

* Remove `AZURE_LOG_LEVEL` in test.yml

* Update samples

- Move the option parameter to the right place
- Add comments & "break" for handling the type of the search result to make it clear for the user

* Patch {} to properties for GeoJsonPolygon

* rename maxDetourTime to maxDetourTimeInSeconds

* Update recordings

* Remove any

* Rename to detourTimeInSeconds to align the convention

* Change the test.yml EnvVar

See more explanation here:
- #23039 (comment)
- #23039 (comment)

* Rename numResults to numberResults

* Add document comment

* Add endpoint options to MapsRouteClient

* Remove unused dependencies in maps-route

* fixup! Change the test.yml EnvVar

* Update interfaces & documents

* Update changelog

* Merge getRouteDirection with the additional parameter one

* Update samples

* Make the `maps-common to a published package

* Update the import of `maps-common` in `maps-search`

* Fix CI Issue

* Add documents for geojson

* Update the samples & readme

* Leverage maps-common package in mpas-route

* chore update

- Remove the unnecessary rule setting of eslint
- Update the legacy type path

* Remove unnecessary eslint config

* WIP: Remove LRO generation

* WIP: refactor mapsRouteClient

* WIP: first generation

* Format the generated code

* Support AAD

* Transform the model name

* Add helper functions

* Add a sample - route.ts

* Add samples for lro

* Add test

* Generate samples

* Add api view

* Update the generation

* WIP: ReadMe

* Rename "computeBestOrder" to "computeBestWaypointOrder"

* Refine README

* Rename model

* Add test createRouteDirectionsBatchRequest

* Fix lint issue

* Add missing metadata

* Remove maps-route/

* Update CI issue

* Fix merged issue

* Update version rule for maps-common

* Update CI name

* Remove extra lint config

* Use `require` in the README for consistency

* Regenerate the samples

* Remove redundant recording files

* Remove unused parameters in test-resources.json

* Refine readme snippet

* Log something specific for the result

* Update samples

* Split the route.ts into 3

* Remove model rename

* Use default export for RLC factory function

Co-authored-by: Charlie Chen <charlie.chen@microsoft.com>
Co-authored-by: Charlie Chen <yuchungchen@microsoft.com>
Co-authored-by: --global <alankashiwa@gmail.com>
@EmmaZhu EmmaZhu mentioned this pull request Nov 11, 2022
Closed
6 tasks
@mikeharder mikeharder mentioned this pull request Feb 22, 2023
Open
@sarangan12 sarangan12 mentioned this pull request Oct 10, 2023
Closed
3 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpajdzik kpajdzik Awaiting requested review from kpajdzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint-123
Development

Successfully merging this pull request may close these issues.
2 participants
@amarzavery @RikkiGibson