Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC][RBAC] - Alerts as data RBAC MVP #100527

Closed
wants to merge 192 commits into from

Commits on Apr 30, 2021

  1. WIP - creating alerting authorization client factory and exposing aut…

    …horization client on plugin start contract
    ymao1 committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    1170c6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a1c2c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbde0cc View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Merge branch 'master' of https://github.com/elastic/kibana into alert…

    …ing/refactor-alerts-authorization
    ymao1 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    a2ffb8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd1a28b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a97e064 View commit details
    Browse the repository at this point in the history
  4. Changing alertType to ruleType

    ymao1 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    b9ee8ac View commit details
    Browse the repository at this point in the history
  5. Changing alertType to ruleType

    ymao1 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    cd6185f View commit details
    Browse the repository at this point in the history
  6. Updating unit tests

    ymao1 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    6daa470 View commit details
    Browse the repository at this point in the history
  7. Updating unit tests

    ymao1 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    be00344 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    721576a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e1cd872 View commit details
    Browse the repository at this point in the history
  10. Fixing functional tests

    ymao1 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    2007a56 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    857b0de View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Merge branch 'master' of https://github.com/elastic/kibana into alert…

    …ing/refactor-alerts-authorization
    ymao1 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    56e876c View commit details
    Browse the repository at this point in the history
  2. Fixing some types and tests

    ymao1 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7ef5bcd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8359289 View commit details
    Browse the repository at this point in the history
  4. Cleanup and tests

    ymao1 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    b5a49cd View commit details
    Browse the repository at this point in the history
  5. Cleanup and tests

    ymao1 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    0fbaf23 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Merge branch 'master' of https://github.com/elastic/kibana into alert…

    …ing/refactor-alerts-authorization
    ymao1 committed May 11, 2021
    Configuration menu
    Copy the full SHA
    1792895 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Configuration menu
    Copy the full SHA
    27af55f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee3f226 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bfbfae4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3abf488 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of https://github.com/elastic/kibana into alert…

    …ing/refactor-alerts-authorization
    ymao1 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    334030b View commit details
    Browse the repository at this point in the history
  6. Fixing unit tests

    ymao1 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a04dc1e View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Configuration menu
    Copy the full SHA
    2de423d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3bafd6d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    004938e View commit details
    Browse the repository at this point in the history
  4. Merge branch 'alerting/refactor-alerts-authorization' into alerting/a…

    …dd-subfeature-privilege
    ymao1 committed May 13, 2021
    Configuration menu
    Copy the full SHA
    6a881c1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    804fa5d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Configuration menu
    Copy the full SHA
    d4baa3d View commit details
    Browse the repository at this point in the history
  2. Fixing types check

    ymao1 committed May 14, 2021
    Configuration menu
    Copy the full SHA
    36f7e9f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Clearing the global search bar will reset suggestions (elastic#88637)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    95bef47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    223696b View commit details
    Browse the repository at this point in the history
  3. Skip flaky functional test suite

    elastic#100060
    
    Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
    Tyler Smalley authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b0a2537 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    280dfb0 View commit details
    Browse the repository at this point in the history
  5. Rename alert status OK to Recovered and fix some UX issues around dis…

    …abling a rule while being in an error state (elastic#98135)
    
    * Fix UX when alert is disabled and in an error state
    
    * Reset executionStatus to pending after enabling an alert
    
    * Renames alert instance status OK to Recovered
    
    * Fix end to end test
    
    * Update doc screenshot
    
    * Fix confusing test name
    
    * Remove flakiness in integration test
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2122149 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b009dab View commit details
    Browse the repository at this point in the history
  7. [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (elastic#100035

    )
    
    * Update SchemaFieldTypeSelect to allow passing any aria props
    
    - We'll specifically be using aria-labelledby in this PR, but theoretically any aria prop should be fine.
    
    * Update AS & WS schema tables to use the type table column heading as an aria-labelledby ID
    Constance authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1a955a2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6208628 View commit details
    Browse the repository at this point in the history
  9. [Uptime] Increase debounce and add immediate submit to useQueryBar (e…

    …lastic#99675)
    
    * Increase debounce and add immediate submit to `useQueryBar`.
    
    * Reduce debounce to 800ms.
    justinkambic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f9654a7 View commit details
    Browse the repository at this point in the history
  10. [Security Solutions][Lists] Trims down list plugin size by breaking o…

    …ut the exception builder into chunks by using react lazy loading (elastic#99989)
    
    ## Summary
    
    Trims down the list plugin size by breaking out the exception builder into a dedicated chunk by using React Suspense and React lazy loading.
    
    Before this PR the page load bundle size was `260503`, after the page load bundle size will be `194132`:
    
    You can calculate this through:
    ```ts
    node ./scripts/build_kibana_platform_plugins --dist --focus lists
    cat ./x-pack/plugins/lists/target/public/metrics.json
    ```
    
    Before
    ```json
    [
      {
        "group": "@kbn/optimizer bundle module count",
        "id": "lists",
        "value": 227
      },
      {
        "group": "page load bundle size",
        "id": "lists",
        "value": 260503, <--- Very large load bundle size
        "limit": 280504,
        "limitConfigPath": "packages/kbn-optimizer/limits.yml"
      },
      {
        "group": "async chunks size",
        "id": "lists",
        "value": 0
      },
      {
        "group": "async chunk count",
        "id": "lists",
        "value": 0
      },
      {
        "group": "miscellaneous assets size",
        "id": "lists",
        "value": 0
      }
    ]
    ```
    
    After:
    ```json
    [
      {
        "group": "@kbn/optimizer bundle module count",
        "id": "lists",
        "value": 227
      },
      {
        "group": "page load bundle size",
        "id": "lists",
        "value": 194132, <--- Not as large bundle size
        "limit": 280504,
        "limitConfigPath": "packages/kbn-optimizer/limits.yml"
      },
      {
        "group": "async chunks size",
        "id": "lists",
        "value": 70000
      },
      {
        "group": "async chunk count",
        "id": "lists",
        "value": 1
      },
      {
        "group": "miscellaneous assets size",
        "id": "lists",
        "value": 0
      }
    ]
    ```
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7e80099 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f331d64 View commit details
    Browse the repository at this point in the history
  12. Re-enable formerly flaky shareable test (elastic#98826)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3deb2bd View commit details
    Browse the repository at this point in the history
  13. [Canvas] Remove unused legacy autocomplete component (elastic#99215)

    * Remove unused autocomplete component
    
    * Remove reference to autocomplete CSS
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1c82ec3 View commit details
    Browse the repository at this point in the history
  14. [QA] Switch tests to use importExport - visualize (elastic#98063)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e6c88d7 View commit details
    Browse the repository at this point in the history
  15. [index pattern field editor] Update runtime field painless docs url (e…

    …lastic#100014)
    
    * update runtime field painless docs url
    mattkime authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    65371d9 View commit details
    Browse the repository at this point in the history
  16. [Workplace Search] Fix bug when transitioning to personal dashboard (e…

    …lastic#100061)
    
    The unmount callback should have never been in the useEffect keyed off of the pathname. Another issue appeared earlier and I tried to fix it with the now removed conditional, but it should have been removed into it’s own useEffect that only runs when the component is unmounted, not on every route change.
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4d180a4 View commit details
    Browse the repository at this point in the history
  17. [Fleet] Fix error when searching for keys whose names have spaces (el…

    …astic#100056)
    
    ## Summary
    fixes elastic#99895
    
    Can reproduce elastic#99895 with something like
    ```shell
    curl 'http://localhost:5601/api/fleet/enrollment-api-keys' \
      -H 'content-type: application/json' \
      -H 'kbn-version: 8.0.0' \
      -u elastic:changeme \
      --data-raw '{"name":"with spaces","policy_id":"d6a93200-b1bd-11eb-90ac-052b474d74cd"}'
    ```
    
    Kibana logs this stack trace
    
    ```
    server    log   [10:57:07.863] [error][fleet][plugins] KQLSyntaxError: Expected AND, OR, end of input but "\" found.
    policy_id:"d6a93200-b1bd-11eb-90ac-052b474d74cd" AND name:with\ spaces*
    --------------------------------------------------------------^
        at Object.fromKueryExpression (/Users/jfsiii/work/kibana/src/plugins/data/common/es_query/kuery/ast/ast.ts:52:13)
        at listEnrollmentApiKeys (/Users/jfsiii/work/kibana/x-pack/plugins/fleet/server/services/api_keys/enrollment_api_key.ts:37:69)
        at Object.generateEnrollmentAPIKey (/Users/jfsiii/work/kibana/x-pack/plugins/fleet/server/services/api_keys/enrollment_api_key.ts:160:31)
        at processTicksAndRejections (internal/process/task_queues.js:93:5)
        at postEnrollmentApiKeyHandler (/Users/jfsiii/work/kibana/x-pack/plugins/fleet/server/routes/enrollment_api_key/handler.ts:53:20)
        at Router.handle (/Users/jfsiii/work/kibana/src/core/server/http/router/router.ts:273:30)
        at handler (/Users/jfsiii/work/kibana/src/core/server/http/router/router.ts:228:11)
        at exports.Manager.execute (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
        at Object.internals.handler (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/handler.js:46:20)
        at exports.execute (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/handler.js:31:20)
        at Request._lifecycle (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/request.js:370:32)
        at Request._execute (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/request.js:279:9) {
      shortMessage: 'Expected AND, OR, end of input but "\\" found.'
    ```
    
    the `kuery` value which causes the `KQLSyntaxError` is
    ```
    policy_id:\"d6a93200-b1bd-11eb-90ac-052b474d74cd\" AND name:with\\ spaces*
    ``` 
    
    a value without spaces, e.g. `no_spaces` 
    
    ```
    policy_id:\"d6a93200-b1bd-11eb-90ac-052b474d74cd\" AND name:no_spaces*
    ```
    
    is converted to this query object
    
    ```
    {
      "bool": {
        "filter": [
          {
            "bool": {
              "should": [
                {
                  "match_phrase": {
                    "policy_id": "d6a93200-b1bd-11eb-90ac-052b474d74cd"
                  }
                }
              ],
              "minimum_should_match": 1
            }
          },
          {
            "bool": {
              "should": [
                {
                  "query_string": {
                    "fields": [
                      "name"
                    ],
                    "query": "no_spaces*"
                  }
                }
              ],
              "minimum_should_match": 1
            }
          }
        ]
      }
    ```
    
    I tried some other approaches for handling the spaces based on what I saw in the docs like `name:"\"with spaces\"` and `name:(with spaces)*`but they all failed as well, like
    
    ```
    KQLSyntaxError: Expected AND, OR, end of input but "*" found.
    policy_id:"d6a93200-b1bd-11eb-90ac-052b474d74cd" AND name:(with spaces)*
    -----------------------------------------------------------------------^
        at Object.fromKueryExpression (/Users/jfsiii/work/kibana/src/plugins/data/common/es_query/kuery/ast/ast.ts:52:13)
        at listEnrollmentApiKeys (/Users/jfsiii/work/kibana/x-pack/plugins/fleet/server/services/api_keys/enrollment_api_key.ts:37:69)
        at Object.generateEnrollmentAPIKey (/Users/jfsiii/work/kibana/x-pack/plugins/fleet/server/services/api_keys/enrollment_api_key.ts:166:31)
        at processTicksAndRejections (internal/process/task_queues.js:93:5)
        at postEnrollmentApiKeyHandler (/Users/jfsiii/work/kibana/x-pack/plugins/fleet/server/routes/enrollment_api_key/handler.ts:53:20)
        at Router.handle (/Users/jfsiii/work/kibana/src/core/server/http/router/router.ts:273:30)
        at handler (/Users/jfsiii/work/kibana/src/core/server/http/router/router.ts:228:11)
        at exports.Manager.execute (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
        at Object.internals.handler (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/handler.js:46:20)
        at exports.execute (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/handler.js:31:20)
        at Request._lifecycle (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/request.js:370:32)
        at Request._execute (/Users/jfsiii/work/kibana/node_modules/@hapi/hapi/lib/request.js:279:9) {
      shortMessage: 'Expected AND, OR, end of input but "*" found.'
    ```
    
    So I logged out the query object for a successful request, and put that in a function
    
    ```
    {
      "query": {
        "bool": {
          "filter": [
            {
              "bool": {
                "should": [
                  {
                    "match_phrase": {
                      "policy_id": "d6a93200-b1bd-11eb-90ac-052b474d74cd"
                    }
                  }
                ],
                "minimum_should_match": 1
              }
            },
            {
              "bool": {
                "should": [
                  {
                    "query_string": {
                      "fields": [
                        "name"
                      ],
                      "query": "(with spaces) *"
                    }
                  }
                ],
                "minimum_should_match": 1
              }
            }
          ]
        }
      }
    }
    ```
    
    
    ### Checklist
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    John Schulz authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8c0993b View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    fbe120d View commit details
    Browse the repository at this point in the history
  19. [Security Solutions] Breaks down the io-ts packages to decrease plugi…

    …n size (elastic#100058)
    
    ## Summary
    
    The io-ts package was too large and needed to broken down more by domain to decrease the lists plugin size and any other plugin wanting to use the packages will not incur big hits as well.
    
    Before we had one large io-ts package:
    
    ```
    @kbn/securitysolution-io-ts-utils
    ```
    
    Now we have these broken down 4 packages:
    
    ```
    @kbn/securitysolution-io-ts-utils
    @kbn/securitysolution-io-ts-types
    @kbn/securitysolution-io-ts-alerting-types
    @kbn/securitysolution-io-ts-list-types   
    ```
    
    Deps between these packages are:
    
    ```
    @kbn/securitysolution-io-ts-utils (none)
    @kbn/securitysolution-io-ts-types -> @kbn/securitysolution-io-ts-utils
    @kbn/securitysolution-io-ts-alerting-types -> @kbn/securitysolution-io-ts-types, @kbn/securitysolution-io-ts-utils
    @kbn/securitysolution-io-ts-list-types  -> @kbn/securitysolution-io-ts-types, @kbn/securitysolution-io-ts-utils
    ```
    
    Short description and function of each (Also in each of their README.md):
    
    ```
    @kbn/securitysolution-io-ts-utils, Smallest amount of utilities such as format, validate, etc...
    @kbn/securitysolution-io-ts-types, Base types such as to_number, to_string, etc...
    @kbn/securitysolution-io-ts-alerting-types, Alerting specific types such as severity, from, to, etc...
    @kbn/securitysolution-io-ts-list-types, list specific types such as exception lists, exception list types, etc...
    ```
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    50145ba View commit details
    Browse the repository at this point in the history
  20. Removes circular deps for lists in tooling and bumps down byte limit …

    …for lists (elastic#100082)
    
    ## Summary
    
    * Removes circular deps exception for lists
    * Bumps down byte limit for lists now that we have decreased the page bytes to be under 200kb
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ad4fcd2 View commit details
    Browse the repository at this point in the history
  21. Updates the monorepo-packages list (elastic#100096)

    ## Summary
    
    Updates the monorepo-packages list
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c604ee8 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    aab9806 View commit details
    Browse the repository at this point in the history
  23. Introduce capabilities provider and switcher to file upload plugin (e…

    …lastic#96593)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f2aa5b1 View commit details
    Browse the repository at this point in the history
  24. [Lens] Remove separate mounting point for editor frame to use redux f…

    …reely (elastic#99892)
    
    remove separate mounting point for editor frame
    mbondyra authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    94a1e59 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    e8e0e64 View commit details
    Browse the repository at this point in the history
  26. Disable selection of filter status 'All' on AddToCaseAction (elastic#…

    …99757)
    
    * Fix: Disable selection of filter status 'All' on AddToCaseAction
    
    * UI: Hide disabled statuses on AddToCaseAction
    
    * Refactor: Rename disabledStatuses to hiddenStatuses
    
    * Fix: Pick the first valid status for initialFilterOptions
    
    Previously it was always picking 'open', but it wouldn't work when hiddenStatuses contains "open".
    
    * Add missing test
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    47229f7 View commit details
    Browse the repository at this point in the history
  27. [Alerting] Enabling import of rules and connectors (elastic#99857)

    * [Alerting] Enabling import of rules and connectors
    
    * changed export to set pending executionStatus for rule
    
    * fixed tests
    
    * added docs
    
    * Apply suggestions from code review
    
    Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
    
    * fixed docs
    
    * fixed docs
    
    * Update x-pack/plugins/alerting/server/saved_objects/get_import_warnings.ts
    
    Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
    
    * fixed test
    
    * fixed test
    
    Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    762f378 View commit details
    Browse the repository at this point in the history
  28. Added missing padding to the popover title and footer in 'Test docume…

    …nts' popover (elastic#99921)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d5e53a1 View commit details
    Browse the repository at this point in the history
  29. [Observability] [Exploratory view] update v7 button styles (elastic#1…

    …00113)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9750f38 View commit details
    Browse the repository at this point in the history
  30. Adds error from es call to nodes.info to the nodes version compatibil…

    …ity response message (elastic#100005)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    eeab570 View commit details
    Browse the repository at this point in the history
  31. [Metrics UI] Replace date_histogram with date_range aggregation in th…

    …reshold alert (elastic#100004)
    
    * [Metrics UI] Replace date_histogram with date_range aggregation in threshold alert
    
    * Remove console.log
    
    * Fix rate aggregation and offset
    Zacqary authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    50ac01b View commit details
    Browse the repository at this point in the history
  32. [Docs] fixing KibanaPageTemplate docs (elastic#100104)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a3c7a4e View commit details
    Browse the repository at this point in the history
  33. [APM][RUM] adjust data types for uiFilters and range in APM requests (e…

    …lastic#99257)
    
    * update has_rum_data api query types
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d98feba View commit details
    Browse the repository at this point in the history
  34. [Uptime] Fix overview flaky tests (elastic#99781)

    * add retry logic and add describe.only to prepare for flaky test runner
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    bb645ef View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    30e4902 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    cfa14ca View commit details
    Browse the repository at this point in the history
  37. chore(NA): moving @kbn/i18n into bazel (elastic#99390)

    * chore(NA): moving @kbn/i18n into bazel
    
    * chore(NA): include javascript locales.js files
    
    * chore(NA): remove build scripts
    
    * chore(NA): remove node types on browser
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1a2df55 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    c7b6577 View commit details
    Browse the repository at this point in the history
  39. [index patterns] deprecate IIndexPattern and IFieldType interfaces (e…

    …lastic#100013)
    
    * deprecate IIndexPattern and IFieldType
    
    * update api docs
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    28fd4fe View commit details
    Browse the repository at this point in the history
  40. [Lens] Create managedReference type for formulas (elastic#99729)

    * [Lens] Create managedReference type for formulas
    
    * Fix test failures
    
    * Fix i18n types
    
    * Delete managedReference when replacing
    
    * Tests for formula
    
    * Refactoring from code review
    
    Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
    Co-authored-by: Marco Liberati <marco.liberati@elastic.co>
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    4 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    592a1a6 View commit details
    Browse the repository at this point in the history
  41. [Uptime] Improve accessibility labeling for FilterPopover component (

    …elastic#99714)
    
    * Improve accessibility labeling for `FilterPopover` component.
    
    * Simplify test revisions.
    
    * Simplify unit test.
    
    * Refactor test to use text formatter helper functions.
    justinkambic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e29f4c5 View commit details
    Browse the repository at this point in the history
  42. [App Search] Meta engines schema view (elastic#100087)

    * Set up TruncatedEnginesList component
    
    - Used for listing source engines
    - New in Kibana: now links to source engine schema pages for easier schema fixes!
    
    * Add meta engines schema active fields table
    
    * Render meta engine schema conflicts table & warning callout
    
    * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/schema/components/truncated_engines_list.tsx
    
    Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
    
    Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7ab55f3 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    13e5a18 View commit details
    Browse the repository at this point in the history
  44. [Security Solutions] Removes deprecation and more copied code between…

    … security solutions and lists plugin (elastic#100150)
    
    ## Summary
    
    * Removes deprecations 
    * Removes duplicated code
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a818f14 View commit details
    Browse the repository at this point in the history
  45. [App Search] Allow user to manage source engines through Kibana UX (e…

    …lastic#98866)
    
    * New bulk create route for meta engine source engines
    
    * New delete route for meta engine source engines
    
    * Add removeSourceEngine and onSourceEngineRemove to SourceEnginesLogicActions
    
    * New SourceEnginesTable component
    
    * Use new SourceEnginesTable component in SourceEngines view
    
    * Added closeAddSourceEnginesModal and openAddSourceEnginesModal to SourceEnginesLogic
    
    * New AddSourceEnginesModal component
    
    * New AddSourceEnginesButton component
    
    * Add AddSourceEnginesButton and AddSourceEnginesModal to SourceEngines view
    
    * Allow user to select source engines to add
    
    * Add addSourceEngines and onSourceEnginesAdd to SourceEnginesLogic
    
    * Submit new source engines when user saves from inside AddSourceEnginesModal
    
    * Fix failing tests
    
    * fix i18n
    
    * Fix imports
    
    * Use body instead of query params for source engines bulk create endpoint
    
    * Tests for SouceEnginesLogic actions setIndexedEngines and fetchIndexedEngines
    
    * Re-enabling two skipped tests
    
    * Feedback: move source engine APIs to own file
    
    - We generally organize routes/logic etc. by view, and since this is its own view, it can get its own file
    
    * Misc UI polish
    
    Table:
    - Add EuiPageContent bordered panel (matches Curations & API logs which is a table in a panel)
    - Remove bolding on engine name (matches rest of Kibana UI)
    - Remove responsive false (we do want responsive tables in Kibana)
    
    Modal:
    - Remove EuiOverlayMask - per recent EUI changes, this now comes baked in with EuiModal
    - Change description text to subdued to match other modals (e.g. Curations queries) in Kibana
    
    * Misc i18n/copy tweaks
    
    Modal:
    - Add combobox placeholder text
    - i18n cancel/save buttons
    - inline i18n and change title casing to sentence casing
    
    * Table refactors
    
    - DRY out table columns shared with the main engines tables (title & formatting change slightly from the standalone UI, but this is fine / we should prefer Kibana standardization moving forward)
    - Actions column changes
      - Give it a name - axe will throw issues for table column missing headings
      - Do not make actions a conditional empty array - we should opt to remove the column totally if there is no content present, otherwise screen readers will read out blank cells unnecessarily
      - Switch to icons w/ description tooltips to match the other Kibana tables
    - Remove unnecessary sorting props (we don't have sorting enabled on any columns)
    
    Tests
    - Add describe block for organization
    - Add missing coverage for window confirm branch and canManageMetaEngineSourceEngines branch
    
    * Modal test fixes
    
    - Remove unnecessary type casting
    - Remove commented out line
    - Fix missing onChange function coverage
    
    * Modal: move unmemoized array iterations to Kea selectors
    
    - more performant: kea selectors are memoized
    - cleaner/less logic in views
    - easier to write unit tests for
    
    + rename setSelectedEngineNamesToAdd to onAddEnginesSelection
    + remove unused selectors test code
    
    * Modal: Add isLoading UX to submit button + value renames
    
    - isLoading prevents double clicks/dupe events, and also provides a responsive UX hint that something is happening
    
    - Var renames: there's only one modal on the page, being extra specific with the name isn't really necessary. If we ever add more than one to this view it would probably make sense to split up the logic files or do something else. Verbose modal names/states shouldn't necessarily be the answer
    
    * Source Engines view test fixes
    
    - Remove unused mock values/actions
    - Move constants to within main describe
    - Remove unhappy vs happy path describes - there aren't enough of either scenario to warrant the distinction
    - add page actions describe block and fix skipped/mounted test by shallow diving into EuiPageHeader
    
    * [Misc] Single components/index.ts export
    
    For easier group importing
    
    * Move all copy consts/strings to their own i18n constants file
    
    * Refactor recursive fetchEngines fn to shared util
    
    + update MetaEnginesTableLogic to use new helper/DRY out code
    + write unit tests for just that helper
    + simplify other previous logic checks to just check that the fn was called + add mock
    
    * Tests cleanup
    
    - Move consts into top of describe blocks to match rest of codebase
    - Remove logic comments for files that are only sourcing 1 logic file
    - Modal:
      - shallow is fairly cheap and it's easier / more consistent w/ other tests to start a new wrapper every test
    - Logic:
      - Remove unnecessarily EnginesLogic mocks
      - Remove mount() in beforeEach - it doesn't save us that many extra lines / better to be more consistent when starting tests that mount with values vs not
      - mock clearing in beforeEach to match rest of codebase
      - describe blocks: split up actions vs listeners, move selectors between the two
      - actions: fix tests that are in a describe() but not an it() (incorrect syntax)
      - Reducer/value checks: check against entire values obj to check for regressions or untested reducers & be consistent rest of codebase
      - listeners - DRY out beforeEach of success vs error paths, combine some tests that are a bit repetitive vs just having multiple assertions
    - Logic comments:
      - Remove unnecessary comments (if we're not setting a response, it seems clear we're not using it)
      - Add extra business logic context explanation as to why we call re-initialize the engine
    
    Co-authored-by: Constance Chen <constance.chen.3@gmail.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e4b4fd4 View commit details
    Browse the repository at this point in the history
  46. [Uptime] [Synthetics Integration] update tls passphrase and http pass…

    …word field to use EuiFieldPassword (elastic#100162)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    92ac9b4 View commit details
    Browse the repository at this point in the history
  47. Improve migration perf (elastic#99773)

    * Do not clone state, use TypeCheck it's not mutated
    
    * do not recreate context for every migration
    
    * use more optional semver check
    
    * update SavedObjectMigrationContext type
    
    * add a test model returns new state object
    
    * update docs
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a12d5ff View commit details
    Browse the repository at this point in the history
  48. [Reporting] Added appropriate table caption for table listing generat…

    …ed reports (elastic#100118)
    
    * added appropriate table caption for table listing generated reports
    
    * updated jest snapshot
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3e54c46 View commit details
    Browse the repository at this point in the history
  49. [Ingest pipelines] add support for registered_domain processor (elast…

    …ic#99643)
    
    The Ingest Node Pipelines UI added support to configure a registered domain processor. This processor extracts the registered domain, sub-domain and top-level domain from a fully qualified domain name.
    sabarasaba authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4fef34e View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    438b52a View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    b44c2a7 View commit details
    Browse the repository at this point in the history
  52. skip flaky suite #(95899)

    mistic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8758d8e View commit details
    Browse the repository at this point in the history
  53. skip flaky suite (elastic#100012)

    mistic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6c31fd0 View commit details
    Browse the repository at this point in the history
  54. [Security Solution][Endpoint] Refactor Host Isolation component used …

    …in Isolate use case (elastic#100159)
    
    * EndpointHostIsolateForm component
    * Refactor Detections Host isolation flyout to use isolateform
    paul-tavares authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0e674a5 View commit details
    Browse the repository at this point in the history
  55. [QA] fix dashboard lens by value test (elastic#100196)

    * [functional test] remove redundant navigation, wait for lens to be loaded
    
    * fix navigation to new viz
    
    * update test title
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    68c7227 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    2c03e6b View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    e1304fb View commit details
    Browse the repository at this point in the history
  58. remove non-valid code (elastic#100144)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6a64220 View commit details
    Browse the repository at this point in the history
  59. [Canvas] Fix column object shape in datatable created by CSV function (

    …elastic#98561)
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    28fd918 View commit details
    Browse the repository at this point in the history
  60. [Dashboard] Fixes dashboard_save functional test (elastic#98830)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a641c8b View commit details
    Browse the repository at this point in the history
  61. [kbn/test] move types/ftr into src (elastic#99555)

    * [kbn/test] move types/ftr into src
    
    * Apply eslint updates
    
    * fix import of Lifecycle type
    
    Co-authored-by: spalger <spalger@users.noreply.github.com>
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    3 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4180ad7 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    b461d82 View commit details
    Browse the repository at this point in the history
  63. skip flaky suite (elastic#100236)

    brianseeders authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    52010f4 View commit details
    Browse the repository at this point in the history
  64. [ML] Fixing use_null setting in advanced job wizard (elastic#100028)

    * [ML] Fixing use_null setting in advanced job wizard
    
    * fixing types
    
    * fixing false checks for detector fields
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    125d587 View commit details
    Browse the repository at this point in the history
  65. [Uptime] [Synthetics Integration] Add functional tests for Synthetics…

    … Integration (elastic#100161)
    
    * add functional tests for synthetics fleet package
    dominiqueclarke authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0384134 View commit details
    Browse the repository at this point in the history
  66. [Security Solutions] Replaces most deprecated io-ts alerting and list…

    … types (elastic#100234)
    
    ## Summary
    
    Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as elastic#99260
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2d09e26 View commit details
    Browse the repository at this point in the history
  67. Reduce limits of security solutions to max + 15kb (elastic#100247)

    ## Summary
    
    With recent package changes and fixes we are down to 61kb for page load bundle. General rules are max kilobytes + 15kb for buffer so that would mean we should lower it to be 76kb.
    
    Resolves elastic#95870
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    df6b002 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    4227e03 View commit details
    Browse the repository at this point in the history
  69. Migrate from Joi to @kbn/config-schema in "home" and "features" plugi…

    …ns (elastic#100201)
    
    * add a link for issue to remove circular deps
    
    * features: migrate from joi to config-schema
    
    * update tests
    
    * migrate home tutorials to config-schema
    
    * migrate home dataset validation to config schema
    
    * remove unnecessary type. we cannot guarantee this is a valid SO
    
    * address Pierres comments
    mshustov authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7b289e7 View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    60fa259 View commit details
    Browse the repository at this point in the history
  71. Simplify deleting spaces (elastic#99960)

    * Simplify deleting spaces
    
    * Fixed i18n
    
    * Fix functional tests
    
    * Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx
    
    Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
    
    * Fix snapshots
    
    Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    3 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c2743d6 View commit details
    Browse the repository at this point in the history
  72. [XY axis] Improve expression with explicit params (elastic#98897)

    * Removed visconfig and using explicit params instead in xy_plugin
    
    * Fix CI
    
    * Fix i18n
    
    * Fix unit test
    
    * Fix some remarks
    
    * move expressions into separate chunk
    
    * fix CI
    
    * Update label.ts
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
    3 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    035456a View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    057dc13 View commit details
    Browse the repository at this point in the history
  74. [Timelion] Changes the version of removal message (elastic#100022)

    * Change the version of timelion removal on our documentation and warnings
    
    * Remove translations in order to be revisited
    
    * Remove double
    
    * Update docs/user/dashboard/timelion.asciidoc
    
    Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
    
    * Update src/plugins/timelion/public/components/timelion_deprecation.tsx
    
    Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
    
    * Update src/plugins/timelion/server/deprecations.ts
    
    Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
    
    * Update src/plugins/timelion/server/deprecations.ts
    
    Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
    
    Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    3 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    972e8da View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    93c2b1b View commit details
    Browse the repository at this point in the history
  76. Remove lodash.template from point series visualization (elastic#100207)

    * Remove lodash template from point series visualization
    
    * fix message spacing
    legrego authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a26f718 View commit details
    Browse the repository at this point in the history
  77. Update detection rule telemetry field name. (elastic#100256)

    * Changing variable name of cases_count_daily to cases_count_total.
    
    * Taking comments out of tests and reverting tests to previosu state.
    
    * Changing meta description to be more descriptive.
    
    * Changing meta description to be more descriptive.
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1b96a2f View commit details
    Browse the repository at this point in the history
  78. Remove lodash.template from legacy discover doc table (elastic#99836)

    * remove lodash.template from legacy discover doc table
    
    * fix cell rendering
    
    * remove excess whitespace from rendered output
    
    * adding unit tests
    
    * even more tests
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7a8045a View commit details
    Browse the repository at this point in the history
  79. [Security Solutions][Endpoint] Fixes weird 'flash' when entries does …

    …not exists on event filters page (elastic#100203)
    
    * Fixes weird 'flash' when entries does not exists on event filters page. Also fixes a multilang and query when empty string
    
    * Removes old comment
    
    * Use function to retrieve async resource state
    
    * Fix unit test
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b8937d0 View commit details
    Browse the repository at this point in the history
  80. [Reporting] Switch Mac Chromium to the internally-hosted custom build (

    …elastic#100165) (elastic#100232)
    
    * switch mac chromium download location to kibana team gcs
    
    * oops, fix the path to the binary
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6ba9bb3 View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    c6dd670 View commit details
    Browse the repository at this point in the history
  82. [Security Solutions] Removes commented out "last look back date" code (

    …elastic#100269)
    
    ## Summary
    
    * Removes commented out code which promises we are going to do something past 7.11. This code has been checked in and the column of `last_look_back_date` has been removed since 7.11, which means we haven't had it for 7.11, 7.12, and now 7.13.
    
    Related: elastic#89801
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a42bd37 View commit details
    Browse the repository at this point in the history
  83. [Security Solution] Re-adds a test that was skipped (elastic#100273)

    ## Summary
    
    Re-adds a test that was skipped. If it goes bonkers again, I will add more debugging information to it. I will keep an eye on the operations channel to see when/if this fails again. Originally this looked to be timeouts waiting, so I increased the global timeout to be 20 seconds instead of the original 10 seconds.
    
    Resolves:
    elastic#89389
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2f41a37 View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    a166a9f View commit details
    Browse the repository at this point in the history
  85. Revert "Upgrade accept 3.0.2 and @hapi/accept 5.0.1 to @hapi/accept 5…

    ….0.2 (elastic#100292)"
    
    This reverts commit 025c419.
    watson authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    72dde3e View commit details
    Browse the repository at this point in the history
  86. [dashboard][labs] Defer loading panels below the fold (elastic#99880)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    df99228 View commit details
    Browse the repository at this point in the history
  87. Configuration menu
    Copy the full SHA
    abf2bef View commit details
    Browse the repository at this point in the history
  88. refact(NA): remove extra pkg_npm target and add specific target folde…

    …rs for @kbn/i18n on Bazel (elastic#100271)
    
    * refact(NA): remove extra pkg_npm target and add specific target folders on @kbn/i18n
    
    * chore(NA): override the browser types
    mistic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f013580 View commit details
    Browse the repository at this point in the history
  89. Configuration menu
    Copy the full SHA
    32093be View commit details
    Browse the repository at this point in the history
  90. [Alerting] Refactor alerts authorization client (elastic#99078)

    * WIP - creating alerting authorization client factory and exposing authorization client on plugin start contract
    
    * Updating alerting feature privilege builder to handle different alerting types
    
    * Passing in alerting authorization type to AlertingActions class string builder
    
    * Passing in authorization type in each function call
    
    * Passing in exempt consumer ids. Adding authorization type to audit logger
    
    * Changing alertType to ruleType
    
    * Changing alertType to ruleType
    
    * Updating unit tests
    
    * Updating unit tests
    
    * Passing field names into authorization query builder. Adding kql/es dsl option
    
    * Converting to es query if requested
    
    * Fixing functional tests
    
    * Removing ability to specify feature privilege name in constructor
    
    * Fixing some types and tests
    
    * Consolidating alerting authorization kuery filter options
    
    * Cleanup and tests
    
    * Cleanup and tests
    
    * Throwing error when AlertingAuthorizationClientFactory is not defined
    
    * Renaming authorizationType to entity
    
    * Renaming AlertsAuthorization to AlertingAuthorization
    
    * Fixing unit tests
    
    * Updating privilege string terminology
    
    * Updating privilege string terminology
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7d42c25 View commit details
    Browse the repository at this point in the history
  91. [dev docs] Add sample data tutorial. Closes elastic#98297 (elastic#99252

    )
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f85e37c View commit details
    Browse the repository at this point in the history
  92. [Maps] convert TooltipControl to typescript (elastic#100059)

    * [Maps] convert ToolbarControl to typescript
    
    * fix scss import
    
    * remove unused function from APM map tooltip
    
    * apm tslint
    
    * pass loadFeatureGeometry to renderTooltipContent
    
    * security_solution: pass mbProperties to loadFeatureProperties
    
    * security_solution tslint
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    fb6d0d9 View commit details
    Browse the repository at this point in the history
  93. Configuration menu
    Copy the full SHA
    8b9892d View commit details
    Browse the repository at this point in the history
  94. skip flaky suite (elastic#100296)

    mistic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    517527c View commit details
    Browse the repository at this point in the history
  95. [Screenshot mode] Create plugin to provide "screenshot mode" awareness (

    elastic#99627)
    
    * initial version of the screenshot mode service
    
    * First iteration of client side of screenshot mode plugin
    
    Also hooked it up to the chromium browser imitating the preload
    functionality of electron to set up the environment before
    code runs.
    
    * First implementation of server-side logic for detecting
    screenshot mode
    
    * fix some type issues and do a small refactor
    
    * fix size limits, docs and ts issues
    
    * fixed types issues and made sure screenshot mode is correctly detected on the client
    
    * Moved the screenshot mode header definition to common
    Added a server-side example for screenshot mode
    Export the screenshot mode header in both public and server
    
    * move require() to screenshotMode plugin
    
    * Update chromium_driver.ts
    
    * cleaned up some comments, minor refactor in ReportingCore and
    changed the screenshotmode detection function to check for a
    specific value.
    
    * fix export
    
    * Expanded server-side screenshot mode contract with function that
    checks a kibana request to determine whether we in screenshot
    mode
    
    * added comments to explain use of literal value rather than external reference
    
    * updated comment
    
    * update reporting example
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
    Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
    4 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c91e30d View commit details
    Browse the repository at this point in the history
  96. Ban use of lodash.template (elastic#100277)

    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f78b915 View commit details
    Browse the repository at this point in the history
  97. Configuration menu
    Copy the full SHA
    0b5fd5c View commit details
    Browse the repository at this point in the history
  98. Remove circular dependency between features and security (elastic#100206

    )
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d3cb326 View commit details
    Browse the repository at this point in the history
  99. Configuration menu
    Copy the full SHA
    e7dbfb7 View commit details
    Browse the repository at this point in the history
  100. Configuration menu
    Copy the full SHA
    22eda65 View commit details
    Browse the repository at this point in the history
  101. skip flaky suite (elastic#99581)

    spalger authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2b07209 View commit details
    Browse the repository at this point in the history
  102. skip failing suite (elastic#98351)

    spalger authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9dc2dc0 View commit details
    Browse the repository at this point in the history
  103. Configuration menu
    Copy the full SHA
    2181281 View commit details
    Browse the repository at this point in the history
  104. Configuration menu
    Copy the full SHA
    8e7dab8 View commit details
    Browse the repository at this point in the history
  105. Upgrade functional test fixes (elastic#100306)

    * Upgrade functional test fixes
    
    * Fix lint issues
    liza-mae authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2adae88 View commit details
    Browse the repository at this point in the history
  106. [Dashboard] Embeddable Migrations for By Value Panels (elastic#99715)

    * Implemented embeddable by value migrations
    ThomThomson authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a6d552b View commit details
    Browse the repository at this point in the history
  107. Configuration menu
    Copy the full SHA
    e6e06c5 View commit details
    Browse the repository at this point in the history
  108. Configuration menu
    Copy the full SHA
    f010ddb View commit details
    Browse the repository at this point in the history
  109. [Security Solutions] Re-arranges and adds more packages to remove cop…

    …ied code (elastic#100310)
    
    ## Summary
    
    * Creates a `securitysolution-list-utils` packaged and moves the first set of utilities into there
    * Fixes a slight bug with `kbn-securitysolution-io-ts-list-types` where the wrong name was used
    * Moves _all_ of the lists schemas and types into the package `kbn-securitysolution-io-ts-list-types`
    * Removes copied code found in a few places
    
    ## Tech debt
    * Some spots I have to use an `any` in the package as Kibana kbn packages don't have the types I need
    * Some spots I copy constants until we can straighten out those pieces.
    * I keep copied mock files until we figure out how to share mocks from these packages without adding weight or we create dedicated mock packages for all of this. 
    
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0bbc721 View commit details
    Browse the repository at this point in the history
  110. Configuration menu
    Copy the full SHA
    f82a68b View commit details
    Browse the repository at this point in the history
  111. [QA] update code coverage to use its own script (elastic#100199)

    * do  run build script for code coverage
    
    * fix notifyOnError call
    
    * remove maxWorkers argument
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    20a0750 View commit details
    Browse the repository at this point in the history
  112. Migrate joi to 17.4.0 and adapt the codebase (elastic#99899)

    * bump joi to 17.4.0, start adapting stuff
    
    * remove custom validation rule, adapt instead
    
    * fix error handling
    
    * fix error handling again
    
    * fix strings type & validation
    
    * fix buffers and arrays
    
    * fix bytes
    
    * fix bytes_size type
    
    * update conditional_type error messages in tests
    
    * fix duration and map types
    
    * first attempt to fix union type error messages
    
    * revert conditional type assertions back to master state
    
    * fix object type
    
    * fix record type
    
    * fix stream types
    
    * rename test files to match sources
    
    * fix union type tests
    
    * temporary adapt feature/home usages of Joi
    
    * fix lint
    
    * adapt test assertion
    
    * fix http config schema validation
    
    * fix @kbn/test Config class
    
    * fix config again
    
    * fix reporting schema tests
    
    * fix security solution schema
    
    * adapt url tests
    
    * remove useless comment
    
    * remove space
    
    * typo
    
    * review comments
    pgayvallet authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7a47a67 View commit details
    Browse the repository at this point in the history
  113. remove ui settings client-side validation (elastic#100311)

    * remove ui settings client-side validation
    
    * fix linter
    
    * fix tests
    
    * update generated doc
    pgayvallet authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b854f65 View commit details
    Browse the repository at this point in the history
  114. Configuration menu
    Copy the full SHA
    c4ea9ac View commit details
    Browse the repository at this point in the history
  115. [Reporting] Add logging of CPU usage and memory consumption by Chromi…

    …um (elastic#99109)
    
    * Add logging of CPU usage by chromium
    * Add logging of memory consumption by chromium
    * Add PDF report byte length logging
    * Add PNG report byte length logging
    dokmic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4ed5b36 View commit details
    Browse the repository at this point in the history
  116. Configuration menu
    Copy the full SHA
    7dc77d6 View commit details
    Browse the repository at this point in the history
  117. [Ingest pipelines] fix default paramenter for ignore_missing in csv p…

    …rocessor (elastic#100316)
    
    * fix: set ignoreMissingField to true by default
    * Add missing serializer to trim fieldConfig
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    56f3753 View commit details
    Browse the repository at this point in the history
  118. Configuration menu
    Copy the full SHA
    ff71f75 View commit details
    Browse the repository at this point in the history
  119. Configuration menu
    Copy the full SHA
    9691d5a View commit details
    Browse the repository at this point in the history
  120. Configuration menu
    Copy the full SHA
    cfe4ec4 View commit details
    Browse the repository at this point in the history
  121. Add ML usage collector descriptions to the schema. (elastic#100387)

    * Add ML usage collector descriptions to the schema.
    
    * Update the telemetry mappings file
    pjhampton authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5a7ad24 View commit details
    Browse the repository at this point in the history
  122. Configuration menu
    Copy the full SHA
    afab9be View commit details
    Browse the repository at this point in the history
  123. Fix a bunch of bugs with APIDocs system (elastic#99589)

    * Remove custom code, add in a hack
    
    * remove artifical limit
    
    * Fix arrow functions in interfaces not having children
    
    * Update docs
    
    * Update api docs after merge from master
    
    * update api docs after merge from master
    
    * update api docs
    stacey-gammon authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    190c4f6 View commit details
    Browse the repository at this point in the history
  124. Configuration menu
    Copy the full SHA
    a0683b4 View commit details
    Browse the repository at this point in the history
  125. Adds two more packages and moves files into the packages (elastic#100375

    )
    
    ## Summary
    
    * Adds package `kbn-securitysolution-list-api`
    * Adds package `kbn-securitysolution-list-hooks`
    * Moves files into the packages
    * Moves a few additional types into the other packages such as the `kbn-securitysolution-io-ts-types` package to remove more things from the shard_export/shared_import between lists and security solution
    * Removes more duplicated code
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5525191 View commit details
    Browse the repository at this point in the history
  126. Reduce the lists limits to the current max + 15kb (elastic#100419)

    ## Summary
    
    Reduces the lists limits to the current max + 15kb
    FrankHassanabad authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    57bab18 View commit details
    Browse the repository at this point in the history
  127. [data.search] Add Kibana request to search strategy dependencies (ela…

    …stic#98566)
    
    * [data.search] Add Kibana request to search strategy dependencies
    
    * Don't register internal strategy
    
    * Update docs
    lukasolson authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9d6abee View commit details
    Browse the repository at this point in the history
  128. Configuration menu
    Copy the full SHA
    d20de55 View commit details
    Browse the repository at this point in the history
  129. skip failing suite (elastic#98352)

    spalger authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    65e466c View commit details
    Browse the repository at this point in the history
  130. Configuration menu
    Copy the full SHA
    01ab915 View commit details
    Browse the repository at this point in the history
  131. skip flaky suite (elastic#100445)

    brianseeders authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9822813 View commit details
    Browse the repository at this point in the history
  132. skip flaky suite (elastic#91107)

    mistic authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ddb3cb0 View commit details
    Browse the repository at this point in the history
  133. [Security Solution][Endpoint] Add host isolation action to the endpoi…

    …nt list (elastic#100240)
    
    * Refactor TableRowAction into separate component and enable menu close on item click
    * add `show=isolate` to valid url param string for details panel
    * Reusable BackToEndpointDetailsFlyoutSubHeader component
    * new FlyoutBodyNoTopPadding compoent + refactor Policy response to use it
    * Endpoint Isolate flyout panel
    * New Service for doing isolate/unisolate of hosts
    * Refactor detection isolate API call to use common method from new service
    paul-tavares authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    88350bb View commit details
    Browse the repository at this point in the history
  134. [Alerting] Passing additional rule fields to rule executor (elastic#9…

    …9819)
    
    * Passing additional rule fields to rule executor
    
    * Fixing types check
    
    * Api docs
    
    * Adding enabled and actions
    
    * Api docs
    
    * Encapsulating rule information into RuleConfig type
    
    * Functional tests
    
    * Functional tests
    
    * Adding producer, ruleTypeId and ruleTypeName
    
    * Api docs
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    86a5e31 View commit details
    Browse the repository at this point in the history
  135. security solution and lists to TS incremental builds (elastic#100447)

    * lists to ts incremental builds
    
    * security_solution to ts incremental
    
    * import ResizeObserver explicitly as it is not declared in dom types
    mshustov authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    fd58b0f View commit details
    Browse the repository at this point in the history
  136. [dev_docs] How to build a kibana distributable tutorial (elastic#99827)

    * docs(NA): [dev docs] Add how to build a Kibana distributable tutorial
    
    * docs(NA): including last step about building a kibana distributable tutorial
    
    * docs(NA): add dev docs images
    
    * docs(NA): include image for target folder with os packages and distributable
    
    * docs(NA): apply feedback received on the PR review
    
    * chore(NA): add rpm to brew
    
    * chore(NA): update dev_docs/tutorials/building_a_kibana_distributable.mdx
    
    Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
    
    * chore(NA): update dev_docs/tutorials/building_a_kibana_distributable.mdx
    
    Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
    
    * docs(NA): update docker names to capitalized
    
    Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    3 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d378277 View commit details
    Browse the repository at this point in the history
  137. Configuration menu
    Copy the full SHA
    82d4607 View commit details
    Browse the repository at this point in the history
  138. WIP - creating alerting authorization client factory and exposing aut…

    …horization client on plugin start contract
    ymao1 authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6df4302 View commit details
    Browse the repository at this point in the history
  139. Configuration menu
    Copy the full SHA
    3448950 View commit details
    Browse the repository at this point in the history
  140. Configuration menu
    Copy the full SHA
    5a77ea3 View commit details
    Browse the repository at this point in the history
  141. Configuration menu
    Copy the full SHA
    c24f011 View commit details
    Browse the repository at this point in the history
  142. Configuration menu
    Copy the full SHA
    8f08779 View commit details
    Browse the repository at this point in the history
  143. Updating unit tests

    ymao1 authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b8d85e6 View commit details
    Browse the repository at this point in the history
  144. Configuration menu
    Copy the full SHA
    8243202 View commit details
    Browse the repository at this point in the history
  145. Configuration menu
    Copy the full SHA
    4c24382 View commit details
    Browse the repository at this point in the history
  146. Renaming authorizationType to entity

    ymao1 authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    978892b View commit details
    Browse the repository at this point in the history
  147. Fixing unit tests

    ymao1 authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    79f896d View commit details
    Browse the repository at this point in the history
  148. Updating feature privilege iterator

    ymao1 authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    10a0c58 View commit details
    Browse the repository at this point in the history
  149. Configuration menu
    Copy the full SHA
    d5619a7 View commit details
    Browse the repository at this point in the history
  150. Configuration menu
    Copy the full SHA
    c24aed0 View commit details
    Browse the repository at this point in the history
  151. Configuration menu
    Copy the full SHA
    f76be7e View commit details
    Browse the repository at this point in the history
  152. Configuration menu
    Copy the full SHA
    e5af2e8 View commit details
    Browse the repository at this point in the history
  153. Configuration menu
    Copy the full SHA
    087dc35 View commit details
    Browse the repository at this point in the history
  154. WIP - re-add update function to alerts as data client (#13)

    * WIP - creating alerting authorization client factory and exposing authorization client on plugin start contract
    
    * Updating alerting feature privilege builder to handle different alerting types
    
    * Converting to es query if requested
    
    * first pass at getting everything working again
    
    * working update function
    
    * fix rebase conflicts
    
    * fixes index mapping to add owner field
    
    * fixes update route, previously using wrong ruleTypeId and not building the correct index
    
    * fix getIndex function
    
    Co-authored-by: Ying Mao <ying.mao@elastic.co>
    2 people authored and yctercero committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5170468 View commit details
    Browse the repository at this point in the history
  155. Configuration menu
    Copy the full SHA
    690f66c View commit details
    Browse the repository at this point in the history
  156. Configuration menu
    Copy the full SHA
    dc0b04b View commit details
    Browse the repository at this point in the history
  157. setup integration tests

    angorayc committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e35d5c8 View commit details
    Browse the repository at this point in the history
  158. add more test cases

    angorayc committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8b6e441 View commit details
    Browse the repository at this point in the history
  159. add mock alert data

    angorayc committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5718037 View commit details
    Browse the repository at this point in the history