Merge #27
Merged
Merge #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore:(rds):Fix README rds.Login was deprecated ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…tition (#10637) Creating a CodeBuild project with vpc attachment creates and attaches a policy to the IAM role with static resource arn that does not reference `AWS::Partition` - this breaks compatibility with GovCloud. fixes #10634 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…clone urls (#10639) As a CDK User I expect Repository.fromRepositoryArn to use the region given when building the repository clone urls. Prior to this commit, a stack deploy in us-east-1, would return clone urls for us-east-1 even if given an ARN for us-west-2. Fixes #10630 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
* feat: cloudformation spec v18.5.0 * patching the StepFunctions Activity property Name as it was an unintended spec change. Co-authored-by: AWS CDK Team <aws-cdk@amazon.com> Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: fix yml indent issue * remove name quotes per review
Closes #10229 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
I ran into a cycle issue and tried to use find-cycles to diagnose it; unfortunately, it wasn't Python 3-compatible. A quick update makes it work for either Python 2 or 3. Apologies for the extra noise -- I've got my editor to automatically delete trailing whitespace. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
remove duplicated entries from previous release
…ally (#10657) In a last-minute change, the secret was changed from public (matching all of the other RDS constructs) to private. This means users who don't specify a secret, and rely on the auto-generated one, have no programmatic means of accessing the secret. Brought up by a user on the CDK.dev Slack channel. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fix incorrect s3 prefix used for grant* in Table closes #10582 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fix `glue:GetTableVersion` permission not available for read closes #10577 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I'm not sure how the docs got rolledback, but `arnForObjects` behavior was changed in 5ac6e77. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
With all of CDK construct libraries in the repo migrated[1],[2],[3] to use "constructs" module, finally move "core" module also to use the same pattern. [1]: c179699 [2]: 60c782f [3]: a76428b ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#10691) `InitCommand.shellCommand('abc xyz')` renders to `['abc xyz']` which actually represents an `argv` command of one element, which is treated differently. For example, spaces in it are not parsed, which would be expected for a shell command. The correct rendering for a shell command is a plain string in the `command` property. Fixes #10684. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
If they are left out, they render as `undefined` which is definitely not what's intended. What's worse, this behavior was even encoded into our unit tests `>_<`. Fixes #10687. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Fixes #3033
Cache asset hashes. This avoids file system and bundling operations when the same asset with the same configuration is used in multiple stacks in an app. Closes #9424 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#10697) Both the HealthyHostCount and UnHealthyHostCount metrics require the TargetGroup as a dimension, in addition to the LoadBalancer dimension. The current `NetworkLoadBalancer.metric(Un)HealthyHostCount` methods don't account for this, and return broken metrics. The methods can't even be properly fixed to do the right thing, because the proper solution results in one metric per TargetGroup, whereas the current signature returns a single `IMetric`. Moving the metrics to the TargetGroup will provide a way to get at these metrics. fixes #5046 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…lic references (#10696) An S3Origin creates an OriginAccessIdentity, and grants that identity read permissions on the bucket. This creates cyclic references when the bucket is located in a different stack than the distribution. The bucket has a dependency on the generated OAI user for the BucketPolicy, and the Distribution has a dependency on the bucket's domain name for the origin. The fix detects a cross-stack bucket and re-parents the OAI in the bucket's stack to prevent cyclic references. fixes #10399
This warning was added to detect an inability to add the metadata resource in the CLI, before the framework started emitting the metadata resource by default. Now it's expected, and the warning doesn't make any sense anymore. Fixes #10625. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#10690) Even though this is arguably somewhat of an antipattern and user error: - You should not be vending `Stack`s from libraries. - All libraries should be using a single version of the CDK so that NPM can dedupe it (or use `peerDependencies` to avoid this altogether) This is still a sharp edge that we can blunt a little by not using the `instanceof` language feature. No test because it needs a second copy of the CDK to expose it. Fixes #10671. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Print the build times for all packages, irrespective of their success or failure. The motivation is to gather package build times and their contribution to the total build time of the repo. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Shift community chat from Gitter to the cdk.dev Slack workspace ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#10698) Switching all tests and test utilities to use the "constructs" module as preparation for v2 branch. As part of CDKv2, the construct compat layer in the "@aws-cdk/core" module will be removed. This change pre-migrates tests to the new module so as to reduce code divergence between the 'v1' and 'v2' code branches. This will in turn reduce the number of merge conflicts when changes are forward merged from the 'v1' branch onto the 'v2' branch. This change also adds a new private tools module - eslint-plugin-cdk - where CDK specific eslint rules can be added. The first rule now is to ensure that tests and test related utilities do not use the construct compat layer. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license