-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge #27
Merge #27
Commits on Oct 1, 2020
-
chore(rds): readme touchups (#10626)
chore:(rds):Fix README rds.Login was deprecated ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for c908c7b - Browse repository at this point
Copy the full SHA c908c7bView commit details -
fix(codebuild): permissions for Project in VPC used incorrect AWS par…
…tition (#10637) Creating a CodeBuild project with vpc attachment creates and attaches a policy to the IAM role with static resource arn that does not reference `AWS::Partition` - this breaks compatibility with GovCloud. fixes #10634 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for b207888 - Browse repository at this point
Copy the full SHA b207888View commit details -
fix(codecommit): use region given in fromRepositoryArn when creating …
…clone urls (#10639) As a CDK User I expect Repository.fromRepositoryArn to use the region given when building the repository clone urls. Prior to this commit, a stack deploy in us-east-1, would return clone urls for us-east-1 even if given an ARN for us-west-2. Fixes #10630 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 934553c - Browse repository at this point
Copy the full SHA 934553cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54375a6 - Browse repository at this point
Copy the full SHA 54375a6View commit details
Commits on Oct 2, 2020
-
feat(cfnspec): cloudformation spec v18.5.0 (#10636)
* feat: cloudformation spec v18.5.0 * patching the StepFunctions Activity property Name as it was an unintended spec change. Co-authored-by: AWS CDK Team <aws-cdk@amazon.com> Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e99cf63 - Browse repository at this point
Copy the full SHA e99cf63View commit details -
chore: fix yml indent issue (#10643)
* chore: fix yml indent issue * remove name quotes per review
Configuration menu - View commit details
-
Copy full SHA for bc096f0 - Browse repository at this point
Copy the full SHA bc096f0View commit details -
docs(lambda-python): error in documented example (#10254)
Closes #10229 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 69c9c73 - Browse repository at this point
Copy the full SHA 69c9c73View commit details -
chore: npm-check-updates && yarn upgrade (#10499)
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
Configuration menu - View commit details
-
Copy full SHA for 1fc1ab1 - Browse repository at this point
Copy the full SHA 1fc1ab1View commit details -
chore: update find-cycles to work with Python 2 or 3 (#10428)
I ran into a cycle issue and tried to use find-cycles to diagnose it; unfortunately, it wasn't Python 3-compatible. A quick update makes it work for either Python 2 or 3. Apologies for the extra noise -- I've got my editor to automatically delete trailing whitespace. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for af2e8ff - Browse repository at this point
Copy the full SHA af2e8ffView commit details -
AWS CDK Team committed
Oct 2, 2020 Configuration menu - View commit details
-
Copy full SHA for 5e0456b - Browse repository at this point
Copy the full SHA 5e0456bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2e84ab - Browse repository at this point
Copy the full SHA c2e84abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 459488d - Browse repository at this point
Copy the full SHA 459488dView commit details
Commits on Oct 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 86e6c12 - Browse repository at this point
Copy the full SHA 86e6c12View commit details -
fix(rds): secret for ServerlessCluster is not accessible programmatic…
…ally (#10657) In a last-minute change, the secret was changed from public (matching all of the other RDS constructs) to private. This means users who don't specify a secret, and rely on the auto-generated one, have no programmatic means of accessing the secret. Brought up by a user on the CDK.dev Slack channel. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 028495e - Browse repository at this point
Copy the full SHA 028495eView commit details -
fix(glue): incorrect s3 prefix used for grant* in Table (#10627)
Fix incorrect s3 prefix used for grant* in Table closes #10582 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 4d20079 - Browse repository at this point
Copy the full SHA 4d20079View commit details -
fix(glue): GetTableVersion permission not available for read (#10628)
Fix `glue:GetTableVersion` permission not available for read closes #10577 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for b0c5699 - Browse repository at this point
Copy the full SHA b0c5699View commit details -
chore(s3): arnForObjects docstring refers to wrong signature (#10658)
I'm not sure how the docs got rolledback, but `arnForObjects` behavior was changed in 5ac6e77. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for dd543d1 - Browse repository at this point
Copy the full SHA dd543d1View commit details
Commits on Oct 4, 2020
-
chore(core): migrate constructs to use "constructs" module (#10655)
With all of CDK construct libraries in the repo migrated[1],[2],[3] to use "constructs" module, finally move "core" module also to use the same pattern. [1]: c179699 [2]: 60c782f [3]: a76428b ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredOct 4, 2020 Configuration menu - View commit details
-
Copy full SHA for 92080a2 - Browse repository at this point
Copy the full SHA 92080a2View commit details
Commits on Oct 5, 2020
-
chore(java): JUnit 4.12 -> JUnit 4.13 (#10670)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 9e11e5a - Browse repository at this point
Copy the full SHA 9e11e5aView commit details -
chore: move 'core' tests to jest via nodeunit-shim (#10661)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 63088e1 - Browse repository at this point
Copy the full SHA 63088e1View commit details -
fix(ec2):
InitCommand.shellCommand()
renders an argv command instead (#10691) `InitCommand.shellCommand('abc xyz')` renders to `['abc xyz']` which actually represents an `argv` command of one element, which is treated differently. For example, spaces in it are not parsed, which would be expected for a shell command. The correct rendering for a shell command is a plain string in the `command` property. Fixes #10684. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for de9d2f7 - Browse repository at this point
Copy the full SHA de9d2f7View commit details -
fix(ec2):
addExecuteFileCommand
arguments cannot be omitted (#10692)If they are left out, they render as `undefined` which is definitely not what's intended. What's worse, this behavior was even encoded into our unit tests `>_<`. Fixes #10687. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 7178374 - Browse repository at this point
Copy the full SHA 7178374View commit details -
fix(ec2): memory optimised graviton2 instance type (#10615)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for a72cfbd - Browse repository at this point
Copy the full SHA a72cfbdView commit details -
fix(cli):
cdk context --reset <number>
does not work (#10619)*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Fixes #3033
Configuration menu - View commit details
-
Copy full SHA for 3f62752 - Browse repository at this point
Copy the full SHA 3f62752View commit details -
chore(core): cache asset hashes (#10478)
Cache asset hashes. This avoids file system and bundling operations when the same asset with the same configuration is used in multiple stacks in an app. Closes #9424 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 317d9cf - Browse repository at this point
Copy the full SHA 317d9cfView commit details -
fix(elbv2): metric(Un)HealthyHostCount don't use TargetGroup dimension (
#10697) Both the HealthyHostCount and UnHealthyHostCount metrics require the TargetGroup as a dimension, in addition to the LoadBalancer dimension. The current `NetworkLoadBalancer.metric(Un)HealthyHostCount` methods don't account for this, and return broken metrics. The methods can't even be properly fixed to do the right thing, because the proper solution results in one metric per TargetGroup, whereas the current signature returns a single `IMetric`. Moving the metrics to the TargetGroup will provide a way to get at these metrics. fixes #5046 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 9444399 - Browse repository at this point
Copy the full SHA 9444399View commit details -
fix(cloudfront-origins): S3Origins with cross-stack buckets cause cyc…
…lic references (#10696) An S3Origin creates an OriginAccessIdentity, and grants that identity read permissions on the bucket. This creates cyclic references when the bucket is located in a different stack than the distribution. The bucket has a dependency on the generated OAI user for the BucketPolicy, and the Distribution has a dependency on the bucket's domain name for the origin. The fix detects a cross-stack bucket and re-parents the OAI in the bucket's stack to prevent cyclic references. fixes #10399
Configuration menu - View commit details
-
Copy full SHA for 0ec4588 - Browse repository at this point
Copy the full SHA 0ec4588View commit details -
fix(cli): 'stack already contains Metadata resource' warning (#10695)
This warning was added to detect an inability to add the metadata resource in the CLI, before the framework started emitting the metadata resource by default. Now it's expected, and the warning doesn't make any sense anymore. Fixes #10625. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for e0b5508 - Browse repository at this point
Copy the full SHA e0b5508View commit details -
fix(core): Stacks from 3rd-party libraries do not synthesize correctly (
#10690) Even though this is arguably somewhat of an antipattern and user error: - You should not be vending `Stack`s from libraries. - All libraries should be using a single version of the CDK so that NPM can dedupe it (or use `peerDependencies` to avoid this altogether) This is still a sharp edge that we can blunt a little by not using the `instanceof` language feature. No test because it needs a second copy of the CDK to expose it. Fixes #10671. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for 7bb5cf4 - Browse repository at this point
Copy the full SHA 7bb5cf4View commit details -
chore(cdk-build-tools): print build times for all packages (#10681)
Print the build times for all packages, irrespective of their success or failure. The motivation is to gather package build times and their contribution to the total build time of the repo. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredOct 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 3da6420 - Browse repository at this point
Copy the full SHA 3da6420View commit details -
feat(readme): deprecate Gitter in favor of cdk.dev Slack (#10700)
Shift community chat from Gitter to the cdk.dev Slack workspace ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Elad Ben-Israel authoredOct 5, 2020 Configuration menu - View commit details
-
Copy full SHA for c60764e - Browse repository at this point
Copy the full SHA c60764eView commit details -
chore: migrate all tests off compat layer and use "constructs" module (…
…#10698) Switching all tests and test utilities to use the "constructs" module as preparation for v2 branch. As part of CDKv2, the construct compat layer in the "@aws-cdk/core" module will be removed. This change pre-migrates tests to the new module so as to reduce code divergence between the 'v1' and 'v2' code branches. This will in turn reduce the number of merge conflicts when changes are forward merged from the 'v1' branch onto the 'v2' branch. This change also adds a new private tools module - eslint-plugin-cdk - where CDK specific eslint rules can be added. The first rule now is to ensure that tests and test related utilities do not use the construct compat layer. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Niranjan Jayakar authoredOct 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 3cbb863 - Browse repository at this point
Copy the full SHA 3cbb863View commit details -
fix(codepipeline-actions): correctly name the triggering Event in Cod…
Configuration menu - View commit details
-
Copy full SHA for ff3a692 - Browse repository at this point
Copy the full SHA ff3a692View commit details