Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v24.5 #4289

Merged
merged 603 commits into from
Jul 26, 2024
Merged

Release v24.5 #4289

merged 603 commits into from
Jul 26, 2024
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Apr 11, 2024

  1. update tests

    @rtimms
    rtimms committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6f93f00 View commit details
    Browse the repository at this point in the history

  2. LLI comment

    @rtimms
    rtimms committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6a3d93c View commit details
    Browse the repository at this point in the history

  3. Use Python-3.12 compatible pybind11 to fix benchmarks (#3996)

    @agriyakhetarpal
    agriyakhetarpal authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    86ac0e0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into ImproveDoucmentation

    @kratman
    kratman authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0249930 View commit details
    Browse the repository at this point in the history

  5. docs: update all_contributors.md [skip ci]

    @allcontributors
    allcontributors[bot] authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    79a0246 View commit details
    Browse the repository at this point in the history

  6. docs: update .all-contributorsrc [skip ci]

    @allcontributors
    allcontributors[bot] authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    012118e View commit details
    Browse the repository at this point in the history

  7. Merge pull request #3986 from AndyLiuElysia/ImproveDoucmentation 

    update Arg pybamm.Experiment.period
    @valentinsulzer
    valentinsulzer authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    937630f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into all-contributors/add-AndyLiuElysia

    @valentinsulzer
    valentinsulzer authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    11f9f99 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. add functions for normal cdf and pdf

    @valentinsulzer
    valentinsulzer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    cfe081f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3998 from pybamm-team/all-contributors/add-AndyLi… 

    …uElysia

docs: add AndyLiuElysia as a contributor for doc
    @valentinsulzer
    valentinsulzer authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4cf09f3 View commit details
    Browse the repository at this point in the history

  3. docs and changelog

    @valentinsulzer
    valentinsulzer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    582f33f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into normal-cdf

    @valentinsulzer
    valentinsulzer authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ff97a18 View commit details
    Browse the repository at this point in the history

  5. Fix upwind/downwind finite volume operators (#3979) 

    * #3526 initialise branch

* #3256 add UpwindDivergence and DownwindDivergence

* work in progress for fixing upwind scheme

* #3526 add missing argument docstring

* #3526 fix upwind/downwind methods

* style: pre-commit fixes

* #3526 get finite volume notebook from develop

* 3526 add temporary test

* ruff

* style: pre-commit fixes

* #3526 remove unused variable

* #3526 clarify wording

* #3526 fix tests

* #3526 add to CHANGELOG

* #3526 update coverage

* #3526 add integration test

* style: pre-commit fixes

* #3526 remove example for debugging

* Remove print for debug

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* #3526 add second test

* #3526 generalised example but did not add test as was hard to know what to measure

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
    @brosaplanella @pre-commit-ci
    @kratman @valentinsulzer
    4 people authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d764a18 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into normal-cdf

    @valentinsulzer
    valentinsulzer authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9fcd56b View commit details
    Browse the repository at this point in the history

  7. Merge pull request #3999 from pybamm-team/normal-cdf 

    Add normal pdf and cdf functions
    @valentinsulzer
    valentinsulzer authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    51c1f76 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' of github.com:kratman/PyBaMM into feat/removeRMSE

    @kratman
    kratman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    734b8a0 View commit details
    Browse the repository at this point in the history

  9. Put back comments and remove unused code

    @kratman
    kratman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    62fdd5f View commit details
    Browse the repository at this point in the history

  10. Merge pull request #3988 from kratman/feat/removeRMSE 

    Remove RMSE function
    @valentinsulzer
    valentinsulzer authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ce602d6 View commit details
    Browse the repository at this point in the history

  11. Add return type documentation for util.have_jax() and is_jax_compatib… 

    …le() (#4005)

* add return type for util.have_jax() and is_jax_compatible()

* add description

* Update pybamm/util.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @raghuramshankar @kratman @agriyakhetarpal
    3 people authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8cd1cec View commit details
    Browse the repository at this point in the history

  12. Update multiprocessing context to be Pool specific (#4001) 

    * convert global start context to individual pool context

* Update context creation, add tests for coverage

---------

Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @BradyPlanden @valentinsulzer @kratman
    3 people authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    09ee982 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Merge branch 'develop' into basic-experiments

    @arjxn-py
    arjxn-py authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    5978ec1 View commit details
    Browse the repository at this point in the history

  2. Fix optional dependencies error detection and remove pybtex hidden … 

    …dependency (#3968)

* Edit pybamm import test

* Guard pybtex imports

* Update pybamm/citations.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update pybamm/citations.py (1)

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update pybamm/citations.py (2)

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update pybamm/citations.py (3)

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update contributing guidelines

* Exclude excepts from test coverage

* style: pre-commit fixes

---------

Co-authored-by: Lorenzo Favaro <lorenzofavaro@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @lorenzofavaro @agriyakhetarpal
    @pre-commit-ci @kratman @arjxn-py
    6 people authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    9f8b361 View commit details
    Browse the repository at this point in the history

  3. Reduced the number of docker images by one pybamm:latest (#3992) 

    * reduced the image to one

* removed build time args and multiple image builds

* removed optional solvers from docker docs

* Apply suggestions from code review

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* code review suggestions

* added breaking change to changelog.md

* Update CHANGELOG.md

* Apply suggestions from code review

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @santacodes @agriyakhetarpal @arjxn-py
    3 people authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    2454c38 View commit details
    Browse the repository at this point in the history

  4. docs: add lorenzofavaro as a contributor for doc (#3976) 

    * docs: update all_contributors.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @allcontributors @kratman
    @arjxn-py @agriyakhetarpal
    4 people authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    6b5f5b7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into basic-experiments

    @rtimms
    rtimms authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    1b814b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Bump codecov/codecov-action from 4.2.0 to 4.3.0 in the actions group (#… 

    …4011)

Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `codecov/codecov-action` from 4.2.0 to 4.3.0
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.2.0...v4.3.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7f632a6 View commit details
    Browse the repository at this point in the history

  2. chore: update pre-commit hooks (#4012) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.3.7](astral-sh/ruff-pre-commit@v0.3.5...v0.3.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    cf09d5e View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. add citations

    @mleot
    mleot committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7d4aa19 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2463e2a View commit details
    Browse the repository at this point in the history

  3. remove unessesary citation

    @mleot
    mleot committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1bcb524 View commit details
    Browse the repository at this point in the history

  4. passes all unit tests

    @mleot
    mleot committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3e89fb4 View commit details
    Browse the repository at this point in the history

  5. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    27e075f View commit details
    Browse the repository at this point in the history

  6. move Q from lithium ion function to submodel coupled variable

    @mleot
    mleot committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2e7d81b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'plett-ocp-hysteresis' of https://github.com/mleot/pybamm … 

    …into pr/mleot/3593
    @mleot
    mleot committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5ae648b View commit details
    Browse the repository at this point in the history

  8. clean up changes

    @mleot
    mleot committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e2fa1ed View commit details
    Browse the repository at this point in the history

  9. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9b0a4aa View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e37031c View commit details
    Browse the repository at this point in the history

  11. remove default summary variables

    @rtimms
    rtimms committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    64ade63 View commit details
    Browse the repository at this point in the history

  12. Use unique artifact names (#4015) 

    * #3489 Use unique artifact names for all jobs

* Limit benchmarks results to PyBaMM repo
    @agriyakhetarpal
    agriyakhetarpal authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b0bc5cf View commit details
    Browse the repository at this point in the history

  13. merge dev

    @rtimms
    rtimms committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c6ad4c1 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'develop' into basic-experiments

    @rtimms
    rtimms authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3faa2a8 View commit details
    Browse the repository at this point in the history

  15. change remove independent variables setting to False by default

    @valentinsulzer
    valentinsulzer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    156c95b View commit details
    Browse the repository at this point in the history

  16. #4018 check indepedent vars in events (#4019) 

    * #4018 check indepedent vars in events

* #4018 changelog
    @rtimms
    rtimms authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    51c4120 View commit details
    Browse the repository at this point in the history

  17. changelog

    @valentinsulzer
    valentinsulzer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3b07404 View commit details
    Browse the repository at this point in the history

  18. merge develop

    @valentinsulzer
    valentinsulzer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0dae324 View commit details
    Browse the repository at this point in the history

  19. add test with Simulation for coverage

    @valentinsulzer
    valentinsulzer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    637c988 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. working example notebook and temporary revert to dQ as a function

    @mleot
    mleot committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2ed9dea View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c4f96c6 View commit details
    Browse the repository at this point in the history

  3. revert to functional form of Q

    @mleot
    mleot committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5fd1555 View commit details
    Browse the repository at this point in the history

  4. add plot_thermal_components

    @valentinsulzer
    valentinsulzer committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d93eca1 View commit details
    Browse the repository at this point in the history

  5. moved lumped cooling to lumped and isothermal models only

    @valentinsulzer
    valentinsulzer committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    61bc39b View commit details
    Browse the repository at this point in the history

  6. renaming to dchs

    @mleot
    mleot committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    957755e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3324f40 View commit details
    Browse the repository at this point in the history

  8. clean up

    @mleot
    mleot committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d0be637 View commit details
    Browse the repository at this point in the history

  9. coverage

    @valentinsulzer
    valentinsulzer committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    db295b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. update docs build script

    @mleot
    mleot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c2825aa View commit details
    Browse the repository at this point in the history

  2. update notebook

    @mleot
    mleot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a16283a View commit details
    Browse the repository at this point in the history

  3. compatabilize composite model

    @mleot
    mleot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    cc64fb4 View commit details
    Browse the repository at this point in the history

  4. add test

    @mleot
    mleot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7952dbd View commit details
    Browse the repository at this point in the history

  5. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0ad1869 View commit details
    Browse the repository at this point in the history

  6. remove unessesary statements

    @mleot
    mleot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9e46865 View commit details
    Browse the repository at this point in the history

  7. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    746f811 View commit details
    Browse the repository at this point in the history

  8. remove unused

    @mleot
    mleot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e9dd55f View commit details
    Browse the repository at this point in the history

  9. Merge pull request #4021 from pybamm-team/plot-thermal-components 

    add plot_thermal_components
    @valentinsulzer
    valentinsulzer authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5d22165 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' into change-remove-independent-vars-default

    @valentinsulzer
    valentinsulzer committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a64e8bd View commit details
    Browse the repository at this point in the history

  11. merge develop, changelog

    @valentinsulzer
    valentinsulzer committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e07223d View commit details
    Browse the repository at this point in the history

  12. Removed plating parameters from Chen2020_composite.py

    DrSOKane committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b8c6b80 View commit details
    Browse the repository at this point in the history

  13. changelog

    DrSOKane committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d3aa566 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    4f8bbbc View commit details
    Browse the repository at this point in the history

  15. Merge pull request #4020 from pybamm-team/change-remove-independent-v… 

    …ars-default

change remove independent variables setting to False by default
    @valentinsulzer
    valentinsulzer authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    90c1c35 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. chore: update pre-commit hooks (#4033) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.3.7 → v0.4.1](astral-sh/ruff-pre-commit@v0.3.7...v0.4.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c0ff64f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Display a warning for individual notebook pages on latest versions of… 

    … the documentation (#4038)

* Append admonition to raise warning on latest docs

See #4034 and #4035.

* Update attention admonition sentence

Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>

* style: pre-commit fixes

---------

Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @agriyakhetarpal @valentinsulzer @pre-commit-ci
    3 people authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4189099 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …composite-plating
    DrSOKane committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4d06006 View commit details
    Browse the repository at this point in the history

  2. quick fix for the slow test (#4039) 

    Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @valentinsulzer @kratman
    valentinsulzer and kratman authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    44d946f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …composite-plating
    DrSOKane committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    094518e View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Enable testing on 3.8 and 3.9 for macOS arm64 (#4041)

    @agriyakhetarpal
    agriyakhetarpal authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    43ca3de View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …composite-plating
    DrSOKane committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ee445c3 View commit details
    Browse the repository at this point in the history

  2. chore: update pre-commit hooks (#4053) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1bc2a9d View commit details
    Browse the repository at this point in the history

  3. Bump lycheeverse/lychee-action from 1.9.3 to 1.10.0 in the actions gr… 

    …oup (#4052)

Bumps the actions group with 1 update: [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action).


Updates `lycheeverse/lychee-action` from 1.9.3 to 1.10.0
- [Release notes](https://github.com/lycheeverse/lychee-action/releases)
- [Commits](lycheeverse/lychee-action@v1.9.3...v1.10.0)

---
updated-dependencies:
- dependency-name: lycheeverse/lychee-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @dependabot @kratman
    dependabot[bot] and kratman authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    741d8cd View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. switch thermal to cumulative heating

    @valentinsulzer
    valentinsulzer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1297383 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    69beb4e View commit details
    Browse the repository at this point in the history

  3. fix test

    @valentinsulzer
    valentinsulzer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1a5c4e4 View commit details
    Browse the repository at this point in the history

  4. pre-compatibilize psd+composite electrode model

    @mleot
    mleot committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d379fb7 View commit details
    Browse the repository at this point in the history

  5. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    00a2e8e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Bump to v24.5rc0

    @Saransh-cpp
    Saransh-cpp committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f66db40 View commit details
    Browse the repository at this point in the history

  2. merge develop

    @rtimms
    rtimms committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a3c5e5d View commit details
    Browse the repository at this point in the history

  3. dont add eqns for discharge and throughput capacity in experiment ste… 

    …p set up
    @rtimms
    rtimms committed May 1, 2024
    Configuration menu
    Copy the full SHA
    75f2a6d View commit details
    Browse the repository at this point in the history

  4. revert example

    @rtimms
    rtimms committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0aeec78 View commit details
    Browse the repository at this point in the history

  5. remove test files

    @rtimms
    rtimms committed May 1, 2024
    Configuration menu
    Copy the full SHA
    44c51d3 View commit details
    Browse the repository at this point in the history

  6. add discharge capacity to BasicDFNHalfCell

    @rtimms
    rtimms committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c438575 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #4054 from pybamm-team/thermal-components 

    switch thermal component plot to cumulative heating
    @valentinsulzer
    valentinsulzer authored May 1, 2024
    Configuration menu
    Copy the full SHA
    96ba50c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …composite-plating
    DrSOKane committed May 2, 2024
    Configuration menu
    Copy the full SHA
    24fd991 View commit details
    Browse the repository at this point in the history

  2. Fix Lychee link failures from stack overflow (#3989) 

    * Starting to fix the link checks

* Remove remaining links

* style: pre-commit fixes

* Remove last link

* style: pre-commit fixes

* Minor comment fixes

* Code review fixes

* Code review fix

* Remove keras link

* Update .github/ISSUE_TEMPLATE/bug_report.yml

Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>

* Fix pre-commit

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
    @kratman @pre-commit-ci
    @arjxn-py @valentinsulzer
    4 people authored May 2, 2024
    Configuration menu
    Copy the full SHA
    1df87ec View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into composite-plating

    @valentinsulzer
    valentinsulzer authored May 2, 2024
    Configuration menu
    Copy the full SHA
    4e6b16f View commit details
    Browse the repository at this point in the history

  4. update notebook name

    @mleot
    mleot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8ad8214 View commit details
    Browse the repository at this point in the history

  5. rename to Wycisk from DCHS

    @mleot
    mleot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2f947d9 View commit details
    Browse the repository at this point in the history

  6. update parameters required & names

    @mleot
    mleot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9566f50 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/develop' into pr/mleot/3593

    @mleot
    mleot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    57240b8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored May 2, 2024
    Configuration menu
    Copy the full SHA
    ca414cb View commit details
    Browse the repository at this point in the history

  9. Merge branch 'plett-ocp-hysteresis' of https://github.com/mleot/pybamm … 

    …into pr/mleot/3593
    @mleot
    mleot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    668c5fe View commit details
    Browse the repository at this point in the history

  10. change if statement for code cov

    @mleot
    mleot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    eb2fe95 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #3919 from DrSOKane/composite-plating 

    Lithium plating upgrades
    @valentinsulzer
    valentinsulzer authored May 2, 2024
    Configuration menu
    Copy the full SHA
    33371b0 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Make get_spatial_var private (#3755) 

    * Make `get_spatial_var` private `quick_plot.py`

* Remove round brackets around optional keyword in `QuickPlot.create_gif`

* Make Args in `dynamic_plot` optional

* Document dynamic arg in `pybamm.QuickPlot.plot`

* Add `get_spatial_var` info in `breaking changes` inside `CHANGELOG.md`

---------

Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @Akhil-Sharma30 @rtimms @kratman
    3 people authored May 3, 2024
    Configuration menu
    Copy the full SHA
    febf1ac View commit details
    Browse the repository at this point in the history

  2. add docs

    @mleot
    mleot committed May 3, 2024
    Configuration menu
    Copy the full SHA
    647be7b View commit details
    Browse the repository at this point in the history

  3. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ec466f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored May 3, 2024
    Configuration menu
    Copy the full SHA
    6cab440 View commit details
    Browse the repository at this point in the history

  5. update toctree

    @mleot
    mleot committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e72f799 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. add to changelog

    @mleot
    mleot committed May 5, 2024
    Configuration menu
    Copy the full SHA
    f02551e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. CasADi 3.6.5 (#4063) 

    * Update vcpkg baseline

* Bump CasADi to minimum 3.6.5, both build and run
    @agriyakhetarpal
    agriyakhetarpal authored May 6, 2024
    Configuration menu
    Copy the full SHA
    2496688 View commit details
    Browse the repository at this point in the history

  2. revert external circuit

    @rtimms
    rtimms committed May 6, 2024
    Configuration menu
    Copy the full SHA
    20dc591 View commit details
    Browse the repository at this point in the history

  3. discharge variable submodel

    @rtimms
    rtimms committed May 6, 2024
    Configuration menu
    Copy the full SHA
    df61b36 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored May 6, 2024
    Configuration menu
    Copy the full SHA
    48fe678 View commit details
    Browse the repository at this point in the history

  5. Fix contact link (#4065) 

    * Fix contact link

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @kratman @pre-commit-ci
    kratman and pre-commit-ci[bot] authored May 6, 2024
    Configuration menu
    Copy the full SHA
    3973887 View commit details
    Browse the repository at this point in the history

  6. chore: update pre-commit hooks (#4067) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.2 → v0.4.3](astral-sh/ruff-pre-commit@v0.4.2...v0.4.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored May 6, 2024
    Configuration menu
    Copy the full SHA
    38732f1 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Bump codecov/codecov-action from 4.3.0 to 4.3.1 in the actions group (#… 

    …4066)

Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `codecov/codecov-action` from 4.3.0 to 4.3.1
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored May 7, 2024
    Configuration menu
    Copy the full SHA
    448450b View commit details
    Browse the repository at this point in the history

  2. pybamm.plot_voltage_components doc update (#3993) 

    * pybamm.plot_voltage_components doc update

add link of matplotlib docs for ax.fill_between function

* update documentation for plot_voltage_components

format ax.fill_between as code and link to matplotlib docs for this function

* update arguments

update arguments for plot_voltage_components.py

* update documentation for plot_voltage_components

change func into obj as previous one doesn't link to the Matplotlib docs

---------

Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @Hongmeiqi @arjxn-py @agriyakhetarpal
    3 people authored May 7, 2024
    Configuration menu
    Copy the full SHA
    670b66c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into basic-experiments

    @rtimms
    rtimms authored May 7, 2024
    Configuration menu
    Copy the full SHA
    a14400c View commit details
    Browse the repository at this point in the history

  4. docs: add Hongmeiqi as a contributor for doc (#4068) 

    * docs: update all_contributors.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    @allcontributors
    allcontributors[bot] authored May 7, 2024
    Configuration menu
    Copy the full SHA
    e9711ee View commit details
    Browse the repository at this point in the history

  5. fix typo in f = F/RT (#4069) 

    Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @rtimms @arjxn-py
    rtimms and arjxn-py authored May 7, 2024
    Configuration menu
    Copy the full SHA
    fadf094 View commit details
    Browse the repository at this point in the history

  6. move functions inside submodel

    @mleot
    mleot committed May 7, 2024
    Configuration menu
    Copy the full SHA
    31b7115 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored May 7, 2024
    Configuration menu
    Copy the full SHA
    66f0ef1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into basic-experiments

    @rtimms
    rtimms authored May 7, 2024
    Configuration menu
    Copy the full SHA
    f214f3c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Edit create_copy to accept new children

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    99e9cb3 View commit details
    Browse the repository at this point in the history

  2. Condense _process_symbol

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    da34e36 View commit details
    Browse the repository at this point in the history

  3. Add test for copying with new children

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7d48a1c View commit details
    Browse the repository at this point in the history

  4. Increase coverage for create_copy

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a8204e3 View commit details
    Browse the repository at this point in the history

  5. Add errors for number of children provided to create_copy 

    Abstract out checks for if new children are provided
Improve _unary_new_copy doc strings
    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b19c45a View commit details
    Browse the repository at this point in the history

  6. Adds 'perform_simplifications' to create_copy() to allow user choice

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    54623bc View commit details
    Browse the repository at this point in the history

  7. Update _unary_ and _concatenation_new_copy to take perform_simplifica… 

    …tion

Allows for classes with different input parameters to be called without re-defining the whole create_copy function (with unary errors) each time
    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9d7846b View commit details
    Browse the repository at this point in the history

  8. change _process_symbol() to use create_copy() not _binary_create_copy().

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f9cd000 View commit details
    Browse the repository at this point in the history

  9. Add more tests

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d221195 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #3995 from pybamm-team/basic-experiments 

    Make basic models compatible with experiments
    @valentinsulzer
    valentinsulzer authored May 9, 2024
    Configuration menu
    Copy the full SHA
    fd7d1fd View commit details
    Browse the repository at this point in the history

  11. Add function_new_copy test

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bc00b0c View commit details
    Browse the repository at this point in the history

  12. Merge branch 'develop' into symbol-copy

    @pipliggins
    pipliggins authored May 9, 2024
    Configuration menu
    Copy the full SHA
    bf9cbee View commit details
    Browse the repository at this point in the history

  13. fix change requests

    @mleot
    mleot committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1a8268c View commit details
    Browse the repository at this point in the history

  14. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored May 9, 2024
    Configuration menu
    Copy the full SHA
    5c169e2 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Use JSON to import comsol results (#4064) 

    * using json to import comsol results
* migrated comsol results to json
* code review suggestions
* fixed failing pouch_cell
* refined gitignore

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @santacodes @kratman
    @arjxn-py @agriyakhetarpal
    4 people authored May 10, 2024
    Configuration menu
    Copy the full SHA
    edb139e View commit details
    Browse the repository at this point in the history

  2. Deprecate symbol.new_copy() in favour of symbol.create_copy() 

    Avoids confusion with model.new_copy()
    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1a60913 View commit details
    Browse the repository at this point in the history

  3. Add test copying entire discretised DFN rhs tree

    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    182233e View commit details
    Browse the repository at this point in the history

  4. edit averages create_copy tests

    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4988be9 View commit details
    Browse the repository at this point in the history

  5. Update to use create_copy() rather than private copy functions where … 

    …possible
    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8b9de85 View commit details
    Browse the repository at this point in the history

  6. bug: use casadi MX.interpn_linear function instead of plugin #3783 (#… 

    …4077)

* bug: use casadi MX.interpn_linear function instead of plugin #3783

* bug: fix for 2d and 3d linear interpolant #3783

* cover cubic interpolation in 2d #3783

* #3783 add to changelog

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @martinjrobins @agriyakhetarpal
    martinjrobins and agriyakhetarpal authored May 10, 2024
    Configuration menu
    Copy the full SHA
    51981c4 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. getting rid of functional form Q

    @mleot
    mleot committed May 11, 2024
    Configuration menu
    Copy the full SHA
    f6fc3ad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into plett-ocp-hysteresis

    @mleot
    mleot authored May 11, 2024
    Configuration menu
    Copy the full SHA
    d8f451e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3593 from mleot/plett-ocp-hysteresis 

    Plett OCP Hysteresis Model
    @valentinsulzer
    valentinsulzer authored May 11, 2024
    Configuration menu
    Copy the full SHA
    c687134 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Issue 2111 custom transport efficiency (#3437) 

    * log transport efficiency

* logsqrt_transport

* adding linear transport efficiency

* half_transport_effciency added

* add tortuosity factor submodel

* add multiple tortuosity models

* add tortuosity factor to model examples

* Update submodel options and add citations. Also change the solid phase volume fraction to be (1-porosity) rather than the active material volume fraction

* Update notebook and index for docs, get rid of unnecessary Bruggeman file

* Update docs

* Forgot the new file

* Update title underline and add well_posed tests

* style: pre-commit fixes

* Add some missing tests

* Update the transport efficieny print_name and add a bit more to notebook

* Split the models into separate classes

* style: pre-commit fixes

* Update docs and add citations

* style: pre-commit fixes

* Change docs to footcite

* style: pre-commit fixes

* Update pybamm/models/submodels/transport_efficiency/tortuosity_factor.py

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>

* style: pre-commit fixes

* Remove image from notebook

* remove .virtual_documents

* Update syntax for style

* style: pre-commit fixes

* Update index.rst

* Adjust reference to Shen and Chen

* style: pre-commit fixes

* Add footbibliography to rst files

* style: pre-commit fixes

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update CITATIONS.bib

---------

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Julia Wind <Julia.Wind@ife.no>
Co-authored-by: amirDahari1 <amir.dahari@mail.huji.ac.il>
Co-authored-by: Tom.Maull <Tom.Maull@wae.com>
Co-authored-by: amirDahari1 <31094949+amirDahari1@users.noreply.github.com>
Co-authored-by: Julia Wind <60978412+juliawind@users.noreply.github.com>
Co-authored-by: Ruimin-S <r.song22@imperial.ac.uk>
Co-authored-by: Isaac Squires <55202483+isaacsquires@users.noreply.github.com>
Co-authored-by: Ruimin-S <123746946+Ruimin-S@users.noreply.github.com>
Co-authored-by: isaacsquires <isaacsquires@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @TomTranter @brosaplanella
    @juliawind @amirDahari1 @tommaull @Ruimin-S @isaacsquires @pre-commit-ci @valentinsulzer @agriyakhetarpal
    14 people authored May 13, 2024
    Configuration menu
    Copy the full SHA
    1dae0bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …develop
    DrSOKane committed May 13, 2024
    Configuration menu
    Copy the full SHA
    bb68ea3 View commit details
    Browse the repository at this point in the history

  3. Adds recursive __all__ dictionary (#4040) 

    * Add recursive `__all__` dict with every submodule currently
* Adds `__all__` to submodules recursively
* Suggestions from code review
* Fix breaking import

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @arjxn-py @agriyakhetarpal
    arjxn-py and agriyakhetarpal authored May 13, 2024
    Configuration menu
    Copy the full SHA
    b18abed View commit details
    Browse the repository at this point in the history

  4. chore: update pre-commit hooks (#4084) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.4.4](astral-sh/ruff-pre-commit@v0.4.3...v0.4.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored May 13, 2024
    Configuration menu
    Copy the full SHA
    7606659 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. docs: add mleot as a contributor for code, and test (#4085) 

    * docs: update all_contributors.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    @allcontributors
    allcontributors[bot] authored May 14, 2024
    Configuration menu
    Copy the full SHA
    d65aa72 View commit details
    Browse the repository at this point in the history

  2. Add readme again (#4088)

    @kratman
    kratman authored May 14, 2024
    Configuration menu
    Copy the full SHA
    0cb34a1 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. update codeowners

    @valentinsulzer
    valentinsulzer committed May 16, 2024
    Configuration menu
    Copy the full SHA
    dbfc04a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4095 from pybamm-team/update-codeowners 

    update codeowners
    @valentinsulzer
    valentinsulzer authored May 16, 2024
    Configuration menu
    Copy the full SHA
    afbf21d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into symbol-copy

    @martinjrobins
    martinjrobins authored May 16, 2024
    Configuration menu
    Copy the full SHA
    32af2c9 View commit details
    Browse the repository at this point in the history

  4. add temperature dependence to MSMR model (#3832) 

    * Bump to v23.9rc0

* Merge pull request #3412 from agriyakhetarpal/drop-i686-manylinux2014-support

Drop support for i686 manylinux

* Merge pull request #3413 from Saransh-cpp/improve-release-workflow

Improve release workflow, add a note, bump version manually

* Merge pull request #3436 from Saransh-cpp/fortnightly-wheels

Build wheels on the 1st and 15th of every month

* Merge pull request #3445 from pybamm-team/issue-3428-rename-exchange

#3428 exchange-current density error

* Merge pull request #3449 from pybamm-team/i3431-windows-wheels

Fix failing windows wheel builds

* Merge pull request #3456 from abillscmu/issue-3224-initial_soc

make initial soc work with half cell models

* Merge pull request #3467 from abillscmu/bugfix/initial_soh

* Merge pull request #3423 from jsbrittain/jax_gpu

JaxSolver fails when using GPU support with no input parameters

* Fix changelog

* Merge pull request #3475 from arjxn-py/fix-default-imports

Resolve default imports for optional dependencies

* Bump - `v23.9rc1`

* Fix date in CHANGELOG

* Bump version to v23.9

* Fix docs about Jax solver compatibility with Python versions (#3702)

* Ensure correct Python versions for Jax solver compatibility

* Simplify array of Python versions

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Use different conjunction

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Merge pull request #3706 from agriyakhetarpal/fix-pybamm-install-odes

Make `pybamm_install_odes` a bit more robust

* #3690 fix issue with skipped steps (#3708)

* #3690 fix issue with skipped steps

* #3690 changelog

* #3690 add test

* #3611 use actual cell volume for average total heating (#3707)

* #3611 use actual cell volume for average total heating

* #3611 changelog

* #3611 account for number of electrode pairs

* #3611 update variable names

* Improve the release workflow (#3737)

* Try fixing the release workflow

* Turn off safety

* Fix CHANGELOG

* Add OS

* Use regex for better matches

* Update instructions, add safety checks

* checkout to the version branch for the final release

* Bump to v24.1rc1

* #3630 fix interpolant shape error (#3761)

* #3630 fix interpolant shape error

* #3630 changelog

* Bump to v24.1rc2

* Bump to v24.1

* Fix doctests failures in scheduled tests (#3784)

Closes #3781

* Resolve broken `scikits.odes` installation on self-hosted M-series runner (#3785)

* Try fixing M-series runner tests

This is being done by adding SuiteSparse and SUNDIALS installations which might have been missing on the runner, which broke `scikits.odes`.

* Don't use Homebrew SUNDIALS, use LD_LIBRARY_PATH

* Don't use Homebrew to install SUNDIALS

* Force remove pip cache for `scikits.odes`

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* add temperature dependence to MSMR model

* changelog

* fix tests

* fix example

* rob comments

* update notebook

---------

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Martin Robinson <martinjrobins@gmail.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
Co-authored-by: Saransh-cpp <Saransh-cpp@users.noreply.github.com>
    @valentinsulzer @brosaplanella
    @Saransh-cpp @martinjrobins @agriyakhetarpal @kratman @rtimms
    8 people authored May 16, 2024
    Configuration menu
    Copy the full SHA
    33d9ea7 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Use wider-compatible LLVM-OpenMP, bundle libgfortran dylibs for mac… 

    …OS wheels (#4092)

* Set `MACOSX_DEPLOYMENT_TARGET` for prerequisites

* Remove previously set environment variables

* Remove Homebrew libomp installations

* Ignore `pybamm-requires` OpenMP downloads

* Rework docs to add OpenMP instructions

* Download LLVM-OpenMP on macOS

* Remove unused compiler argument

* Fix rpath for libomp dylib at wheel repair

* Fix a failing link

* Revert "Fix rpath for libomp dylib at wheel repair"

This reverts commit 6fb8ef0.

* Fix RPATHs for SuiteSparse and libomp

* 11.1 for arm64 macOS and 11.0 for amd64 macOS

* Set up Fortran compiler via GHA

* Downgrade to gcc 12

* Try fix for macOS amd64 wheels first

* Build on macos-13 image instead

* Debug further, try building against 11.0

* And now build for macOS arm64

* Try building arm64 against 11.0

* Rename wheel from 11_1 to 11_0

* Cleanup and fix up commands

* Rename wheel in dest dir instead

* Cleanup plus references to SciPy license
    @agriyakhetarpal
    agriyakhetarpal authored May 18, 2024
    Configuration menu
    Copy the full SHA
    becb1a4 View commit details
    Browse the repository at this point in the history

  2. include CMakeLists.txt in sdist (#4101) 

    * removed CMakeLists.txt from `exclude` in Manifest.in

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @cringeyburger @agriyakhetarpal
    cringeyburger and agriyakhetarpal authored May 18, 2024
    Configuration menu
    Copy the full SHA
    0237b11 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. --- (#4104) 

    updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored May 20, 2024
    Configuration menu
    Copy the full SHA
    8823b40 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Updated scipy and jax versions to fix linalg.tri deprecation (#4103) 

    * #3959 updated scipy and jax versions to fix deprecation error

* #3959 fix issue with vstack array dimensions

* style: pre-commit fixes

* #3959 use direct solver for interpolant

* Update pyproject.toml

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* #3959 use jax and jaxlib 0.4.27

* #3959 revert to iterative solver for interpolator and relax test tolerances

* style: pre-commit fixes

* ruff

* #3959 Eric's comments

* #3959 reduce tolerances to fix macos-14 unit tests

* Update pyproject.toml

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* #3959 relax some more tolerances

* #3959 reduce solve time in test to avoid overdischarge (aiming to fix macos failing test)

* #3959 extend solving time to reach end of discharge

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @brosaplanella @pre-commit-ci
    @agriyakhetarpal @kratman
    4 people authored May 21, 2024
    Configuration menu
    Copy the full SHA
    36a9caf View commit details
    Browse the repository at this point in the history

  2. Use delvewheel to repair wheels on Windows, add MSVCRT DLLs (#4105) 

    * Repair wheels on Windows

* Install delvewheel
    @agriyakhetarpal
    agriyakhetarpal authored May 21, 2024
    Configuration menu
    Copy the full SHA
    1692ffb View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Issue 4082 Documentation CI Fix (#4102) 

    * add temporary fix to doctests session
* parallelize all jobs in scheduled workflow
* style corrections
* separated openblas installation in jobs
* commented github.repo line to test workflow locally
* fix logic: remove 'if' statements in certain jobs
* install setuptools in run_doctests
* remove the comment if statement in build-apple-mseries
* style changes
* add temporary fix to docs session
* resolved conversations
* style changes
* removed style job and all instances of it
* modified incorrect name of dvipng
* Apply suggestions from code review
resolve conversations

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @cringeyburger @agriyakhetarpal
    cringeyburger and agriyakhetarpal authored May 22, 2024
    Configuration menu
    Copy the full SHA
    5f35628 View commit details
    Browse the repository at this point in the history

  2. Fixes breaking changes from #3624 (#4072) 

    * removes breaking change from electrode diffusivity -> particle diffusivity

* Add conditional entry for base_solver inputs recreation

* fix: incorrect depreciated parameter translation, moves conversion to ParameterValues staticmethod

Fixes an incorrect conversion of electrode diffusivity to particle diffusivity,
Updates the corresponding test to ensure FuzzyDict.__getitem__ functions correctly,
Adds conversion and checks to BaseSolver inputs object,

* Add changelog entry

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @BradyPlanden @kratman
    BradyPlanden and kratman authored May 22, 2024
    Configuration menu
    Copy the full SHA
    092ebc9 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Revert "Use wider-compatible LLVM-OpenMP, bundle libgfortran dylibs… 

    … for macOS wheels (#4092)" (#4109)

This reverts commit becb1a4.
    @agriyakhetarpal
    agriyakhetarpal authored May 24, 2024
    Configuration menu
    Copy the full SHA
    6ba81b7 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Running tests together on github-actions. (#4108) 

    * Running tests together

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* Running coverage tests together as well

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* Added if condition to coverage tests

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* Running integration tests as a seperate step

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

---------

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
    @prady0t
    prady0t and prady0t authored May 27, 2024
    Configuration menu
    Copy the full SHA
    b972782 View commit details
    Browse the repository at this point in the history

  2. Patch for phase errors (#4083) 

    Adding tests
    @kratman
    kratman authored May 27, 2024
    Configuration menu
    Copy the full SHA
    edc377f View commit details
    Browse the repository at this point in the history

  3. chore: update pre-commit hooks (#4111) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.4 → v0.4.5](astral-sh/ruff-pre-commit@v0.4.4...v0.4.5)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored May 27, 2024
    Configuration menu
    Copy the full SHA
    9f77045 View commit details
    Browse the repository at this point in the history

  4. Bump codecov/codecov-action from 4.3.1 to 4.4.1 in the actions group (#… 

    …4110)

Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `codecov/codecov-action` from 4.3.1 to 4.4.1
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.3.1...v4.4.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored May 27, 2024
    Configuration menu
    Copy the full SHA
    739a1c0 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Add time to experiment termination conditions (#4073) 

    * add time termination lines

* fix bug

* add test

* add more test coverage

* update changelog

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @mleot @agriyakhetarpal @kratman
    3 people authored May 28, 2024
    Configuration menu
    Copy the full SHA
    a427b3a View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. fixed python3.12 failing CI tests (#4118)

    @santacodes
    santacodes authored May 29, 2024
    Configuration menu
    Copy the full SHA
    c733b73 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Added pooch registries for data files (#4098) 

    * added pooch

* removed getpath()

* added data_loader to notebooks and scripts

* removed data files in the registry

* added docs and implemented code review suggestions

* added example notebook, unit tests and edited changelog

* fixed pouch cell notebook

* Apply suggestions from code review

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* style: pre-commit fixes

* added more test coverage, fixed notebook and code review suggestions

* added bib references

* fixed doctest and script test errors

* fixed codacy warnings

* using sockets for checking network

* code review suggestions along with notebook update

* Apply suggestions from code review

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* fixed RUF015

* changed link referenced and fixed lychee warning

* changed the data files link under input/ to pybamm-data repo

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @santacodes @agriyakhetarpal
    @pre-commit-ci @brosaplanella @arjxn-py @kratman
    6 people authored May 30, 2024
    Configuration menu
    Copy the full SHA
    a553fe6 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Refactor test_experiment_step_termination.py*** (#3800) 

    * Refactor test_experiment_step_termination.py***
(from unittest to pytest)

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @abhicodes369 @pre-commit-ci @agriyakhetarpal
    3 people authored May 31, 2024
    Configuration menu
    Copy the full SHA
    01e652a View commit details
    Browse the repository at this point in the history

  2. docs: add abhicodes369 as a contributor for test (#4121) 

    * docs: update all_contributors.md [skip ci]

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    @allcontributors
    allcontributors[bot] authored May 31, 2024
    Configuration menu
    Copy the full SHA
    f720542 View commit details
    Browse the repository at this point in the history

  3. Minor updates to SEI-on-cracks example notebook

    DrSOKane committed May 31, 2024
    Configuration menu
    Copy the full SHA
    16e19ea View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …develop
    DrSOKane committed May 31, 2024
    Configuration menu
    Copy the full SHA
    2b4cf49 View commit details
    Browse the repository at this point in the history

  5. Minor updates to SEI-on-cracks example notebook (#4122)

    @DrSOKane
    DrSOKane authored May 31, 2024
    Configuration menu
    Copy the full SHA
    ce1d87a View commit details
    Browse the repository at this point in the history

  6. pybamm.JaxSolver docstring improvement (#3994) 

    * pybamm.JaxSolver docstring improvement

* Update conf.py to add `intersphinx_mapping` for `jax`

* Update jax_solver.py to fix docstring rendering

* Update docs/conf.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update pybamm/solvers/jax_solver.py

* Update docs/conf.py

* Apply suggestions from code review

* Update pybamm/solvers/jax_solver.py

Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>

* Update pybamm/solvers/jax_solver.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update docs/conf.py

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @buddhiwisr @agriyakhetarpal
    @arjxn-py @kratman
    4 people authored May 31, 2024
    Configuration menu
    Copy the full SHA
    16da4ca View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Use pytest for integration tests (#4125) 

    Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @prady0t @pre-commit-ci @agriyakhetarpal
    4 people authored Jun 2, 2024
    Configuration menu
    Copy the full SHA
    3086b4a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. #4127 Set minimum JAX==0.4.27 (#4129)

    @arjxn-py
    arjxn-py authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    640666a View commit details
    Browse the repository at this point in the history

  2. chore: update pre-commit hooks (#4133) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.5 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.5...v0.4.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d5ca92b View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Removing relative imports (#4136) 

    * Removing relative imports

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* style: pre-commit fixes

---------

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @prady0t @pre-commit-ci
    @agriyakhetarpal @arjxn-py
    5 people authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    b15d979 View commit details
    Browse the repository at this point in the history

  2. Updated Ecker2015 diffusivity to better match the original paper

    DrSOKane committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    062f5bc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …develop
    DrSOKane committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6d30f64 View commit details
    Browse the repository at this point in the history

  4. fix bug in leading surface form conductivity (#4139) 

    * fix bug in leading surface form conductivity

* update changelog

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @rtimms @kratman @agriyakhetarpal
    3 people authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    293b8ff View commit details
    Browse the repository at this point in the history

  5. changelog

    DrSOKane committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    116b8da View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …develop
    DrSOKane committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    510fca7 View commit details
    Browse the repository at this point in the history

  7. Bundle OpenMP (libomp) and libgfortran dylibs for macOS wheels, f… 

    …ix deployment target (#4128)

* Setup minimal conda/mamba environment file

* Don't set Homebrew-OpenMP  for PyPI wheels

* Use `setup-miniconda` to access compilers

* Set deployment target for amd64, arm64, separately

* Rename macOS wheel job

* Add `miniconda-version: "latest"` input to action

* Fix deployment target env var

* Fix Linux syntax error

* Add a fortran compiler as well

* Set FC explicitly – can't be found? Not sure

* Activate pybamm-dev environment in CIBW_BEFORE_ALL

* Set CC, CXX, and FCC, don't use XCode compilers

* Run `conda init` before `conda activate`

* Create environment via file inside `CIBW_BEFORE_ALL`

* Use micromamba instead of conda

* Use Homebrew to install miniforge

* Set FC and PATH for mamba to find compiler

* Don't use cibuildwheel action, use PyPI package

* Activate mamba environment

* Try to activate Miniforge-mamba environment

* Delete minimal environment file

* `scikit-image`'s solution, conda for LLVM-OpenMP

* Set correct path to Miniforge envs

* Include tests in sdist and wheel

* Install gfortran from scipy's solution

* Fix CI environment variable

* Copy libomp dylib for repair

* Improve wheel test command

* Export SuiteSparse paths to search libomp dylib for

* Copy libomp dylib to local directory again

* Target 11.0, repair against 11.1, rename wheel

* Run tests from {project} for now, not {package}

* Fix conditional binary operator

* Run integration tests, add note for `libgcc_s.1.dylib`

* Remove incorrect tests, import IDAKLU for now

* Use `set -e -x` to verify PyBaMM import

* Apply suggestions from code review

* Update publish_pypi.yml
    @agriyakhetarpal
    agriyakhetarpal authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d77d12c View commit details
    Browse the repository at this point in the history

  8. Fix pre-commit in nox (#4142)

    @kratman
    kratman authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f3f7b4c View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Fix coverage workflow (#4146) 

    * Remove quotes from the if-statement

* Adjust logic

* Fix job naming

* Change order
    @kratman
    kratman authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b4f8380 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Running doctests using doctest-plus (#4117) 

    * Adding doctest using doctest-plus

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* Skipping failing tests

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* Update run-tests.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* style: pre-commit fixes

* Removing unrelated subprocess

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* style: pre-commit fixes

* Update docs/source/user_guide/installation/index.rst

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update docs/source/user_guide/installation/index.rst

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update pybamm/parameters/parameter_sets.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Fixing doctest directive

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

---------

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @prady0t @kratman
    @agriyakhetarpal @pre-commit-ci @arjxn-py
    6 people authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    11dcf6a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into symbol-copy

    @pipliggins
    pipliggins authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    88002f1 View commit details
    Browse the repository at this point in the history

  3. Restore modulo coverage (#4143) 

    * Starting to fix modulo coverage

* Remove quotes from the if-statement

* Adjust logic

* Fix job naming

* Change order

* Cleanup

* Re-adding test

* A bit more refactoring

* Fix a line of coverage
    @kratman
    kratman authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b2f08ef View commit details
    Browse the repository at this point in the history

  4. Moved new parameters into separate Yuan2023 file

    DrSOKane committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4a97f12 View commit details
    Browse the repository at this point in the history

  5. pybind11 v2.12.0 (#4151) 

    * Pin pybind11 version in `pybamm-requires`

* Bump to v2.12.0 for benchmarks and wheels
    @agriyakhetarpal
    agriyakhetarpal authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6c01787 View commit details
    Browse the repository at this point in the history

  6. Issue 4123 fix: SEI + Composite Integrations and lithium plating func… 

    …tions updated (#4153)

* #4123 fix

* Updated plating.py with same bug fix from issue 4123

* Bug fix combined to one line

* style: pre-commit fixes

---------

Co-authored-by: Caitlin Parke <cat@Caitlins-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @parkec3 @pre-commit-ci
    3 people authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    8200b8f View commit details
    Browse the repository at this point in the history

  7. docs: add parkec3 as a contributor for code (#4154) 

    * docs: update all_contributors.md [skip ci]

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    @allcontributors
    allcontributors[bot] authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2cbd788 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Rename string(string) to avoid a scope issue (#4157) 

    * Fix scope issue

* Automatic changes
    @kratman
    kratman authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d68a958 View commit details
    Browse the repository at this point in the history

  2. Updated Yuan2023 parameter set

    DrSOKane committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    637a19f View commit details
    Browse the repository at this point in the history

  3. chore: update pre-commit hooks (#4162) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.7 → v0.4.8](astral-sh/ruff-pre-commit@v0.4.7...v0.4.8)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e542eca View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Removed Yuan2023 parameters for now

    DrSOKane committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    abcbf9a View commit details
    Browse the repository at this point in the history

  2. Added separate parameter for initial SEI on cracks

    DrSOKane committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    03c8622 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …initial-SEI-cracks
    DrSOKane committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1fb40e7 View commit details
    Browse the repository at this point in the history

  4. changelog

    DrSOKane committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3676c51 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #4168 from DrSOKane/initial-SEI-cracks 

    Initial SEI on cracks
    @DrSOKane
    DrSOKane authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ad4debc View commit details
    Browse the repository at this point in the history

  6. Minor refactoring on deserialize (#4158) 

    * Minor refactoring on deserialize

* Remove private attributes
    @kratman
    kratman authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0421fc3 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Updated code of conduct to contributor covenant v2.1 (#4171) 

    * updated code of conduct to contributor covenant v2.1

* Update CODE-OF-CONDUCT.md

Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>

---------

Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @santacodes @arjxn-py
    santacodes and arjxn-py authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    91bfed4 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge branch 'develop' into symbol-copy

    @martinjrobins
    martinjrobins authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3688968 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4023 from pipliggins/symbol-copy 

    Generalised symbol copying
    @martinjrobins
    martinjrobins authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    20046d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. fixed broken contact link (#4182)

    @santacodes
    santacodes authored Jun 16, 2024
    Configuration menu
    Copy the full SHA
    90a1dea View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Pin numpy (#4186)

    @kratman
    kratman authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    853417c View commit details
    Browse the repository at this point in the history

  2. move secondary broadcast outside of gradient

    @valentinsulzer
    valentinsulzer committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    5388515 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4190 from pybamm-team/grad-secondary-broadcast 

    move secondary broadcast outside of gradient
    @valentinsulzer
    valentinsulzer authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    559bca8 View commit details
    Browse the repository at this point in the history

  4. Update Valentin's github username (#4194)

    @arjxn-py
    arjxn-py authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c8a4fe2 View commit details
    Browse the repository at this point in the history

  5. chore: update pre-commit hooks (#4193) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @pre-commit-ci @kratman
    pre-commit-ci[bot] and kratman authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    55f6bb7 View commit details
    Browse the repository at this point in the history

  6. Bump the actions group with 2 updates (#4191) 

    Bumps the actions group with 2 updates: [docker/build-push-action](https://github.com/docker/build-push-action) and [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `docker/build-push-action` from 5 to 6
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v5...v6)

Updates `codecov/codecov-action` from 4.4.1 to 4.5.0
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.4.1...v4.5.0)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4d08b7a View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. docs: add ikorotkin as a contributor for code (#4188) 

    * docs: update all_contributors.md [skip ci]

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @allcontributors @arjxn-py
    allcontributors[bot] and arjxn-py authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0239c2d View commit details
    Browse the repository at this point in the history

  2. docs: add Afgr1087 as a contributor for code (#4189) 

    * docs: update all_contributors.md [skip ci]

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
    @allcontributors @arjxn-py
    allcontributors[bot] and arjxn-py authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    017661a View commit details
    Browse the repository at this point in the history

  3. docs: add santacodes as a contributor for code, and infra (#4195) 

    * docs: update all_contributors.md [skip ci]

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    @allcontributors
    allcontributors[bot] authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e5fe293 View commit details
    Browse the repository at this point in the history

  4. Fixed broken link renders in SPM example notebook (#4185) 

    * fixed broken link references in SPM example notebook

* changed links from latest to stable

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @santacodes @agriyakhetarpal
    santacodes and agriyakhetarpal authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7d3ef99 View commit details
    Browse the repository at this point in the history

  5. issue-4183-remove-autograd

    @valentinsulzer
    valentinsulzer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a4188b5 View commit details
    Browse the repository at this point in the history

  6. #4183 remove autograd

    @valentinsulzer
    valentinsulzer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    666081d View commit details
    Browse the repository at this point in the history

  7. changelog

    @valentinsulzer
    valentinsulzer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    dc02b1a View commit details
    Browse the repository at this point in the history

  8. unpin numpy

    @valentinsulzer
    valentinsulzer committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4517c20 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Update compare-ecker-data.ipynb (#4197)

    @soorajsunil
    soorajsunil authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    088ca38 View commit details
    Browse the repository at this point in the history

  2. add interpolant differentiation back in

    @valentinsulzer
    valentinsulzer committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f09c2b2 View commit details
    Browse the repository at this point in the history

  3. merge develop

    @valentinsulzer
    valentinsulzer committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    d01b6d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge branch 'develop' of github.com:pybamm-team/PyBaMM into develop

    @valentinsulzer
    valentinsulzer committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f449152 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into issue-4183-remove-autograd

    @valentinsulzer
    valentinsulzer committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8471bb1 View commit details
    Browse the repository at this point in the history

  3. try repinning numpy<2.0

    @valentinsulzer
    valentinsulzer committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0ec6c96 View commit details
    Browse the repository at this point in the history

  4. coverage

    @valentinsulzer
    valentinsulzer committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    84ee101 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Fixes #4176 electrode diffusivity rename (#4179) 

    * fix: revert logic change for failing 'particle diffusivity' key, updt. check_parameter_values to rename depreciated key

* fix: removes bpx remapping requirement, creates 'particle diffusivity' without destroying 'electrode diffusivity', updts tests to verify functionality

* Add changelog

* Apply suggestions from code review

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

---------

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @BradyPlanden @brosaplanella @agriyakhetarpal
    3 people authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    23bebd0 View commit details
    Browse the repository at this point in the history

  2. Issue 1778 - heat of mixing (#2837) 

    * fix

* fix exception

* added a Newfile

* pseudo

* #1778 add heat of mixing option

* #1778 fixed indentation

* #1778 fixed test

* #1778 fixed test

* #1788 added heat of mixing tests

* First commit

* #1778 fixed test

* First iteration

* #1788 try to fix diff of U

* first push from mac

* Fixed full broadcast

* Fixed domain in the integral

* #1778 fix parameter values example

* Added children[0].children[0]

* Added half cell

* style: pre-commit fixes

* #1788 revert some unrelated changes

* change ocv hack

* Revert "change ocv hack"

This reverts commit 3ad0c75.

* #1778 fix heat of mixing

* #1839 fix thermal submodels to take x_average

* #1778 add example heat of mixing

* ruff

* style: pre-commit fixes

* #1778 fix lead acid models

* fix SPM with the right broadcast of temperature

* #1778 refactor heat of mixing

* style: pre-commit fixes

* Add Richardson2021 citation for heat of mixing

* Fixed heat of mixing sign

* Rewritten heat of mixing example, added comparison plot to compare with the paper

* Fixed ruff formatting errors in the heat of mixing example script

* #1778 fix x-full

* #1778 fix tests

* #1778 improve coverage

* style: pre-commit fixes

* #1778 Valentin's suggestion to remove the dUdsto function and compute the derivative in the model directly instead

* #1778 fix failing test

* #1778 add heat of mixing to CHANGELOG

---------

Co-authored-by: Alec Bills <48105066+abillscmu@users.noreply.github.com>
Co-authored-by: smitasahu2 <smitasahuiitd@gmail.com>
Co-authored-by: Afgr1087 <andres.galvis@fem.unicamp.br>
Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Ivan Korotkin <i.korotkin@soton.ac.uk>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @aabills @smitasahu2
    @Afgr1087 @brosaplanella @ikorotkin @pre-commit-ci
    7 people authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    241e4cc View commit details
    Browse the repository at this point in the history

  3. add Smita to contributors (#4204)

    @brosaplanella
    brosaplanella authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8ba4791 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into issue-4183-remove-autograd

    @brosaplanella
    brosaplanella authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d38117b View commit details
    Browse the repository at this point in the history

  5. Merge pull request #4196 from pybamm-team/issue-4183-remove-autograd 

    #4183 remove autograd
    @valentinsulzer
    valentinsulzer authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    205ca81 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. chore: update pre-commit hooks (#4210) 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @pre-commit-ci
    pre-commit-ci[bot] authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    47f4583 View commit details
    Browse the repository at this point in the history

  2. docs: add Ubham16 as a contributor for code (#4213) 

    * docs: update all_contributors.md [skip ci]

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    @allcontributors
    allcontributors[bot] authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9b57669 View commit details
    Browse the repository at this point in the history

  3. #4120 improved error message (#4208) 

    * #4120 improved error message

* style: pre-commit fixes

* updated test

* Update tests/unit/test_parameters/test_parameter_values.py

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Update pybamm/parameters/parameter_values.py

Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>

* Update pybamm/parameters/parameter_values.py

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

---------

Co-authored-by: Ubham16 <you@example.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
    @Ubham16 @pre-commit-ci
    @arjxn-py @kratman @rtimms
    6 people authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7ba74dc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into … 

    …v24.5
    @Saransh-cpp
    Saransh-cpp committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c6a48e8 View commit details
    Browse the repository at this point in the history

  5. Update publish_pypi.yml

    @Saransh-cpp
    Saransh-cpp authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    139776e View commit details
    Browse the repository at this point in the history

  6. Remove T flag

    @kratman
    kratman authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d8745c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fixes for sympy (#4253)

    @kratman
    kratman committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    dad1509 View commit details
    Browse the repository at this point in the history

  2. Fix test pypi worflow (#4217) 

    * Update test pypi

* Style fix
    @kratman
    kratman committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ba2f7a0 View commit details
    Browse the repository at this point in the history

  3. Make function for handling time or reuse an existing one (#4209) 

    * Make function for handling time or reuse an existing one
Fixes #4113

* style: pre-commit fixes

* fixing raises RegEx Error Experiment Test

* fix pre-commit error

* Update pybamm/callbacks.py

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @mleot @pre-commit-ci
    @agriyakhetarpal @valentinsulzer @kratman
    5 people committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1e582fd View commit details
    Browse the repository at this point in the history

  4. Issue 4224 duration bug (#4239) 

    * make longer default duration and calculate it for C-rate

* add tests

* typo

* #4224 add warning for time termination and add abs

* fix tests

* #4224 keep non-C-rate default at 24h for performance reasons

* trying to fix experiment

* fix example

* #4224 eric comments

* fix bug
    @valentinsulzer @kratman
    valentinsulzer authored and kratman committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c7ea22f View commit details
    Browse the repository at this point in the history

  5. Fix package directory

    @kratman
    kratman committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d4c5413 View commit details
    Browse the repository at this point in the history

  6. Update version

    @kratman
    kratman committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2442907 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Corrects "electrode diffusivity" error catch (#4267) 

    * fix: error catch for electrode diffusivity

* refactor: update diffusivity error catch and test

* tests: up coverage for diffusivity name catches

* Update pybamm/util.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
    @BradyPlanden @kratman
    @brosaplanella @agriyakhetarpal
    4 people committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b0c44cc View commit details
    Browse the repository at this point in the history

  2. Update version

    @kratman
    kratman committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f61074a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'main' of github.com:pybamm-team/PyBaMM into v24.5

    @kratman
    kratman committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3d2ecbe View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. fix bug in composite surface form model (#4293)

    @rtimms @kratman
    rtimms authored and kratman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7661ed9 View commit details
    Browse the repository at this point in the history