Incorrect helm value: dataPlanePerProxy #10052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for host_rewrite_header (#9608) * add it to the proto * add plugin * add changelog * Adding changelog file to new location * Deleting changelog file from old location * add validation * remove old entry * Adding changelog file to new location * Deleting changelog file from old location * dont remove exposed method * update changelog * update changelog * Update changelog/v1.18.0-beta1/add-host-rewrite-header.yaml Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * update changelog * update changelog * address comments --------- Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * update changelog * disable ingress tests * change changelog type * Trigger CI --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
Previously, a 'metaKey' was generated for each Proxy being translated and synced to envoy. This key was used as a 'tag' for tracing of the translation/sync prcoess. It used a custom function that was almost exactly matched how the SnapshotCacheKey used for xDS was generated; this function also modified the actual Proxy's namespace, which broke assumptions of where the proxy lives in the in-memory client. By removing the namespace modification we fix various status error logs as now the Proxy is located where the rest of the system expects (the write namespace). Also, we can simply use the SnapshotCacheKey(...) to generate a key with the same logic used for xds.
* make tests runnable with injection * yoink var into better package * refactor for un/ordered, convert the rest * fix a missed merge conflict * add changelog * oops wrong skip * rename and refactor * clean up and compiler-assert new suite signatures * documentation * documentation * fix my runs * wrap un/ordered in struct for ease of use * Adding changelog file to new location * Deleting changelog file from old location * move changelog * Update test/kubernetes/e2e/tests/glooctl_istio_inject_tests.go * refactor to export less * move and rename suite runner * update readme * rename some more stuff --------- Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* retry on leader lease renewal failure * Die if unable to recover * use env var * add basic tests * udpate tests * add comments * Add commnets around ci changes * update tests * refactor * cleanup * udpate test * rename env var * add changelog * address comments v1 * address comments v2 * fix test * sue GinkgoHelper * Adding changelog file to new location * Deleting changelog file from old location * specify a duration * Adding changelog file to new location * Deleting changelog file from old location * remove default * Adding changelog file to new location * Deleting changelog file from old location * fix tests * move changelog * move conter --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
* Remove old Istio tests, add new Istio suite with regression values (#9636) * wip: remove old istio tests * add regression test, add edge gw api port routing test * pr feedback --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * move changelog * more changelog diffs --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* iosnapshot/history: fix test flake (#9630) * fix test flake * add changelog * skip kube tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * helm: support webhook.enablePolicyApi (#9632) * update helm api and docs * bad . * more restrictive check * add test case * add changelog * undo debugging step * update helm api description * improve helm description --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * introduce test coverage reporting, update devel with Gloo Gateway references (#9646) * devel/ : Gloo Edge -> Gloo Gateway * more changes * update workflows, add go-test-with-coverage * run unit tests on PR * update name * fix coverage file path * consistent step names * disable race to prove out test coverage * add working dir * properly specify outputdir * test coverage update * install test tools * install tools and coverage tools * update thresholds, ignore errors in CI * update test coverage def * add changleog * update commet in gha * re-add race flag * E.T phone home * Apply suggestions from code review Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Apply suggestions from code review Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> * more suggestions * skip kube tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> * consolidate changelog * gateway2/deployer: fix race due to context cancellation (#9651) * fix helm race * tidy * update commentary, and function asignautres --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * cleanup changelog * delete readme, was moved to devel folder --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>
…or discoveryAddress, istioMetaMeshId and istioMetaClusterId (#9653) * Fix status syncer and fix Istio integration values for discoveryAddress, istioMetaMeshId and istioMetaClusterId (#9625) * initial fixes * cleanup * add log lines * pr feedback * pr feedback --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * move changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
… no VS exist (#9659) * fix: Reject a hybridGateway with no delegatedHttpGateways when no VS exist (#9647) * fix: Reject a hybridGateway with no delegatedHttpGateways * add tests * Modify check * rename tests * Update changelog/v1.18.0-beta1/fix-aggregate-gateway-error.yaml Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * fix changelog * Adding changelog file to new location * Deleting changelog file from old location --------- Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * move changelog --------- Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* glooctl check * cl * codegen * use const * standardize casing * standardize case * update kubegateway check * fix import * scheme * KUBE2E_TESTS not needed by setup-kind * fix test * Adding changelog file to new location * Deleting changelog file from old location * fix typo * add additional check outputs * exclude kube checks * add docs to exclude * ensure kube resources are not checked if not enabled * add exclude options * add todo * update kubegatewayenabled check * fix newline * use constants * return early * update comment * Update error * address comments * rename kube gateway * update message --------- Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* commentary in deployer * cleanup deployer_test * cleanup inner-GG values.yaml * move proxy container secCtx to default GwP * move envoy container resources to GwP * commentary on internal chart values * remove readiness port value * cleanup and todos for values * remove serviceAccount config * helm tests * oops test focus * remove autoscaling from public facing GwParams * fix broken ggv2 template * kube e2e test * maybe don't commit a panic * more cleanup inner-GG values.yaml * test container sec ctx because pod sec ctx is never set * try deploying the right stuff this time * add changelog * add changelog * commentary * reserve autoscaling field in GwParams, other cleanup * reorder proto * fix nullable defaults in 43-gwp * codegen * rename some stuff * maybe actually run the test * fix the stupid name --------- Co-authored-by: Lawrence Gadban <lawrence.gadban@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* Small Gateway Touch-Ups Backport of (#9668) * fix helm values for GwParams + sidecars * remove extensions from deployer; no longer needed * filter irrelevant GwClasses --------- Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * GGv2: Add Prometheus stats listener to Envoy Backport of (#9658) --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * changelog
* 5579 extended http methods (#9633) * Check-in before codegen * Initial commit Includes an e2e test and an attempt at implementing the fix. However, the test fails, so clearly the fix doesn't actually work * Get the implementation working Currently it's a bit of a hack as I just stuffed the functionality into the hcm plugin. I would like to move it elsewhere * Add plugin README * Move configuration to a new plugin * Codegen/formatting updates * Add makefile documentation on building docker images * Update projects/gloo/api/v1/options/header_validation/header_validation.proto Co-authored-by: Bernie Birnbaum <bewebi@earthlink.net> * Address some review comments Namely, remove the new plugin and stuff the functionality into the existing HCM plugin. Also, add a little more documentation on expected breaking changes when UHV is enabled. * Only allow header validation on gateway * Update documentation * Update protobuf API to use a oneof * Add unit test * Add changelog * Fix a compilation error * Add http/2 test * Revert "Add http/2 test" This reverts commit 28f0fe5. * Re-run codegen * Move changelog * Update e2e test documentation * Update API and documentation * Rename API to disable_method_validation * Rename custom_methods `oneof` to header_method_validation * Change disableMethodValidation to disableHttp1MethodValidation * Update a renamed proto variable * Update e2e test to use new framework * Fix some ginkgo methods * Remove duplicated test * Update projects/gloo/api/v1/options/header_validation/header_validation.proto Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> * Add negative test to plugin unit test * Add an additional test * Re-run codegen --------- Co-authored-by: Bernie Birnbaum <bewebi@earthlink.net> Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * Adding changelog file to new location * Deleting changelog file from old location --------- Co-authored-by: Bernie Birnbaum <bewebi@earthlink.net> Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>
…eme (#9692) * fix init * make it less racy * oops another nil ptr * add changelog * remove kube gw api registration * simplify
* bumps to resolve cves * cloudbuild bumps * changelog * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>
* Fix services kubernetes e2e test (#9702) * fix test and run it too * add changelog * oopsie need the .github part * move changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * move changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* rename the k8s gateway enablement variable to remove experimental * remove unused GG_EXPERIMENTAL_ISTIO_MTLS_SDS_ENABLED env var
* glooctl: Improve performance of the check command by optimizing the creation of clients (#9674) * glooctl: optimize creating clients * adding changelog * fix tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * cli: Infer gloo deploy name * move changelog * print grpc function names when fds is enabled --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* Use kube-builder for GatewayParameters CRD (#9347) * suggestion * docs * remove * changelog * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * build * build * pr ci fixes * use values so no nils * Adding changelog file to new location * Deleting changelog file from old location * codegen * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * unit tests are passing * unit tests are passing * safety against nil * make fields clearer * remove proto * fix up helm tests * code * only use pointers where necessary * various PR comments * helm tests pass * code-gen * remove docs changes which we will not be able to use * suppress descriptions * remove file, update changelog * add oneof validation * add back comments * make them all pointers * fix pointers and tests * clean up merge code, use getters * update readme * Adding changelog file to new location * Deleting changelog file from old location * add back labels --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Jenny Shu <jenny.shu@solo.io> * move changelog * missed a spot * codegen * selfmanaged prune --------- Co-authored-by: Yuval Kohavi <yuval.kohavi@gmail.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
* fix changelog * move glooctl one * skip
* Migrate utils from `test/kube2e` to `test/kubernetes` (#9720) * Enhance debug info for failed kubernetes e2e tests (#9746) * add cluster state file; print failures for each test * add changelog * proxy logs * test/kube: namespaces from kubectl * appendable files * appendable files * remove redundant namespace dir in fail path * fixer uppers * sort namespaces, use fully qualified resource names and sort them in output --------- Co-authored-by: nfuden <nathan.fudenberg@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * fix changelogs --------- Co-authored-by: nfuden <nathan.fudenberg@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* fix port translation and add tests * Apply suggestions from code review --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* Remove Istio trust domain (#9713) * add trust domain * changelog * tests * fix test name * add to workflow * Adding changelog file to new location * Deleting changelog file from old location * rebalance tests, fix helm * update workflow with numbers for loadbalancing between e2e test clusters * pr feedback * update gateway proxies to be disabled for k8s gateway e2e tests * cleanup istio install, remove old trust domain tests * fix merge * minimal ci change * fix test name * fix glooctl test helm chart * fix istio edge gw manifest * fix configmap template * Adding changelog file to new location * Deleting changelog file from old location * missing gatewayProxy * t.Error * Adding changelog file to new location * Deleting changelog file from old location --------- Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * move changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>
* regexutils: Add poc for how we can validate regex, does not include all locations just for cors * cors: trailing } * cors: testing with invalid regex * docs: update transforms to actually work. Note routes already use regex compile and transforms use envoy validation * changelogs * changelogs * Adding changelog file to new location * Deleting changelog file from old location * plugins/cors/test: add bad RE2 * projects/pkg/cors: regex * regexutils: naming update --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* cherrypick gloomtls tests * Move glooctl tests to new framework (#9718) * initial move for glooctl tests * combine glooctl helm manifest and edge gw manifest * fix check crds * move test helper values in glooContext * fix crd check for not gloo-system ns * passing tests * passing eventually error test * changelog, cleanup * update references to old glooctl tests * regen docs * remove old glooctl test from workflow * Adding changelog file to new location * Deleting changelog file from old location * fix race debug * remove old glooctl tests from nightlys * Adding changelog file to new location * Deleting changelog file from old location * Add back nightlys for 1.15 and 1.16 * add glooctl tests back * remove tmp dir for check-crds * Adding changelog file to new location * Deleting changelog file from old location * istio feedback from prev pr * helm manifest typo * chart uri --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * changelog * remove unnecessary workflow changes * combine changelogs --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
* pkg/syncer: Make servexds not always leak goroutines * Update debug.go * Update debug.go * Update debug.go * Update debug.go * Update debug.go * tweaks * PR feedback * PR feedback * PR feedbak * Update devmode-cancel-xds.yaml * Adding new utility to curl helpers * Fix up 0 handling * Update test/gomega/assertions/assertions_suite_test.go * update source of constants * util update * fix curl value override * Update curl.go --------- Co-authored-by: Seth Heidkamp <61526534+sheidkamp@users.noreply.github.com> Co-authored-by: nfuden <nathan.fudenberg@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
* Gloo Edge to Gloo Gateway * cli * api * gloo * logo * changelog * version bump * make install-go-tools generated-code -B * make install-go-tools generated-code -B and backport FAQs * peer rev * change skipCI value --------- Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* Flatten resources returned by Admin endpoint (#9760) * add convert code * make getRedactedApiSnapshot private * flatten kube resources * rename client * fix tests * changelog * add comments and test * refactor gvks check * refactor numfields check --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * Admin endpoint: return more resources (#9766) * add convert code * make getRedactedApiSnapshot private * flatten kube resources * rename client * fix tests * changelog * add comments and test * return more resources * refactor gvks check * refactor numfields check * changelog * add more tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * Admin endpoint: allow overriding kube gateway gvks (#9716) * extensions startfuncs * add convert code * make getRedactedApiSnapshot private * flatten kube resources * rename client * fix tests * changelog * add comments and test * return more resources * refactor gvks check * refactor numfields check * updates * set gvks * pass history as param * sort proxies too * remove the startfuncs stuff * changelog * add more tests * update api * changelog * add tests * refactor sort * Adding changelog file to new location * Deleting changelog file from old location * refactor * fix tests * fix compile * empty * add SnapshotHistoryFactory to validation --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * consolidate changelogs --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* backport Docs for Google Cloud Platform (#9780) * add rebrand note, see slack: https://solo-io-corp.slack.com/archives/C03A0K7KH6X/p1721656414521829 * add to
* Add helm values validation to test installation (#9839) * wip * comments on glooctl test * fail early if invalid values * changelog * remove logLevel * changelog * fix test * rename import * fix merge * remove unsupported logLevel field --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* add back values * refactor helper * update comments * tests * more tests * cl * make reusable * fix lint --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
…es (#9881) * Ensure endpoints for upstreams are listed within watchNamespaces * add changelog * codegen * add tests * newline * update helm tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* Global floatingUserId to support OpenShift (#9835) * Add helm values * Add new defaults to "1-gloo-deployment.yaml" * test working, no KubeGateway * Pod level test * GWParams * updates * cleanup template * Update _helpers.tpl * Update utils.go * Update utils.go * Create consistent-floating-user-id.yaml * Pass globals.securitySettings to helper * update casing * Update 5-resource-configmap.yaml * Adding changelog file to new location * Deleting changelog file from old location * Update Dockerfile * skip test * Update _helpers.tpl * test fix * updated helper and tests * move gg2 helper * add floatingUserId to GatewayParameters * Adding changelog file to new location * Deleting changelog file from old location * gg floatingUserId * GG2 floatingUserId helm test * Deployer Tests * Remove global fsGroup * Refactor template param names * Update merge.go * update documentation * Update to make `floatingUserId` also disable selected pod security contexts * whitespace fix * Update docs * Update cluster_setup.md * PR feedback #1 * Add ConvertUnstructured first pass * Pass matchers to ValidateSecurityContexts * Update unstructured_test.go * Update unstructured_test.go * Update install/test/helm_test.go Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com> * Update helm_test.go * Update k8sgateway_test.go * PR Feedback * Update unstructured_test.go * Update unstructured_test.go --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com> * generate and cleanup * move changelog * cleanup leaking AIExtension tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
* [v1.17.x] - Backport doc updates * version bump * updated support message
* only update status on changes * changelog * missing diff * use direct cmp * use cmp.Equal * add metrics * pr feedback * add comment to stopwatch * fix import * regen * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>
* fix: allows setting Istio CA_ADDR independently https://istio.io/latest/docs/reference/commands/pilot-agent/ The Istio documentation indicates that CA_ADDR defaults to the PROXY_CONFIG discovery address. Though it should be possible to specify a CA_ADDR that is unrelated to the discovery address. However, Gloo helm forces these two separate fields to be aligned as it is driven from a single helm value. This change introduces an `istioSpiffeCertProviderAddress` property resolving the problem. The default is kept as `istioDiscoveryAddress` to ensure backward compatibility. * docs: add property documentation + issue link * move changelog to beta15 folder * helm_test: fix compile issues, resolve some deprecated function calls --------- Co-authored-by: Jérémy Lourenço <jeremy.lourenco@snyk.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* Ensure namespace override consistency (#9888) * update to test structure * add consistency to namespace handling in test setup * remove ref to env pkg * move kuberentes e2e test util tests to gha unit tests * update timeout for nightlies * add check to action for tests all being run under TestGlooGateway * add namespace code to example test * fix regex * remove summaries change * update changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * bring util test over * make IsEnvTruthy use IsTruthyValue --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
…9614) (#9896) Implements merging of targetRef based RouteOptions and VirtualHostOptions in a specific order of precedence from oldest to newest created resource. The merging uses shallow merging such that for an option A that is higher priority than option B, merge(A,B) merges the top-level options of B that have not already been set on A. This allows options later in the precedence chain to augment the existing options during a merge but not overwrite them. Signed-off-by: Shashank Ram <shashank.ram@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* helm: support PriorityClassName on gateway-proxy (#9902) * add priority class name, no tests * add unit test * add changelog * update changelog to include other issue ref * another duplicate * update helm api, tests * add conditional for kind.deployment * move changelog
* admin/history: expand implementation and tests (#9797) * tests for asserting resources returned by snpashot endpoint * flush out tests * goimports * add changelog * skip kube tests * add comments to exported functions * Adding changelog file to new location * Deleting changelog file from old location * incorporate PR feedback * deprecate dev_mode * add changelog * move changelog * working history tests * resouces -> resourceList * unfocus history_test * update issue refernces, goimports * docs around adminserver and devMode * update changelog * Sh/remove history managed fields part2 (#9820) * add changelog * redact secret and artifact data, add tests * handle errors * conslidate changelog * update docs to reflect reponse shape * goimports * output data as string, not bytes * update terminology in docs * use getter * fix tests for type change * use getter * simplify handling of response status, use constants * update tests * introduce tests for custom_resource * more enhanced tests to getEdgeApiSnapshot * marshal data properly * update comment * make test assertion more expliicit * update lint action, goimports * tests to show upstreams and secrets repseect kube api server over api snapshot * Adding changelog file to new location * Deleting changelog file from old location * support secrest and upstreams correctly * use getter * fix custom_resource_test.go * use constants for output format * move secret GVK * format output correctly * fix nil checks --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Jenny Shu <jenny.shu@solo.io> * admin/history: Return redacted Artifacts and Secrets in InputSnapshot (#9844) * tests for asserting resources returned by snpashot endpoint * flush out tests * goimports * add changelog * skip kube tests * add comments to exported functions * Adding changelog file to new location * Deleting changelog file from old location * incorporate PR feedback * deprecate dev_mode * add changelog * move changelog * working history tests * resouces -> resourceList * unfocus history_test * update issue refernces, goimports * docs around adminserver and devMode * update changelog * Sh/remove history managed fields part2 (#9820) * add changelog * redact secret and artifact data, add tests * handle errors * conslidate changelog * update docs to reflect reponse shape * goimports * output data as string, not bytes * update terminology in docs * use getter * fix tests for type change * use getter * simplify handling of response status, use constants * update tests * introduce tests for custom_resource * more enhanced tests to getEdgeApiSnapshot * marshal data properly * update comment * make test assertion more expliicit * update lint action, goimports * tests to show upstreams and secrets repseect kube api server over api snapshot * Adding changelog file to new location * Deleting changelog file from old location * support secrest and upstreams correctly * use getter * fix custom_resource_test.go * use constants for output format * move secret GVK * format output correctly * WIP * code complete-ish, working on tests now * removeoutput * fix NewHIstory tests * WIP * conslidate schemes * re-add assertion that was removed by accident * passing tests * fixup history_test * add changelog * introduce tests for admin server * fix e2e test * document admin api * fixup comment * fix gloo client tests * Fixup gloo admin client tests * use .String() method where possible * add tests for edge and k8s gw apis * stronger assertions, do not register schemes in init * use newScheme --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * admin/history: fast-follow PR feedback (#9856) * fast follow to previous pr * add changelog * Update projects/gloo/pkg/servers/iosnapshot/resources.go Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> --------- Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * move changelog * fixup changelog, imports --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jenny Shu <jenny.shu@solo.io> Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com>
) this commit contains no functional changes note: backport of (#9883)
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Nina Polshakova <nina.polshakova@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Signed-off-by: timflannagan <timflannagan@gmail.com> Co-authored-by: Nina Polshakova <nina.polshakova@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Tim Flannagan <timflannagan@gmail.com>
…s for enterprise tests (#9967) Co-authored-by: David Jumani <dj.davidjumani1994@gmail.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> Co-authored-by: Nina Polshakova <nina.polshakova@solo.io>
Co-authored-by: Art <artberger@users.noreply.github.com>
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: Rachael Graham <rachael.graham@solo.io>
Co-authored-by: Timofei Kukushkin <tima@kukushkin.me> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
…jected by envoy but not go (#10048)
sam-heilbron
added
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The helm value: global.extensions.dataPlanePerProxy in our doc (https://docs.solo.io/gloo-edge/latest/reference/helm_chart_values/enterprise_helm_chart_values/) is incorrect.
Docs changes
The helm value: global.extensions.dataPlanePerProxy in our doc (https://docs.solo.io/gloo-edge/latest/reference/helm_chart_values/enterprise_helm_chart_values/) should be global.extensions.dataplanePerProxy. Lowercase: p