Migrate System.Drawing.Common from dotnet/runtime into winforms #8633

* Update System.Drawing to reflect GDI+ changes - Add support ValueTypePointer encoder parameters - Support ColorSpace, ImageItems and SaveAsCmyk encoders * Skip test on NetFx * Add XML documentation Commit migrated from dotnet/runtime@e3fd0e0

Commit migrated from dotnet/runtime@2b55fe5

…et/runtime#34354) * Fix filename typo * Disable Bitmap round-tripping tests for old libgdiplus versions Old libgdiplus versions have uninitialized stack variable bug that makes Bitmap round-tripping unreliable. The bug causes Bitmap.Flags, Bitmap.HorizontalResolution and Bitmap.VerticalResolution properties to be set to bogus values if the stack happens to contain certain bit patterns. This bug was fixed for libgdiplus 6 by https://github.com/mono/libgdiplus/commit/dotnet/runtime@81e45a1d5a3ac3cf035bcc3fabb2859818b6cc04#diff-c96a8261ecb168c12b44248208da21c0R118. * Fix and simplify gdiplus library loading Commit migrated from dotnet/runtime@e1fa5d7

…runtime#34656) * Rename CoreFx.Private.TestUtilities to TestUtilities * Add TestUtilities reference to slns Commit migrated from dotnet/runtime@d0dc66b

* Enable analyzer rule xUnit1024 * Remove redundant test in System.Text.Json The very next method is a Theory with inline data that tests this exact scenario. * Rename test methods in System.Text.Json * Rename test methods in System.ComponentModel.Annotations * Private methods -> local functions in System.Text.Json * Rename test methods in System.Collections.Immutable For RemoveNonExistingTest, just moved the logic from the single-use helper into the method with the Fact attribute. * Rename test methods in System.Globalization * Rename test methods in System.Runtime.Extensions In Math.cs, removed Round_Decimal_Digits Fact which manually tested cases included in the MemberData of a Theory with the same name. * Rename test methods in System.Private.Uri * Rename test methods in System.Runtime.WindowsRuntime.UI.Xaml * Rename test methods in System.Security.Cryptography.X509Certificates * Rename test methods in System.Reflection * Remove redundant test in System.IO.FileSystem.Watcher Theory EndInit_ResumesPausedEnableRaisingEvents alredy tests the same scenario as the removed Fact of the same name. * Rename test methods in System.IO.FileSystem.Watcher * Rename test methods in System.Composition.Runtime * Rename test methods in System.Drawing.Primitives * Rename test methods in System.Reflection.Emit * Rename test methods in System.Text.RegularExpressions * Private methods -> local functions in System.Threading.Tasks.Parallel * Rename test methods in System.Threading.Tasks.Parallel * Rename test methods in System.Threading.Tasks * Simplify tests in System.Threading * Rename test methods in System.Threading * Rename test methods in Microsoft.VisualBasic.Core * Rename test methods in System.DirectoryServices.AccountManagement * Private methods -> local functions in System.Text.Encoding * Rename test methods in System.Text.Encoding * Rename test methods in System.Security.Cryptography.Primitives * Rename test methods in System.Runtime.Numeric * Rename test methods in System.CodeDom.Tests * Rename test methods in System.Reflection.Emit.ILGeneration * Rename test methods in System.Composition.AttributedModel * Rename test methods in System.Data.DataSetExtensions * Rename test methods in System.Runtime * Rename test methods in System.Runtime.InteropServices * Remove redundant test in System.ServiceModel.Syndication * Rename test methods in System.ServiceModel.Syndication * Rename test methods in System.Data.Common * Rename test methods in System.Security.Cryptography.Xml * Private methods -> local functions in System.Security.Cryptography.Xml * Simplify tests in System.Security.Cryptography.ProtectedData * Replace private methods with local functions... In System.Security.Cryptography.Algorithms * Rename test methods in System.Security.Cryptography.Algorithms * Simplify tests code in System.Collections.Concurrent * Rename test methods in System.Drawing.Common * Rename test methods in System.Data.OleDb * Rename test methods in System.ComponentModel.TypeConverter * Rename test methods in System.Web.HttpUtility * Rename test methods in System.Linq * Private method -> local function in System.Linq * Rename test methods in System.Memory * Rename test methods in System.IO.IsolatedStorage * Rename test methods in System.DirectoryServices.Protocols * Rename test methods in System.Globalization.Extensions * Private methods -> local functions in System.Globalization.Extensions * Rename test methods in System.IO.Compression * Rename test methods in System.Security.Cryptography.Encoding * Rename test methods in Microsoft.Win32.Registry * Rename test methods in System.IO.UnmanagedMemoryStream * Rename test methods in System.Collections * Rename test methods in System.Collections.Specialized * Rename test methods in System.Private.Xml * Rename test methods in System.IO.FileSystem * Rename test methods in System.Diagnostics.StackTrace * Rename test methods in System.Diagnostics * Improve some test method renames * Minor nit fixing * More improvements to test method names Commit migrated from dotnet/runtime@61733e2

Changes: - enabled `runtime (Libraries Test Run release mono Windows_NT x64 Debug)` CI lane (Windows Nano Server CI leg is disabled); - enabled the tests that pass; - marked failing test assemblies/classes/methods with `ActiveIssue` attribute using respective GH issues; - removed CoreFX.issues_windows.rsp file and related mono rsp arguments. Fixes dotnet/runtime#1980 Commit migrated from dotnet/runtime@ab6e225

…ntime#34651) * Fix PrinterSettings.SupportsColor to use the right PInvoke * PR Fedback * Fix test * PR Feedbak Commit migrated from dotnet/runtime@4265a13

…tnet/runtime#34998) * Provide better exception when saving to non-existent directory When saving an image to a non-existent directory, throw a DirectoryNotFoundException vs a System.Runtime.InteropServices.ExternalException. Fix dotnet/runtime#31367 * Change exception message to be more intuitive Use: The directory {0} of the filename {1} does not exist. instead of: The target directory {0} of the targetPath {1} does not exist. Fix dotnet/runtime#31367 * Fix test on unix by using built path. We were using a hardcoded path with backslashes. That didn't match the built path for the Assert. * Make Test conditional as it requires GDI+ * Put directory check closer to where it's used to ensure that we capture it from all Save variations. * Remove trailing whitespace * Update test to ensure it doesn't run on the .NET Framework * Change CheckIfDirectoryExists to ThrowIfDirectoryDoesntExist to match naming conventions for throw-style methods. Fix dotnet/runtime#31367 * Fixes typo in test name Fix dotnet/runtime#31367 Commit migrated from dotnet/runtime@8981ad7

* Change <Link>...</Link> to Link="..." * Format existing Link="..." Commit migrated from dotnet/runtime@890fab0

* Use GDI+1.1 API set in Windows 8 and later * PR Feedback, add meaningful test * Update System.Drawing test package from runtime-assets * PR Feedback and skip test on full framework Commit migrated from dotnet/runtime@7bd9e4f

* feedbacl from previous time * remove TargetsNet* from ItemGroup * removing targetFramework from .targets Commit migrated from dotnet/runtime@0ac72ac

…in arm/arm64 (dotnet/runtime#35690) * Reduce usage of Win7 and Win8 queues, move to CI and add CI runs in Win arm/arm62 * Disable tests blocking clean rolling build * Disable more failing tests * Disable more failing tests Commit migrated from dotnet/runtime@8b38643

* Change netcoreapp5.0 to net5.0 * Remove tfm downgrades * Rename S.R.CS.Unsfae include folder Commit migrated from dotnet/runtime@000046f

…ime#35956) * Use TargetFramework condition consistently in libs * Add docs section to describe the guideline * Update Microsoft.Extensions.DependencyInjection.csproj * Outline TargetFramework DesingTimeBuild issue * Update Microsoft.Extensions.DependencyInjection.csproj Commit migrated from dotnet/runtime@2cda903

Now that we have a Split overload that takes a single char, the previous optimization to cache an array and reuse that array with the array-based overload isn't needed. Commit migrated from dotnet/runtime@c3d7041

* Fix argument exception warnings on runtime * Apply feedback * Addressing feedback and test fix * Fix test failures * Fix tests for NetFx run * Fix suppressed warning for socket.SendAsyn(e) and fix corresponding tests * Applied feedback Commit migrated from dotnet/runtime@ee0aadc

…ime#36443) * Chckecing strings against length seem to have better perf * Apply suggestions from code review Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> * Apply suggestions from code review Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> * Update src/libraries/System.Drawing.Common/src/System/Drawing/BitmapSelector.cs Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> * Apply suggestions from code review * Update src/libraries/System.Private.CoreLib/src/System/Reflection/AssemblyNameFormatter.cs * fix build error * Update SmtpClient.cs * Update AssemblyNameFormatter.cs * Update LoggingEventSource.cs * Fix build error * Apply suggestions from code review * Update src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/SyndicationContent.cs * Fix build error * Apply suggestions from code review Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Commit migrated from dotnet/runtime@1c048bd

…runtime#36805) * Ensure Image.Save can handle non readable / seekable Streams * Address feedback * Fix Image.Save on Unix for write only non-seekable stream * Remove test which uses bogus handle value Commit migrated from dotnet/runtime@00685a7

Commit migrated from dotnet/runtime@08e0445

…me#36910) * Add linux arm/arm64 libraries checked coreclr test runs * Add linux_musl_arm64 * Disable BitmapTests on linux checked coreclr Commit migrated from dotnet/runtime@344085b

This change enables the interpreter on CI as well as providing an option for the local test run. Commit migrated from dotnet/runtime@93618ad

* Exclude MemberNotNull from various tools * Use [MemberNotNull] to reduce use of `= null!;` Commit migrated from dotnet/runtime@5f43e51

… platforms (dotnet/runtime#37479) RemoteExecutor doesn't work on platforms that can't spawn processes like iOS/Android/WebAssembly. Commit migrated from dotnet/runtime@da10ba8

Commit migrated from dotnet/runtime@dba8a3f

* Change Activity Default IdFormat to W3C * Remove the prefix from the switch and fix a test * address some of the feedback * Scope the breaking change to .NET 5 * Fix running the test on NetFX * Changed the define NET5 to W3C_DEFAULT_ID_FORMAT * Add net5 and remove netstandard2.0 configuration in the package * Return back netstandard 2.0 targetting When removing it, caused a CI source build failure Commit migrated from dotnet/runtime@c5edc00

…me#35162) * add DefaultPropertyAttribute and DefaultEventAttribute to PrintDocument class and add references to System.ComponentModel.TypeConverter * add the DefaultPropertyAttribute and DefaultEventAttribute to PrintDocument in the ref Add DefaultEventAttribute and DefaultPropertyAttribute to PrintDocument in PrintDoument.Unix.cs Commit migrated from dotnet/runtime@9de1a7e

…8410) This has three primary benefits: 1. In some cases, in particular for static fields where other static fields have non-default initialization, the C# compiler can't elide the default initialization, resulting in more IL. 2. It highlights places where the field is otherwise unused and can be deleted, but where the presence of the initialization was silencing the C# compiler's warnings about the unused field. 3. It increases consistency and decreases maintenance / code size / etc. Commit migrated from dotnet/runtime@ed78fad

Commit migrated from dotnet/runtime@3c9fcce

Commit migrated from dotnet/runtime@7edc80a

…otnet/runtime#38578) * Turn on argument exception analyzer on runtime, fix failures found Commit migrated from dotnet/runtime@06fa941

Commit migrated from dotnet/runtime@932098f

…time#38768) The property only checked for the `MONO_ENV_OPTIONS=--interpreter` env var which isn't set on WebAssembly. This needed an arcade fix to correct an inverted condition in the ActiveIssue discoverer: dotnet/arcade#5744 Commit migrated from dotnet/runtime@4aea0a1

Issue: dotnet/runtime#38889 Commit migrated from dotnet/runtime@239b0c4

Fixes dotnet/runtime#38559 Commit migrated from dotnet/runtime@5ce04cc

Commit migrated from dotnet/runtime@6072e4d

* Fix license in remainder of .cs files * Fix license header in .vb files * Fix license header in .py files * Fix license headers in .c, .cpp, .h * Fix licensing on .dat files * Fix license header in generators * Fix license headers in .asm * Fix license headers in .xml * Fix remainder of license headers * Add license default to .editorconfig * Add some missing headers * Fix Doundation to Foundation in some license headers * Add missing license headers under libraries Commit migrated from dotnet/runtime@cb1a7fe

…runtime#38999) Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Commit migrated from dotnet/runtime@16840f3

* Mark new obsoletions for .NET 5; update existing obsoletions * Exclude DirectoryServicesPermission/DirectoryServicesPermissionAttribute from obsoletions for now * No need to restore SYSLIB0003 at end of Forwards files * Use a common Obsoletions.cs file for all SYSLIB obsoletions * Resurrect CER code behind #ifdef in EventSource * Mark GlobalAssemblyCache overrides as Obsolete * Suppress Thread.Abort() error in ImageAnimator.Unix.cs * Unconditionally mark RoAssembly.GlobalAssemblyCache as obsolete * Rename MSLIB0001 to SYSLIB0001 in ref assembly * Suppress obsoletion warnings in tests * Adopt a uniform #ifdef for NET50_OBSOLETIONS * Fix BinaryFormatter obsoletion message after the rebase * Use SYSTEM_PRIVATE_CORELIB constant instead of NETCOREAPP * Remove the code comment on the ifdef * Apply feedback related to CER obsoletions * Apply feedback related to CAS * Update ref assembly to reflect SecurityManager obsoletion * Fix regression in System.IO.Pipes.NamedPipeServerStream.Windows.RunAsClient Commit migrated from dotnet/runtime@329f0db

…otnet/runtime#39551) * Remove unused local variables and methods from System.Drawing.Common Remove unused locals, and update a few unit tests that has no asserts. * Revert adding asserts in tests Since the tests run across different printer hardware they can't take a dependency on the default printer settings. Revert adding asserts in these cases so the tests still verify that the properties don't throw. Commit migrated from dotnet/runtime@1d12f2b

- Remove depprojs which currently binplace external references into the RefPath folders in favor of PackageReference and PackageDownload items. - Build all configurations by default when building an individual project (either on the CLI or inside VS) same as with the official SDK. This enables .NETFramework Test Explorer support. - Centrally define libraries that compose the shared framework instead of in each Directory.Build.props file to be able to build the targeting pack first and consume it in the OOB libraries. - Use ProjectReferences to reference OOB projects. Compile against the reference assembly but use the implementation assembly app-local during runtime. - Remove OOBs from the testhost and remove the testhost folder for .NETFramework as it isn't required anymore. - Only binplace for $(NetCoreAppCurrent) to compose a) the targeting pack, b) the runtime pack, c) the testhost, d) a full closure for the shims. - Use Targeting Packs for OOB projects (with their implicit assembly references) but still explicitly define granular references for .NETCoreApp configurations (DisableImplicitAssemblyReferences switch). Use the implicit targeting pack references in some Microsoft.Extensions.* cases. - Remove placeholder configurations as they aren't needed anymore with explicit P2Ps vs Targeting Pack references. - Remove implicit assembly references (ie for .NETFramework, mscorlib) - Remove AssemblySearchPath hacks that were introduced with b7c4cb7 as the targeting pack is now used by default. - Reduce unnecessary .NETFramework configurations that were added to run tests in favor of the already existing ref&src configurations. - Stop hardcoding the paths for wasm assemblies and use the returned TargetPath of the ProjectReferences. - Addressed formatting (ItemGroups, References at the bottom of the project file, ordering of references, use LibrariesProjectRoot instead of a relative path, unnecessary AssemblyName and RootNamespace properties which are identical to the project name, ordering of tfms) - Revert "fix clean (dotnet/runtime#33758)" Commit migrated from dotnet/runtime@809a06f

* minor formatting * ref changes Commit migrated from dotnet/runtime@621ed57

…tnet/runtime#40560) Commit migrated from dotnet/runtime@aa5fdab

* Mark System.Security.Cryptography.OpenSsl as unsupported on browser * Mark other System.Security.Cryptography APIs as unsupported on browser * Mark System.Data.Odbc.* as unsupported on browser * Mark System.DirectoryServices.Protocols APIs as unsupported on browser * Mark System.Drawing.Common APIs as unsupported on browser * Mark System.IO.Ports as unsupported on browser Commit migrated from dotnet/runtime@196fd18

Improve validation of tail calls that are not tail-prefixed in the IL but are marked as such because of TailCallStress. We now do the same correctness validation in morph for such tail calls as we do for implicit tail calls. That blocks tail calls when we have address-taken locals, struct promoted params, and pinned vars. Fixes dotnet/runtime#39398. Fixes dotnet/runtime#39309. Fixes dotnet/runtime#38892. Fixes dotnet/runtime#38889. Fixes dotnet/runtime#38887. Fixes dotnet/runtime#37117. Fixes dotnet/runtime#8017. Commit migrated from dotnet/runtime@7742b57

…d apply Unit and Name converter (dotnet/runtime#40825) * Move Font, Image, and Margins converters to System.Drawing.Common * Add FontUnit converter and FontName converter to Font properties * Fix Unix tests * Sort Compile items Commit migrated from dotnet/runtime@1dbdb8b

* Fix packaging for the browser * fix wasm leg * remove unused resource Commit migrated from dotnet/runtime@a7278fd

…it in netfx (dotnet/runtime#41145) * Move EditorAttribute to System.ComponentModel.Primitives * Add EditorAttribute to types that had it in netfx and fix some DesignerSerializableAttributes * PR Feedback * PR Feedback Commit migrated from dotnet/runtime@3130ac9

* Re-enable testing on OSX 10.15 * ActiveIssue for failing font issue Commit migrated from dotnet/runtime@3522c32

With Apple's Hardened Runtime, `/usr/local/lib` is not searched for `dlopen(3)` calls. Today, some brew packages, such as `mono-libgdiplus` (used by System.Drawing) are installed in `/usr/local/lib`. This causes `DllNotFoundException` and user is supposed to either: 1. manually create a symlink to `/usr/local/lib/libgdiplus.dylib`. 2. export `LD_LIBRARY_PATH`, `DYLD_LIBRARY_PATH` or `DYLD_FALLBACK_LIBRARY_PATH` to `/usr/local/lib`. 3. remove signature from dotnet binary: `sudo codesign --remove-signature $(command -v dotnet)` This patch adds a fallback lookup for libgdiplus.dylib, to avoid workaround on macOS (as it is done for Linux: `libgdiplus.so` falls back to `libgdiplus.so.0`). Also removed `LIBSEARCHPATH` which is unused since 8d5e610. Commit migrated from dotnet/runtime@88d5e9d

* Enabling CA1416 * Resolving PR feedback * Updating the .NET analyzers to 5.0.0-rc2.20458.2 * Resolving compilation errors on full framework * Fixing two more tfm issues with the platform compat checks * Adjusting various platform compat checks to work with netstandard and netfx Commit migrated from dotnet/runtime@23919a4

Commit migrated from dotnet/runtime@60aa3be

- Add all IDEXXXX warnings to ruleset, but as hidden for now - Enable IDE0073: file header mismatch Commit migrated from dotnet/runtime@3b6600c

* Enable IDE0062: Make local functions static * Enable IDE0079: Remove unnecessary suppression * Enable IDE0082: Convert typeof to nameof * Enable IDE0043: Validate format string * Enable IDE0041: Use is null check Commit migrated from dotnet/runtime@6b5b9f7

Commit migrated from dotnet/runtime@a8b793c

…/runtime#43074) * [System.Drawing.Common] Work around libgdiplus use after free On Windows, both of the following are legal Metafile mf = ... ; // get a metafile instance Graphics g = Graphics.FromImage(mf); g.Dispose(); mf.Dispose(); and Metafile mf = ... ; // get a metafile instance Graphics g = Graphics.FromImage(mf); mf.Dispose(); g.Dispose(); On Unix, libgdiplus has a use after free bug for the second form - the metafile native image is disposed, but the graphics instance still has a pointer to the memory that it will use during cleanup. If the memory is reused, the graphics instance will see garbage values and crash. The workaround is to add a MetadataHolder class and to transfer responsibility for disposing of the native image instance to it if the Metafile is disposed before the Graphics. Note that the following is not allowed (throws OutOfMemoryException on GDI+ on Windows), so there's only ever one instance of Graphics associated with a Metafile at a time. Graphics g = Graphics.FromImage(mf); Graphics g2 = Graphics.FromImage(mf); // throws Addresses dotnet/runtime#37838 * Formatting fixes Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> * Address review feedback * Inilne unhelpful helper * formatting Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Commit migrated from dotnet/runtime@7939172

* Fix various typos * `occurence`, `occurance` -> `occurrence` * `accross` -> `across` * `adddress`, `addresss` -> `address` * `alignement`, `aligment` -> `alignment` * Remove `c` from triple c. * Remove `s` from triple s. * In palsuite, `Successs` (with triple s) was in commented out `Trace()` message, removed all commented out `Trace()` calls from such files. * Fix invalid markdown in `unix-test-instructions.md`. * Revert event source change Commit migrated from dotnet/runtime@4486164

Commit migrated from dotnet/runtime@e8339af

…y tracking (dotnet/runtime#44136) Commit migrated from dotnet/runtime@c72678b

…ture of the sdk for platform specific tfms. (dotnet/runtime#43651) * eng change * coreclr change * libraries change * tests change * installer & mono change * py files changed * .md change * .yml change * remove redundant targetos property * Windows_NT -> windows after ninja change * fixing runtime build failure Commit migrated from dotnet/runtime@b37f10a

Commit migrated from dotnet/runtime@dc3101b

…tially (dotnet/runtime#44703) * Add slngen infra * Update all solution files Commit migrated from dotnet/runtime@ed29578

…ameworks (dotnet/runtime#44932) * disable vs restore in vs for projects targeting platform specific older frameworks * Add infra to auto-update solution files for restore * Add NuGet.config files for solutions affected by restore issue Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Commit migrated from dotnet/runtime@659c5fb

.NET Framework implementation of `FontConverter` provided a different order of font properties, that can be observed by inspecting an instance of a font in a `PropertyGrid`. Restore the original sort order. The .NET Framework implementation has another sort argument "Weight", which however doesn't appear to be a property of `Font` type. It is possible this property has existed at some point, or the converter may have been expected to work for instances of `IFontDisp` object. Either way presence or absence of "Weight" doesn't appear to make any difference, hence it has not been ported across. Fixes dotnet/runtime#45631 Commit migrated from dotnet/runtime@22328c5

… the repo (dotnet/runtime#46306) * Support runtime package descriptions * Update arcade Packaging pkg * Inline pkg descriptions for coreclr * Inline pkg descriptions for mono * Inline pkg descriptions for installer * Inline pkg descriptions for libraries Commit migrated from dotnet/runtime@ceaa8ae

…ntime#46377) * remove targets* platform condition from project references * Remove extra condition * remove redundant condition Commit migrated from dotnet/runtime@fd5609d

… add InitHandle API (dotnet/runtime#47189) * Update public SafeHandle types to have public parameterless constructors. Remove now-unneeded ILLink trim files. Make public abstract SafeHandle constructors protected. Remove comment on SafeWaitHandle * Make SafeHandle constructors public for internal types. Make internal abstract SafeHandle default constructors protected. Make non-abstract internal SafeHandles sealed when possible. More internal SafeHandle types. * Add new Marshal.InitHandle API. Fix SetHandle accessibility Fix test. Use Marshal.InitHandle. * PR feedback. * Remove trailing whitespace. Commit migrated from dotnet/runtime@3cbdf4c

When `libgdiplus` is installed via macports, `System.TypeInitializationException` exception is thrown. This is because macports installs the library in `/opt/local/lib`. ```sh $ port install libgdiplus $ port contents libgdiplus Port libgdiplus contains: /opt/local/lib/libgdiplus.0.dylib /opt/local/lib/libgdiplus.a /opt/local/lib/libgdiplus.dylib /opt/local/lib/pkgconfig/libgdiplus.pc /opt/local/share/doc/libgdiplus/AUTHORS /opt/local/share/doc/libgdiplus/COPYING /opt/local/share/doc/libgdiplus/ChangeLog /opt/local/share/doc/libgdiplus/LICENSE /opt/local/share/doc/libgdiplus/NEWS /opt/local/share/doc/libgdiplus/README.md /opt/local/share/doc/libgdiplus/TODO ``` PR adds `/opt/local/lib/libgdiplus.dylib` as a well-known probing path. Commit migrated from dotnet/runtime@687b2a9

* Consolidate Bitmap(Type, string) constructor * Fix NRE in Bitmap(Type, string) Commit migrated from dotnet/runtime@eda8ee9

* Use [NotNullWhen(true)] in more places Did a quick search/audit for methods that returned bool and took nullable object as the first input, and added [NotNullWhen(true)] where it was obviously correct. * Address PR feedback Commit migrated from dotnet/runtime@2b0e278

dotnet/runtime#47608) * Change C# names of P/Invokes of objc_msgSend to be call-site specific. * Rename to match suggested pattern * Follow Xamarin convention in all objc_msgSend cases. * Fix typo * Rename to match convention. Commit migrated from dotnet/runtime@1562cf7

* Remove DeviceContext HWND handling * Remove IDeviceContext from DeviceContext Commit migrated from dotnet/runtime@7a5e37e

…Library.*Load* on Mono. (dotnet/runtime#47705) Handle NativeLibrary.GetExport on libs loaded with Interop.Kernel32.LoadLibraryEx. dotnet/runtime#47013 changed how kernel32.dll and Ws2_32.dll gets loaded on Windows. Instead of loading using NativeLibrary.Load these system libraries are now loaded directly using LoadLibraryEx, but symbols are still handled through NativeLibrary. This short-circuits some logic in Mono that assumes all libraries gets loaded through NativeLibrary.Load. Fix adds ability to use passed in HMODULE when not finding a matching library in our native library cache and use it directly, inline with CoreClr behavior. * Handle NativeLibrary GetExport/Free using IntPtr library OS handle xplat. * Disable additional System.Drawing.Common tests due to missing COM support. Commit migrated from dotnet/runtime@6c56444

* Adding non ectensions library to transport package and moving transport package to all config leg * update servicing policy doc * change name from Microsoft.Extensions.Internal.Transport -> Microsoft.AspNetCore.Internal.Transport * make isAspnetCore property explicit * csproj to proj change * remove non used extensions assemblies from transport package * Update Directory.Build.props Commit migrated from dotnet/runtime@a66b4e3

* Fix GDI handle leak in Icon.DrawImage * Fix build * Add test * Fix test in Mono * Add missing Usings Commit migrated from dotnet/runtime@b8db68c

* Optimize Matrix.Elements Just pin the array. There is no need to allocate native memory and copy. * Move more element usage to the stack. * Remove DeleteObject call Commit migrated from dotnet/runtime@d8aa4c6

* Add Matrix3x2 transform methods This implements dotnet/runtime#47940 for System.Drawing.Common. * Move GdipGetWorldTransform into try block. * Fix build issues * Add workaround to nuget issue Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Commit migrated from dotnet/runtime@667b4e7

* Disable IsAtLeastLibgdiplus6 if !IsDrawingSupported * PR feedback Commit migrated from dotnet/runtime@b6050d2

Commit migrated from dotnet/runtime@6ce5878

…time#49405) * Don't include windows PInvokes on Unix for System.Drawing * More interop cleanup to avoid building windows only codepaths on Unix * Make lower range use handletreshold to make test more resilient Commit migrated from dotnet/runtime@f20d19d

Commit migrated from dotnet/runtime@4867914

…50047) * Enable CA1052 (static holder types should be static) * Fix a few additional warnings in 'all configurations' Commit migrated from dotnet/runtime@184a5b1

Commit migrated from dotnet/runtime@0817e74

Co-authored-by: kronic <kronic@softland.ru> Commit migrated from dotnet/runtime@62170c1

* Refactor PropertyItem image code * Refactor PropertyItemInternal * Use Windows implementation of PropertyItem in Unix * PR feedback * Use ArrayPool Commit migrated from dotnet/runtime@ec2fedc

…time#50284) Commit migrated from dotnet/runtime@15f421d

…ime#50499) * Big-endian fix: Accessing OBJECTHEADER in ImageConverter The GetBitmapStream routine in ImageConverter is supposed to skip an embedded OBJECTHEADER structure. However, this structure needs to be read in little-endian mode, not in native byte order. Fixes the ImageConverterTest.ImageWithOleHeader test on big-endian systems. * Update src/libraries/System.Drawing.Common/src/System/Drawing/ImageConverter.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Commit migrated from dotnet/runtime@78acffe

Mostly just replacing string.Format calls with equivalent interpolated string uses. In some cases, I replaced lots of string creations with a StringBuilder or equivalent. Commit migrated from dotnet/runtime@0c79392

…otnet/runtime#50907) We have a bunch of test assemblies that don't make sense on some platforms, e.g. Browser. Right now we're skipping them via `[SkipOnMono("reason", TestPlatforms.Browser)]` but there's nothing that inherently ties this to Mono other than the current implementation. The more generic `SkipOnPlatform` attribute can be used instead. We can also use it in places where we do `[PlatformSpecific(~TestPlatforms....)]` to avoid the double inversion. Commit migrated from dotnet/runtime@bc9f00c

* Add basic GetContextInfo regression tests. * Implement new GetContextInfo API overloads Implements dotnet/runtime#47880, adding new, more performant overloads for GetContextInfo. - Add helper for only creating a region if it isn't infinite - Start an internal extensions class for easier mapping of System.Drawing concepts to System.Numerics types - Simplify GraphicsContext * Update WindowsGraphics to use new overloads. * Skip tests when GDI+ isn't available. * Add `[SupportedOSPlatform("windows")]` * Use new Obsolete attribute pattern. * Use Obsoletions.cs and conditionalize in ref. * Address feedback * Conditionalize the obsoletion in the src * Update suppression in tests * Apply obsoletions downlevel using an internal ObsoleteAttribute Co-authored-by: Jeff Handley <jeff.handley@microsoft.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Commit migrated from dotnet/runtime@33033b2

* Update Font.cs * Added test for GetHashCode pr dotnet/runtime#46816 * Added SkipOnTargetFramework as GetHashCode doesn't include font name in .NET Framework and changed FontFamily to SansSarif as per PR dotnet/runtime#47674. Fixes dotnet/runtime#44343. Original PR dotnet/runtime#46816. * Update FontTests.cs * Fix test, skip font if name is equal Co-authored-by: Dan Moseley <danmose@microsoft.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Commit migrated from dotnet/runtime@f39d544

) * Drawing: Replace harvested assets with live config Removing the netcoreapp2.0, netstandard2.0 and net461 configurations of System.Drawing.Common as these aren't built live anymore (harvested). Replace the netstandard2.0 and net461 harvested asset with live builds and stop supporting netcoreapp2.x. Bringing these assets back as the minimum supported set of platforms are ones that support netstandard2.0 and are still in support. Contributes to dotnet/runtime#47530 Commit migrated from dotnet/runtime@3a249b7

Commit migrated from dotnet/runtime@61e50c1

Commit migrated from dotnet/runtime@3ffc4fc

…ling the Linker (dotnet/runtime#52272) * Adding infrastructure to run the linker on OOB Assemblies manually * Refactoring to abstract shared infrastructure * Add OOB ignore list * Address PR comments * Rename properties so they don't intentionally get reused * Addressing PR Feedback * Addressing PR Feedback Commit migrated from dotnet/runtime@d3a72e5

…time#52793) * Remove the use of IsPartialFacadeAssembly in refererences This flag requires assembly-re-writing to replace type-defs in reference assemblies with type forwards, when the same type exists in references. We've pretty much exclusively used this on .NETFramework, since it's not friendly to source build (CCI isn't part of source build). .NETFramework isn't going to be changing so it doesn't save us much to generate these typeforwards in the build. We also used these to make sure the netstandard surface area was compatible with .NETFramework facades (we'd use the pre-rewritten reference assemblies for contract), but this need goes away now that we have package validation based APICompat that compares netstandard refs to net4x facades. * Fix some projects I missed after changing naming convention * Fixup another project * Fix build of System.System.Threading.AccessControl * Adding a section to ref-source docs on .NETFramework facades * Address feedback Commit migrated from dotnet/runtime@c0a1734

…able tfms (dotnet/runtime#53244) * Generate targets files that throw for unsupported NS tfm For S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a targets file to mark the .NETStandard asset as not applicable. This was done to allow defining a minimum supported .NETCoreApp version, even though a compatible .NETStandard asset is available. This commit automatically generates that targets file based on items. Commit migrated from dotnet/runtime@293d472

* Remove NS1.x assets from build and packaging These ten projects still built for netstandard1.x. This PR trims out these assets from both the build which also results in them not being packaged anymore as there is no harvesting mechanism in the repository anymore. Suppressing the package warnings for the intentionally dropped assets and cleaning up conditions in the project file as well. For more details please see the reasoning in the linked issue. Contributes to dotnet/runtime#53282 Commit migrated from dotnet/runtime@c95aa3f

Commit migrated from dotnet/runtime@18f5931

…3358) Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations in projects to netcoreapp3.1 and cleaning up conditions so that future tfm upgrades require less project file changes. Adding NETStandardError markers to prevent available netstandard2.0 assets being picked instead, same as already done for System.Speech and others. For more details please see the reasoning in the linked issue. Contributes to dotnet/runtime#53282 Commit migrated from dotnet/runtime@4214222

* Include NetCoreAppCurrent configs in packages The NetCoreAppCurrent configurations were omitted from packages to avoid ever growing packages. Now that we adhere to the support policy for packages we don't need to exclude them anymore as the policy defines a baseline for .NETCoreApp configurations. This will remove an artificial difference when source building the repository and also make it so that partner repositories which don't depend on a transport package like windowsdesktop (winforms) receive the very latest assets that are included in the shared framework as well. * Fix package validation for non exposed inbox libs Commit migrated from dotnet/runtime@0377558

…net/runtime#53023) * Don't reference ns.dll inside shared framework The netstandard.dll shim shouldn't be referenced inside the shared framework as it's a compat shim that shouldn't be required to compose the shared framework. This removes the necessity of a separate RefPath build and improves incremental build times as only the few OOB projects that require the shim would need to rebuild. * Reference netstandard shim in OOBs that require it There are a few OOB projects that require the netstandard.dll shim as they intentionally reference projects that only expose a netstandard configuration. Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com> Commit migrated from dotnet/runtime@bbf9659

This code only runs on macOS, and expects mono's System.Windows.Forms assembly is loaded into the process. This is causing trim warnings, and it is easier just to delete this code than try to make ILLink happy. This code is only called from Graphics.FromHwnd, which doesn't work because the Carbon.framework no longer exists on macOS. Issue dotnet/runtime#22221 is tracking the test failures that use FromHwnd. Commit migrated from dotnet/runtime@c70e2e4

…/runtime#54076) * Resolving first part of System.Drawing.Common IlLink warnings * Address PR feedback Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> Commit migrated from dotnet/runtime@c4c3c93

With dotnet/runtime#22761 and dotnet/corefx#22833, BitmapSelector.Suffix will always be null. This means this feature is dead code, and users are unable to use it. Removing this dead code because: 1. It doesn't do anything. 2. It is causing ILLink warnings, and it is easier to delete than to try to address the warnings. I logged https://github.com/dotnet/runtime/issues/54363 to follow up and either re-implement this feature, or obsolete the attributes that no longer have any effect on the app. Commit migrated from dotnet/runtime@9199eb6

[main] Update dependencies from 9 repositories - Merge branch 'main' into darc-main-b0a81754-f267-416d-a8e2-cf56f8c1ee3e - PInvoke warnings fixes for OOB assemblies - Update testPackages.proj - Update testPackages.proj - Update dependencies from https://github.com/dotnet/arcade build 20210621.1 - Merge branch 'main' into darc-main-b0a81754-f267-416d-a8e2-cf56f8c1ee3e Conflicts: eng/Version.Details.xml eng/Versions.props - Fix xml - Update dependencies from https://github.com/dotnet/xharness build 20210622.2 Commit migrated from dotnet/runtime@04ad80a

…e#54218)" (dotnet/runtime#54541) This reverts commit dotnet/runtime@04ad80a. Commit migrated from dotnet/runtime@56778f0

Commit migrated from dotnet/runtime@419506b

…t/runtime#54636) * First round of converting System.Drawing.Common to COMWrappers Using COM Wrappers makes the library trim compatible. * Add Trimming Test for Icon.Save * Add support for OS specific trimming tests * Use function pointers instead of delegates * Rename Guid to IID * Better interop to closely match the native side * Release any COM pointer that was QueryInterface * Use pointers instead of Marshal.PtrToStructure/StructureToPtr * No need for a VTable struct, just set each function pointer right into the table * Wrap all managed calls in try-catch and return HResult * Use COM naming * Fix method signature to use pointer instead of out. * CheckStatus => ThrowExceptionForHR * Pass -1 to Marshal.GetExceptionForHR so it doesn't query GetErrorInfo, and always returns the correct exception type * Create the PictureWrapper with UniqueInstance, so it doesn't get cached. Caching it causes lifetime issues. Commit migrated from dotnet/runtime@8707275

…#54544) * Use property to indicate NetCoreApp min version * Add NetCoreAppCurrent to S.Numerics.Tensors * Add NetCoreAppCurrent to S.T.AccessControl * Add NetCoreAppCurrent to System.Memory.Data * Add NetCoreAppCurrent to S.Composition.* projects * Add NetCoreAppCurrent to System.IO.Packaging * Add NetCoreAppCurrent config to System.IO.Ports Adding a NetCoreAppCurrent configuration to System.IO.Ports and reducing package size, build times and platform specific assets by using runtime checks on Unix derivates for the slightly diverging SerialPort implementation. Contributes to dotnet/runtime#54012 * Add NetCoreAppCurrent to System.Data.OleDb * Add NetCoreAppCurrent to M.W32.Registry.AccessControl * Add NetCoreAppCurrent to S.Reflection.Context * Add NetCoreAppCurrent to S.C.Composition.Registration * Add NetCoreAppCurrent to S.Resources.Extensions * Add NetCoreAppCurrent to S.N.H.WinHttpHandler Commit migrated from dotnet/runtime@b056b7b

Commit migrated from dotnet/runtime@fc73461

…#54884) * Finish migrating System.Drawing.Common to ComWrappers This resolves all ILLink warnings in System.Drawing.Common, making it work in a trimmed application. Commit migrated from dotnet/runtime@890fde7

…et/runtime#54961) * Add nullable annotations to System.ComponentModel.TypeConverter * Annotate System.Data.Common * Annotations in depending projects * address feedback Commit migrated from dotnet/runtime@885296a

…55460) Commit migrated from dotnet/runtime@633e044

Commit migrated from dotnet/runtime@dfd618d

…net/runtime#55656) After dotnet/runtime#54884 these tests started failing on Mono on Windows, see dotnet/runtime#55655. Commit migrated from dotnet/runtime@01955a2

dotnet/runtime#55962) * Make System.Drawing.Common throw on Unix unless a config switch is set Commit migrated from dotnet/runtime@2ccf787

…res (dotnet/runtime#56074) It's to clean up the respective CI staging lanes. The related issues: [iOS/tvOS/MacCatalyst] Test failures in System.Diagnostics.Tracing.Tests dotnet/runtime#56073 [libraries][iOSSimulator] ImageTests.FromFile_NullFileName_ThrowsArgumentNullException fails dotnet/runtime#56048 JitInfoIsPopulated failed with after is not greater than before dotnet/runtime#55712 [MacCatalyst] Test failures in System.Tests.OperatingSystemTests dotnet/runtime#56084 [MacCatalyst] App crash in System.Text.Json.SourceGeneration.Tests dotnet/runtime#56085 Commit migrated from dotnet/runtime@f5ed68b

…en frames (dotnet/runtime#56223) Commit migrated from dotnet/runtime@7d30da6

Avoid potential problems if Return were to throw an exception after having already put the array back into the pool. Commit migrated from dotnet/runtime@59a5610

* Update slngen and invocation * Update NuGet.config files * Update solution files with slngen Commit migrated from dotnet/runtime@a6b9a63

) * Disable arm64-win10 tests preventing clean build * Use ActiveIssue with conditional Commit migrated from dotnet/runtime@643ab28

dotnet/runtime#56690) * Remove old fwlink from Obsolete messages and make message improvements * Thorough review and update of Obsolete messages * Cleanup * Make messages about unsupported APIs more consistent * Update RequiresUnreferencedCodeAttribute messages to be consistent between ref and src * Cleanup * Cleanup * Use 'not supported' instead of 'no longer supported' * Omit unnecessary error:false from Obsolete attributes. Fix message typo. * Remove old comment * PR feedback Commit migrated from dotnet/runtime@895c99c

…6712) * Runtime specific and doc file packaging fixes * Replace all remaining pkgprojs with NuGet Pack task * Avoid NuGet/Home/issues/10368 * Update PackageValidation package to latest Commit migrated from dotnet/runtime@503ae51

* Move src/libraries/pkg/test to src/libraries/testPackages * Remove default StrongNameKeyId Open properties Commit migrated from dotnet/runtime@b12fa3b

* Automatically generate .NETStandard compat errors Before this change, a project had to explicitly add a NETStandardCompatError item to declare that a given tfm range shouldn't be supported when packaging. Automate this logic so that projects don't need to specify the item themselves anymore. Instead condition the NETStandardCompatError target calcuation logic on the existence of both a .NETStandard and a .NETCoreApp tfm. * Update Directory.Build.targets * Update packaging.targets * Update eng/packaging.targets Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Commit migrated from dotnet/runtime@4d82932

…ew other tests (dotnet/runtime#57114) Since the library is PNSE by default, make sure the tests do not run on mobile. Also skips a few other tests. Closes dotnet/runtime#57184 Commit migrated from dotnet/runtime@defa26b

…eferences (dotnet/runtime#58208) Commit migrated from dotnet/runtime@67e3785

…e#58655) With the newest udpate of slngen, the order of elements (configuration, folders, etc.) is in sync with how Visual Studio arranges them. Also the order is now deterministic. Based on that, updating all solution files to have the correct ordering of elements. This change also unblocks adding CI protection for making sure that solution files are up-to-date in regards to their dependencies as slngen is now generating the files deterministically. Commit migrated from dotnet/runtime@36b6247

* Remove EOL tfms and upgrade to net7.0 * Make linker tests net7 aware Make installer tests run on net7.0 Don't attempt to use live apphost Fix payloads Regenerate test files Fix package testing Commit migrated from dotnet/runtime@67354a2

System.Drawing uses the last Win32 error in CheckErrorStatus to try to guess at why a GdiPlus draw method failed and ignore some failures. This was broken in .NETCore when SetLastError was removed from PINvokes. Bring back SetLastError for all PInvokes that use CheckErrorStatus. Commit migrated from dotnet/runtime@ca74e9a

Commit migrated from dotnet/runtime@27034bc

Commit migrated from dotnet/runtime@d924fbc

…alue (dotnet/runtime#59367) Commit migrated from dotnet/runtime@5e8ba34

Commit migrated from dotnet/runtime@ea7e817

…tion logic (dotnet/runtime#59955) Commit migrated from dotnet/runtime@8ddd92b

Commit migrated from dotnet/runtime@78f4fa8

…h Windows (dotnet/runtime#59328) Commit migrated from dotnet/runtime@4768646

…ime#60481) * Remove dotnet-experimental feed from NuGet.config * Revert changes to solution files and restore configs Commit migrated from dotnet/runtime@39048dd

Commit migrated from dotnet/runtime@5a79d96

Commit migrated from dotnet/runtime@972891f

Commit migrated from dotnet/runtime@b201a16

…otnet/runtime#60599) * Move 2 Drawing APIs that are not implemented in netfx to netcoreapp3.1 or later (dotnet/runtime#60371) * Don't use ifdefs on ref file Commit migrated from dotnet/runtime@21bdf48

Commit migrated from dotnet/runtime@16e1d9b

Update slngen tooling to latest stable version and solution files since a lot changed since the last time they were updated: - NET7 (removal of older TFMs) - Source Generators Commit migrated from dotnet/runtime@0964be0

…pack (dotnet/runtime#61437) Commit migrated from dotnet/runtime@f754496

…to use GeneratedDllImport (dotnet/runtime#62365) Commit migrated from dotnet/runtime@2cbc071

* Remove AOT warnings for S.Drawing.Common - `Marshal.SizeOf(Type)` replaced with `Marshal.SizeOt<T>()` - `Marshal.PtrToStructure(IntrPtr, Type)` replaced with `Marshal.PtrToStructure<T>(IntPtr)` * Use pointers where possible * Ref return PRINTDLG * Use GeneratedDllImport Co-authored-by: Jan Kotas <jkotas@microsoft.com> Commit migrated from dotnet/runtime@6b224f3

Commit migrated from dotnet/runtime@5a9bd5c

* Added DrawRectangle overload accepting RectangleF * Added DrawRectangle overload to reference assembly file * Added FillPie overload accepting RectangleF * Added test cases for DrawRectangle accepting RectangleF * Added FillPie argument test cases * Added XML parameters for newly added FillPie and DrawRectangle * Moving DrawRectangle and FillPie with RectangleF to netcoreapp * Moving DrawRectangle and FillPie RectangleF tests to netcoreapp * Only testing RectangleF overloads in GraphicsTests.Core.cs; other overloads stay as they are. * FillPie tests that were newly added as part of issue dotnet/runtime#62385 are split in the same manner. * Removing RectangleF overload from mono tests DrawRectangle with RectangleF overload is new and not compiled into mono. Commit migrated from dotnet/runtime@64f4885

…ntime#63340) Commit migrated from dotnet/runtime@6de7147

* Update to Xunit build 2.4.2-pre.13 Also pick up latest pre-release of analyzers * Disambiguate calls to Assert.Equals(double,double,int) Xunit added a new Assert overload that caused a lot of ambiguous calls. xunit/xunit#2393 Workaround by casting to double. * Fix new instances of xUnit2000 diagnostic * Workaround xUnit2002 issue with implicit cast Works around xunit/xunit#2395 * Disable xUnit2014 diagnostic This diagnostic forces the use of Assert.ThrowsAsync for any async method, however in our case we may want to test that a method will throw synchronously to avoid regressing that behavior by moving to the async portion of the method. * Use AssertExtensions to test for null ArgumentException.ParamName Workaround xunit/xunit#2396 * Update to Xunit 2.4.2-pre.22 * Fix another ArugmentException.ParamName == null assert Commit migrated from dotnet/runtime@1d751ba

Commit migrated from dotnet/runtime@24348f0

* Remove enable drawing on unix switch * Update some tests and not run tests that need Drawing on non Windows * PR Feedback, just turn off the switch Commit migrated from dotnet/runtime@7ed266e

…CA1066/1077) (dotnet/runtime#63690) Commit migrated from dotnet/runtime@0ac0071

…otnet/runtime#63824) * Fix formatting of resource string where excess arguments are passed. dotnet/runtime#63607 * Fix BuildCharExceptionArgs and ECCurve.Validate * Fix CA2208 * Fix CA2208. Remove paramName becaus it is in error message * Code review fixes * Code review fixes Commit migrated from dotnet/runtime@bdc0d1a

Commit migrated from dotnet/runtime@2074477

* Bump version of C# compiler This should be reverted when arcade brings in a new enough compiler. * Fix a few new warnings from updating compiler * Enable IDE0190 to employ parameter null checking * Initial roll out of !! * Fix more compiler warnings from upgrade, plus some test fixes / reverts * Fix a few more tests * Disable profiling test Commit migrated from dotnet/runtime@3ae8739

…table classification (dotnet/runtime#64279) Commit migrated from dotnet/runtime@ccd67b0

* Update to StyleCopAnalyzers 1.2.0-beta.406 * Add missing newlines at end of files to satisfy changes to SA1518 Commit migrated from dotnet/runtime@65008a9

* Don't use Targets* helper properties in libs projs This change makes it possible to migrate 200+ (ref+src) projects to use TargetFramework instead of TargetFrameworks which avoids the additional outer build evaluation and invocation which ultimately makes the overall build faster. Targets* properties (i.e. TargetsWindows, TargetsAnyOS, TargetsUnix, etc.) rely on the TargetFramework property which usually are set inside a project. The TargetFramework property is only available before a project specifies it if it's explicitly set in a props file or if the project is cross-targeting and the outer-build dispatches into the inner-build. During the dispatch, the TargetFramework property is passed in as a global property. Until now that behavior wasn't a problem because every libraries project cross-targeted (by setting the TargetFrameworks property) even though many only include a single TargetFramework (i.e. NetCoreAppCurrent). To allow projects to use the TargetFramework property instead of TargetFrameworks, the Targets* helper properties can't be calculated anymore early in a props file as the TargetFramework property isn't set at that time. In general, the guidance by the SDK/msbuild team is to not read from the TargetFramework property before the project sets it (in a property group). That effectively means that the TargetFramework property shouldn't be used in props files at all. Therefore these helper properties can't be used anymore for property conditions and I'm replacing their usage with TargetPlatformIdentifier comparisons for both properties and items. In nearly all cases, the Targets* helper properties can be replaced with TargetPlatformIdentifier checks on items and in the few cases where TargetsUnix or TargetsLinux marks multiple tfms as compatible, the exact tfms must be used instead for the TargetPlatformIdentifier comparison. Whenever a project needs to condition properties on the platform, I'm first setting the TargetPlatformIdentifier the same way the SDK sets it so that the SDK later doesn't need to set it again to avoid the additional expensive msbuild function call. * Use TargetFramework singular to avoid outer builds Use TargetFramework instead of TargetFrameworks property whenever a projects only targets a single target framework. This avoid unnecessary outer builds and evaluations and makes the build faster. Commit migrated from dotnet/runtime@20e8f90

…oreClr (dotnet/runtime#64891) * Disable tests on Debug CoreClr that are already disabled on Checked CoreClr * Increase Process timeout * Extract timeout modifier and make Debug only * Update src/libraries/System.Text.RegularExpressions/tests/Regex.Match.Tests.cs Commit migrated from dotnet/runtime@348e06c

* Update conversion code fix to offer multiple fixes for appending each previously probed entry-point suffix when ExactSpelling is false. * Remove ExactSpelling property and move properties that were relying on ExactSpelling = false to use explicit entrypoint names. * Emit ExactSpelling = true for all of our emitted target DllImports. * Fix a few entry points * Add a comment around CharSet.Auto * Update compatibility doc. * Update docs/design/libraries/DllImportGenerator/Compatibility.md Co-authored-by: Elinor Fung <elfung@microsoft.com> Co-authored-by: Elinor Fung <elfung@microsoft.com> Commit migrated from dotnet/runtime@ca6f420

* private assemblies moved from Internal to System Runtime.CompilerServices * reformat existing unsafe vm intrinsics * implement Copy, CopyBlock, CopyBlockUnaligned, InitBlock, InitBlockUnaligned, Unbox, Add, Subtract, SubtractByteOffset * remove System.Runtime.CompilerServices.Unsafe il project and replace with forward only cs project * change all ilproj references to csproj * remove nativeaot Unsafe * add conditional package reference for S.R.CS.Unsafe on netcoreapp 6.0 * regenerate solutions * mono interp * [mono][interp] Implement Copy and Unbox intrinsics * [mono][jit] Implement Copy and Unbox intrinsics Co-authored-by: Vlad Brezae <brezaevlad@gmail.com> Commit migrated from dotnet/runtime@ddb22ef

* Fix slngen.proj The SolutionName property is defined by the SDK and hence the condition was always true. Also the star (*) didn't expand when using the ValurOrDefault msbuild function. Fixing this by using a different name `SolutionNameOverride` and avoiding the ValueOrDefault msbuild function. * Update solution files Updating the solution files as those changed because of microsoft/slngen@cb57e28 and apparently the solution files never were updated. Commit migrated from dotnet/runtime@febaf76

…et/runtime#65544) Commit migrated from dotnet/runtime@7984b32

) The nullability of parameter 'destinationType' in TypeConverter.CanConvertTo(...) was changed from not-nullable to nullable during the development of .NET 6. Since a destination type supported by this TypeConverter can never be null, a NotNullWhenAttribute is added to the 'destinationType' parameter when the result value of TypeConverter.CanConvertTo(...) is 'true'. Fix dotnet/runtime#63186 Commit migrated from dotnet/runtime@ac246b1

…nd src and DefineConst clean-up (dotnet/runtime#65847) * NET5_0_OR_GREATER, NET6_0_OR_GREATER -> NETCOREAPP The minimum supported .NETCoreApp version in the repository is 6.0, hence both defines can be replaced with the versionless NETCOREAPP one. There is no need to version APIs below the minimum supported .NETCoreApp version. * Sync ObsoleteAttribute between ref and src ApiCompat wasn't enabled to check if the ObsoleteAttribute is in sync between the ref and the src assembly. Enabling it showed numerous mismatches which this commit fixes. Also making sure that the ApiCompat run that compares the live build against the previous version of .NETCoreApp and .NETStandard2.x doesn't complain about ObsoleteAttribute API changes as those are intentional. * Sync EditorBrowsableAttribute between ref and src The EditorBrowsableAttribute attribute wasn't enabled to be checked by ApiCompat and in many cases there were mismatches. The most prominent were InteropServices. * HttpListenerContext pr feedback * ResourceManager pr feedback * Json PR feedback * Fix cryptography PNSE build Commit migrated from dotnet/runtime@e18a77f

* Use generic `Enum` methods when possible. * Update src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ToolboxItemFilterAttribute.cs Co-authored-by: Günther Foidl <gue@korporal.at> Co-authored-by: Günther Foidl <gue@korporal.at> Commit migrated from dotnet/runtime@d579527

Commit migrated from dotnet/runtime@922777a

…ntime#65949) Commit migrated from dotnet/runtime@7e35e93

…et/runtime#66029) Commit migrated from dotnet/runtime@a063583

…net/runtime#66307) Commit migrated from dotnet/runtime@c2ec86b

…ify marshaller types (dotnet/runtime#65591) Commit migrated from dotnet/runtime@a02b49a

…untime#67061) * Update coding-style to include target-typed new guideline Similar to `var` usage, `new()` usage is only allowed when the Type can be understood from the same line. Fix dotnet/runtime#53369 * Fix coding style violations Commit migrated from dotnet/runtime@7508080

Commit migrated from dotnet/runtime@c49593c

Commit migrated from dotnet/runtime@6a889d2

Commit migrated from dotnet/runtime@c8a1748

… for string marshalling (dotnet/runtime#67635) Commit migrated from dotnet/runtime@f502039

…ntime#64623) * Remove all Unix-specific files. * Throw PNSE on non-Windows. * Merge the Windows-specific files into their formerly cross-platform counterparts. * Remove all mentions of Unix in the tests. * Remove two always-on defines. * Merge two item groups in the project file. No reason to sort them; the list is already unsorted. And rename a remaining formerly Windows-specific file. * Remove the NoCOMWrappers files. * Fail on unsupported platforms when a library is trying to be loaded. * Fix compile errors. * Small changes in the project file. * Remove two meaningless asserts. * Run BinaryFormatter tests on SDC types only on Windows. * Use `[ThreadStatic]` in Gdip.ThreadData. * Remove `TargetsAnyOS`. Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * SDC project file clean-up * Remove `!!` from System.Drawing.Common. Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Commit migrated from dotnet/runtime@5b55b06

* Remove usage of !! from dotnet/runtime - Use ArgumentNullException.ThrowIfNull instead where possible. It's only usable for projects that only target .NET 6+, and it can't be used in places like this(...) or base(...). - In other cases, if the project already has a ThrowHelper, augment it for null as needed and use that. - For most of the extensions projects, add a ThrowHelper.ThrowIfNull that replicates ArgumentNullException.ThrowIfNull. - For everything else, just use "throw new". * Address PR feedback * Address PR feedback * Remove false positives from searches * Address PR feedback Commit migrated from dotnet/runtime@215b39a

…rivate types) rules (dotnet/runtime#68268) * Enable new CA1311 (ToLower/Upper culture) and CA1852 (seal internal/private types) CA1311 flagged a few issues, all addressed by using ToLowerInvariant/ToUpperInvariant. CA1852 flagged a bunch that previous cleanups around sealing types missed or that are new since. Sealing types then highlighted places where protected or virtual members were being exposed unnecessarily, so those were fixed, too. Adding sealed to things also highlighted some discrepancies in the order of "unsafe sealed" keywords, where the vast majority in the repo were "sealed unsafe", so I fixed the few that weren't. * Address PR feedback and fix more CI failures * Fix unit test build error Commit migrated from dotnet/runtime@46871b8

…et/runtime#68334) I've focused only on src and only on non-allocating use. Commit migrated from dotnet/runtime@d122daa

dotnet/runtime#68102) * Change the default Nullable to enabled for src projects * Set Nullable=enable as the default for ref projects * Fixup merge conflicts * Disable nullable on shim projects and EventLog.Messages * Set Nullable to blank on EventLog.Messages This way no CodeAnalysis attributes are emitted into the assembly. Commit migrated from dotnet/runtime@18be907

* Fix VS complaining about missing projects in slns Remove inbox (Project-)References in out-of-band projects as these projects already build on top of the shared framework (targeting pack). * Update Microsoft.Extensions ref projects * Update Microsoft.Extensions src projects * Update graph dependencies of Microsoft.Extensions* * Update sources that complained about Span usage Commit migrated from dotnet/runtime@09dc0fe

…arshalling` (dotnet/runtime#68842) Commit migrated from dotnet/runtime@bcded44

Commit migrated from dotnet/runtime@52fd1a5

…re (dotnet/runtime#69627) * Update MicrosoftNetCompilersToolsetVersion to 4.3.0-2.22270.2 * Updating IntPtr/UIntPtr and a handful of tests to handle the numeric-intptr feature * Ensure IntPtr.TestExplicitCast and UIntPtr.TestExplicitCast correctly check the overflow exception * Update the Microsoft.Dotnet.Compatibility analyzer to 2.0.0-preview.4.22252.4 * Updating the CompatibilitySuppressions for the NumericIntPtr feature * Handle a difference in how the OverflowException is thrown for a reflected call on Mono * Use Assert.ThrowsAny as that includes derived types for xUnit Commit migrated from dotnet/runtime@7626c5d

* Use u8 in more places Primarily replacing Encoding.UTF8/ASCII.GetBytes("literal") with "literal"u8.ToArray() * Address PR feedback (and fix some vars) Commit migrated from dotnet/runtime@0c4ee9e

* Update dependencies from https://github.com/dotnet/icu build 20220523.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 7.0.0-preview.5.22269.3 -> To Version 7.0.0-preview.5.22273.1 * Update dependencies from https://github.com/dotnet/xharness build 20220524.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22270.1 -> To Version 1.0.0-prerelease.22274.1 * Update dependencies from https://github.com/dotnet/runtime-assets build 20220523.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 7.0.0-beta.22267.1 -> To Version 7.0.0-beta.22273.1 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220524.2 Microsoft.CodeAnalysis.NetAnalyzers From Version 7.0.0-preview1.22252.2 -> To Version 7.0.0-preview1.22274.2 * Update dependencies from https://github.com/dotnet/msquic build 20220523.2 System.Net.MsQuic.Transport From Version 7.0.0-alpha.1.22273.1 -> To Version 7.0.0-alpha.1.22273.2 * Update dependencies from https://github.com/dotnet/icu build 20220525.2 Microsoft.NETCore.Runtime.ICU.Transport From Version 7.0.0-preview.5.22269.3 -> To Version 7.0.0-preview.6.22275.2 * Update dependencies from https://github.com/dotnet/emsdk build 20220525.2 Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.0-preview.5.22268.1 -> To Version 7.0.0-preview.6.22275.2 * Update dependencies from https://github.com/dotnet/xharness build 20220526.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22270.1 -> To Version 1.0.0-prerelease.22276.1 * Update dependencies from https://github.com/dotnet/emsdk build 20220525.3 Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.0-preview.5.22268.1 -> To Version 7.0.0-preview.6.22275.3 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220527.2 Microsoft.CodeAnalysis.NetAnalyzers From Version 7.0.0-preview1.22252.2 -> To Version 7.0.0-preview1.22277.2 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20220529.1 optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.22217.3 -> To Version 1.0.0-prerelease.22279.1 * Update dependencies from https://github.com/dotnet/runtime build 20220529.1 Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 7.0.0-preview.5.22272.3 -> To Version 7.0.0-preview.6.22279.1 * Update dependencies from https://github.com/dotnet/icu build 20220530.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 7.0.0-preview.5.22269.3 -> To Version 7.0.0-preview.6.22280.1 * Update dependencies from https://github.com/dotnet/icu build 20220530.2 Microsoft.NETCore.Runtime.ICU.Transport From Version 7.0.0-preview.5.22269.3 -> To Version 7.0.0-preview.6.22280.2 * Update dependencies from https://github.com/dotnet/xharness build 20220530.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22270.1 -> To Version 1.0.0-prerelease.22280.1 * Add manual marshalling for non-blittable delegates defined in System.Drawing.Common (which has the DisableRuntimeMarshallingAttribute applied) passed to P/Invokes. * Update dependencies from https://github.com/dotnet/xharness build 20220601.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22270.1 -> To Version 1.0.0-prerelease.22301.1 * Update dependencies from https://github.com/dotnet/runtime-assets build 20220531.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 7.0.0-beta.22267.1 -> To Version 7.0.0-beta.22281.1 * Update dependencies from https://github.com/dotnet/emsdk build 20220531.1 Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.0-preview.5.22268.1 -> To Version 7.0.0-preview.6.22281.1 * Update dependencies from https://github.com/dotnet/msquic build 20220531.1 System.Net.MsQuic.Transport From Version 7.0.0-alpha.1.22273.1 -> To Version 7.0.0-alpha.1.22281.1 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220601.1 Microsoft.CodeAnalysis.NetAnalyzers From Version 7.0.0-preview1.22252.2 -> To Version 7.0.0-preview1.22301.1 * Update dependencies from https://github.com/dotnet/msquic build 20220601.1 System.Net.MsQuic.Transport From Version 7.0.0-alpha.1.22273.1 -> To Version 7.0.0-alpha.1.22301.1 * Move OleDB to use more manual marshalling instead of delegate marshalling. * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220602.1 Microsoft.CodeAnalysis.NetAnalyzers From Version 7.0.0-preview1.22252.2 -> To Version 7.0.0-preview1.22302.1 * Update dependencies from https://github.com/dotnet/runtime build 20220605.4 Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 7.0.0-preview.5.22272.3 -> To Version 7.0.0-preview.6.22305.4 * Update dependencies from https://github.com/dotnet/xharness build 20220605.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22270.1 -> To Version 1.0.0-prerelease.22305.1 * Update dependencies from https://github.com/dotnet/icu build 20220606.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 7.0.0-preview.5.22269.3 -> To Version 7.0.0-preview.6.22306.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Commit migrated from dotnet/runtime@4df33c8

Commit migrated from dotnet/runtime@76b5b76

…70583) Commit migrated from dotnet/runtime@624be28

…e#70522) Commit migrated from dotnet/runtime@502f9ac

* Enable IDE0054 (Use compound assignment) * Update src/libraries/System.Data.Common/src/System/Data/Common/StringStorage.cs Co-authored-by: Tanner Gooding <tagoo@outlook.com> Co-authored-by: Tanner Gooding <tagoo@outlook.com> Commit migrated from dotnet/runtime@a796755

Commit migrated from dotnet/runtime@656f909

Commit migrated from dotnet/runtime@8442a62

Commit migrated from dotnet/runtime@246d9bb

…correctly. (dotnet/runtime#71225) Commit migrated from dotnet/runtime@6c209dc

…et/runtime#71239) Commit migrated from dotnet/runtime@d58c5cc

* Enable using the new generator attributes before the new API shapes are approved * Disable the diagnostic that verifies that a marshaller type has the v1 attribute. * Convert some custom type marshallers to the v2 design. Convert as many of the marshallers as possible to their correct representation with the currently implemented feature set. This PR does not convert marshallers that can be represented with the new design but need more features to be accurately represented. Commit migrated from dotnet/runtime@ffa0fff

Commit migrated from dotnet/runtime@988f570

Commit migrated from dotnet/runtime@e55c908

Commit migrated from dotnet/runtime@6c10d0e

…time#71227) * Add `System.Drawing.Imaging.ImageFormat.Heif` and `Webp`. * Add these formats in the ImageConverterTests. Commit migrated from dotnet/runtime@7eb5664

* Disable failing graphics tests on windows 7 Related: https://github.com/dotnet/runtime/issues/51097. Disables the failing tests on Windows 7 as well. Commit migrated from dotnet/runtime@879f201

…support (dotnet/runtime#71682) Commit migrated from dotnet/runtime@c99b5b0

Commit migrated from dotnet/runtime@0c631ab

A newer version of Microsoft.CodeAnalysis.* causes some of the rules to fire in more cases. Fixing them proactively before we ingest newer versions of these libs. Commit migrated from dotnet/runtime@983c8f2

Commit migrated from dotnet/runtime@c670547

…custom marshallers (dotnet/runtime#72129) Commit migrated from dotnet/runtime@8e4fe9a

* Fix typos * Cleanup trailing whitespaces in committed files * Revert a macro for win32 compat * Disambiguate test data method * Revert XMLPath test which rely on external assets * Revert whitespace change in Xml tests * Revert ClrEtwAl and ILLink.Shared * Revert crossgen2 props/targets and *.wxl Commit migrated from dotnet/runtime@3ea30ed

Commit migrated from dotnet/runtime@9482f06

…tnet/runtime#72686) nameof can now be used in attributes on and in method signatures to refer to parameter names in the same signature. Commit migrated from dotnet/runtime@5a073b2

Commit migrated from dotnet/runtime@9d6396d

…zer (dotnet/runtime#72888) Commit migrated from dotnet/runtime@a01aea9

Commit migrated from dotnet/runtime@2201016

Commit migrated from dotnet/runtime@2327a36

) * update suppressions * remove new files * remove new suppressions Commit migrated from dotnet/runtime@04ca89d

…75447) The latest APICompat doesn't emit compatibility differences anymore for nint vs IntPtr and nuint vs UIntPtr. Updating to the new version to clean-up the checked-in suppression files. Also updating the transport package properties as APICompat now supports multi-assembly packages. This change disables the (now possible) use of APICompat in these projects as enabling it in a useful way will require more work on the consumption side. Commit migrated from dotnet/runtime@2921c2f

StartDoc takes a pointer to a DOCINFO struct. We had DOCINFO defined as a class on the managed side such that built-in marshalling would marshal it as a pointer. With the switch to custom marshalling via NativeMarshalling, we ended up marshalling the struct that is the native representation rather than a pointer to it. This switches the DOCINFO to a struct and updates the parameter to StartDoc to be in, such that it should be marshalled as a pointer to the struct by both generated and built-in marshalling. Commit migrated from dotnet/runtime@a6d3960

…me#75557) Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Tanner Gooding <tagoo@outlook.com> Commit migrated from dotnet/runtime@691cf0f

…roller (dotnet/runtime#76752) Commit migrated from dotnet/runtime@43f7699

…et/runtime#73263) * ApiCompat infra changes * Convert baseline to suppression files * ApiCompat.proj * update suppressions * sorted suppressions * rebase and update suppressions * enable attribute and param rules * Enable optional rules * WebAssemblyThreading proj * CompatSuppression for XmlREaderWriter * Enable optional rules correctly... * ThreadPool UnsupportedOSPlatformAttribute * VBCore CP0017 * Migrate all CoreLibs over * Update ApiCompat.proj * Add ApiCompat.proj baselines * Update ApiCompat.proj * Clean-up suppression files with nint/IntPtr fix * Clean-up CoreLib suppression * Update suppression files with latest apicompat fix * Update suppression files * update suppressions * Update suppression files * Clean-up obsolete suppression files * Update suppression files * update suppressions * huge reduction in suppression file size * update suppressions * more suppressions removed * update suppressions * Update dependencies and clean-up * Add suppression files for CoreLib and fix path * Update CoreLib coreclr suppression file * Update coreclr suppression files * Suppression file fixes and Linux path fixes * Update coreclr suppression again) * Fix suppression file path calculation * Fix previous mistake * Diagnostics.Tracing suppression file * Threading suppression file fix * use global suppression for CryptoSignedXmlRecursionException * Add Specification.Tests suppression * Disable NoTargets ref copying * Fix for coreclr build * Avoid duplicate project evals Co-authored-by: smasher164 <akhilindurti@microsoft.com> Co-authored-by: Akhil Indurti <aindurti@gmail.com> Commit migrated from dotnet/runtime@960e4d7

…tnet/runtime#77565) * Move Library names to Common directory * Move ExtractAssociatedIcon P/Invoke to Interop.ExtractAssociatedIcon.cs * Move PrintDlg P/Invoke to Interop.PrintDlg.cs * Move Kernel32 P/Invoke to Interop.*.cs * Move Winspool P/Invoke to Interop.*.cs * Move User32 P/Invoke to Interop.*.cs * Move Gdi32 P/Invoke to Interop.*.cs Commit migrated from dotnet/runtime@22de912

Commit migrated from dotnet/runtime@8918adf

Commit migrated from dotnet/runtime@f8b35e4

Commit migrated from dotnet/runtime@057c3f8

Commit migrated from dotnet/runtime@7a24341

Commit migrated from dotnet/runtime@da173cc

Commit migrated from dotnet/runtime@10e929a

Commit migrated from dotnet/runtime@b0c8d0b

Commit migrated from dotnet/runtime@3855a99

…SecondAttempt Update assembly version from hardcoded to MajorVersion and update NetCoreAppCurrent to net8.0 Commit migrated from dotnet/runtime@315f4ab

* Add generic Enum.TryFormat method * Rewrite Enum using generic specialization per underlying type Also revises the shape of the newly added Enum.TryFormat method and fixes tests accordingly. * Use Enum.TryFormat in interpolated string handlers * Implement ISpanFormattable on Enum * Use generic Enum methods in more places * Replace Unsafe.As with unmanaged pointers where possible Reduces cost of the generic methods * Simplify Enum_GetValuesAndNames QCall, fix handling of floats and doubles This change avoids allocation of the temporary ulong[] array during EnumInfo initialization Fixes dotnet/runtime#29266 * Fix mono's GetEnumNamesAndValues, and make ToObject handle float/double as well * Fix perf gap and polish * Undo update of Enum.GetTypeCode to include float/double * Address PR feedback * Accomodate net8.0 TFM update * Fix InvalidCastException from GetEnumValues on mono when dealing with bool-based enums Co-authored-by: Heath Baron-Morgan <heathbm@outlook.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Commit migrated from dotnet/runtime@62f3eb2

System.Drawing.Common was throwing PNSEs on non Windows platforms when accessing public API which makes sense as the library isn't supposed to be used on other platforms. That said, we already have a runtime hook that throws when DllImports are invoked. We intentionally want to allow accessing Drawing exchange types to not break customers when they don't rely on GDI+ or other native functions. This is also part of a wider effort that allows this library to be ported to another repository (which doesn't support targeting RIDs). Commit migrated from dotnet/runtime@7c265c3

* Fix most violations of new CA1859 The analyzer recommends replacing uses of types with other types that could reduce overheads (e.g. `List<T>` instead of `IList<T>`). This fixes most of the violations we currently have of the rule, but it doesn't enable it yet because there are too many false positives; fixes for those are in-flight. Some of these replacements won't help with perf (e.g. using `ArgumentException` instead of `Exception` as the return type of a throw helper create method), but there's little harm to them, and some of them do avoid overheads like allocation (e.g. foreach'ing something typed as `Dictionary<>` instead of `IDictionary<>` will avoid an enumerator allocation, accessing `Count` on a `List<T>` instead of `IList<T>` will avoid an interface dispatch, etc.) * Fix mistaken replacement Commit migrated from dotnet/runtime@210a7a9

* EnableAotAnalyzer by default for src libraries This flips the default of EnableAotAnalyzer to true so all new libraries are analyzed by default. It also allows us to easily see which libraries haven't been annotated yet. I also fixed the warnings in 2 libraries that were really quick: System.Memory.Data and System.ComponentModel.TypeConverter. Contributes to dotnet/runtime#75480 Commit migrated from dotnet/runtime@ea7e1c7

* remove test references to archaic Linux versions * Fix tests on Nano Co-authored-by: Jan Kotas <jkotas@microsoft.com> Commit migrated from dotnet/runtime@2749ee1

Add build and packagnig logic including common files from dotnet/runtime. This is necessary in order for the projects to build successfully. Remove PackageReferences to System.Drawing.Common and instead use the live build references.

The following commits are manually applied: - dotnet/runtime@a491daa - dotnet/runtime@58d1ecb - dotnet/runtime@6aa31aa - dotnet/runtime@bac3bef - dotnet/runtime@e486f38

Migrate System.Drawing.Common from dotnet/runtime into winforms #8633

Migrate System.Drawing.Common from dotnet/runtime into winforms #8633

Commits on Mar 19, 2020

Commits on Mar 23, 2020

Commits on Apr 1, 2020

Commits on Apr 7, 2020

Commits on Apr 8, 2020

Commits on Apr 10, 2020

Commits on Apr 15, 2020

Commits on Apr 17, 2020

Commits on Apr 25, 2020

Commits on May 2, 2020

Commits on May 4, 2020

Commits on May 5, 2020

Commits on May 6, 2020

Commits on May 11, 2020

Commits on May 13, 2020

Commits on May 15, 2020

Commits on May 19, 2020

Commits on May 22, 2020

Commits on May 27, 2020

Commits on May 28, 2020

Commits on Jun 9, 2020

Commits on Jun 17, 2020

Commits on Jun 19, 2020

Commits on Jun 23, 2020

Commits on Jun 26, 2020

Commits on Jun 29, 2020

Commits on Jun 30, 2020

Commits on Jul 2, 2020

Commits on Jul 3, 2020

Commits on Jul 7, 2020

Commits on Jul 8, 2020

Commits on Jul 9, 2020

Commits on Jul 18, 2020

Commits on Jul 23, 2020

Commits on Jul 30, 2020

Commits on Aug 9, 2020

Commits on Aug 13, 2020

Commits on Aug 15, 2020

Commits on Aug 18, 2020

Commits on Aug 23, 2020

Commits on Aug 24, 2020

Commits on Sep 1, 2020

Commits on Sep 10, 2020

Commits on Sep 15, 2020

Commits on Sep 24, 2020

Commits on Sep 25, 2020

Commits on Sep 27, 2020

Commits on Oct 8, 2020

Commits on Oct 10, 2020

Commits on Oct 17, 2020

Commits on Nov 2, 2020

Commits on Nov 9, 2020

Commits on Nov 17, 2020

Commits on Dec 2, 2020

Commits on Dec 11, 2020

Commits on Dec 22, 2020

Commits on Jan 4, 2021

Commits on Jan 20, 2021

Commits on Jan 26, 2021

Commits on Jan 29, 2021

Commits on Jan 30, 2021

Commits on Feb 2, 2021

Commits on Feb 3, 2021

Commits on Feb 4, 2021

Commits on Feb 8, 2021

Commits on Feb 9, 2021

Commits on Mar 4, 2021

Commits on Mar 5, 2021

Commits on Mar 6, 2021

Commits on Mar 11, 2021

Commits on Mar 23, 2021

Commits on Mar 26, 2021

Commits on Apr 1, 2021

Commits on Apr 5, 2021

Commits on Apr 9, 2021

Commits on Apr 16, 2021

Commits on Apr 23, 2021

Commits on Apr 29, 2021